Give ActionBar a configurable foreground and background color in the style
Bug #1597774 reported by
Tim Peeters
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Medium
|
Unassigned | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Medium
|
Tim Peeters |
Bug Description
Currently apps can add a Rectangle behind the ActionBar, and use a custom delegate to change the foreground color. But directly adding a foregroundColor and backgroundColor property to the ActionBar would be more handy. This is also the way it is done in the PageHeaderStyle.
Also, the new designs for adding scrolling of icons in the ActionBars, see bug 1558018 , feature a scroll button that overlays the icons in the ActionBar. The scroll button must have the same background color as the background of the ActionBar, but that color is not available now because the ActionBarStyle has no backgroundColor.
Related branches
lp://staging/~tpeeters/ubuntu-ui-toolkit/ActionBar-colors
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Cris Dywan: Approve
-
Diff: 595 lines (+257/-28)11 files modifiedcomponents.api (+10/-0)
src/Ubuntu/Components/1.3/PageHeader.qml (+6/-0)
src/Ubuntu/Components/Styles/1.3/ActionBarStyle.qml (+12/-2)
src/Ubuntu/Components/Styles/1.3/ActionItemProperties.qml (+56/-0)
src/Ubuntu/Components/Styles/1.3/PageHeaderStyle.qml (+7/-0)
src/Ubuntu/Components/Styles/Styles.pro (+1/-0)
src/Ubuntu/Components/Styles/qmldir (+1/-0)
src/Ubuntu/Components/Themes/Ambiance/1.3/ActionBarStyle.qml (+36/-6)
src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeaderStyle.qml (+19/-2)
tests/unit/visual/tst_actionbar.13.qml (+78/-17)
tests/unit/visual/tst_pageheader.13.qml (+31/-1)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Tim Peeters (tpeeters) |
description: | updated |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
importance: | Undecided → Medium |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in canonical-devices-system-image: | |
status: | New → Fix Committed |
importance: | Undecided → Medium |
milestone: | none → 13 |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Status changed to 'Confirmed' because the bug affects multiple users.