TextField/Area should only show focus outline for keyboard input focus
Bug #1522739 reported by
Cris Dywan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
High
|
Zoltan Balogh | ||
| ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Cris Dywan | ||
| ubuntu-ui-toolkit (Ubuntu RTM) |
Fix Released
|
High
|
Cris Dywan | ||
Bug Description
As it says on the tin. TextField and TextArea should only show the focus outline for keyboard input focus ie. Tab was used to enter the component. Touch or mouse input only affects cursor/ selection (activeFocus will still be true for all of these cases and affect the tab order).
Related branches
lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/inputHandlerKeyNavigation
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Zsombor Egri: Approve
-
Diff: 397 lines (+121/-55)10 files modifiedsrc/Ubuntu/Components/1.3/InputHandler.qml (+20/-1)
src/Ubuntu/Components/1.3/TextArea.qml (+2/-20)
src/Ubuntu/Components/1.3/TextField.qml (+2/-11)
src/Ubuntu/Components/Themes/Ambiance/1.3/TextAreaStyle.qml (+14/-2)
src/Ubuntu/Components/plugin/ucstyleditembase.cpp (+14/-18)
src/Ubuntu/Components/plugin/ucstyleditembase.h (+1/-1)
tests/unit_x11/tst_components/MockKeyboard.qml (+64/-0)
tests/unit_x11/tst_components/MockKeyboard13.qml (+1/-1)
tests/unit_x11/tst_components/tst_focus.qml (+2/-0)
tests/unit_x11/tst_components/tst_textinput_common13.qml (+1/-1)
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Zoltan Balogh (bzoltan) |
| milestone: | none → ww08-2016 |
| Changed in canonical-devices-system-image: | |
| importance: | Undecided → High |
| status: | New → Confirmed |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → In Progress |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | Triaged → In Progress |
| Changed in canonical-devices-system-image: | |
| milestone: | ww08-2016 → 11 |
| Changed in ubuntu-ui-toolkit (Ubuntu RTM): | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Christian Dywan (kalikiana) |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Confirmed |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → In Progress |
Revision history for this message
| Łukasz Zemczak (sil2100) wrote | #1 |
| Changed in ubuntu-ui-toolkit (Ubuntu RTM): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-ui-toolkit 1.3.1960+
---------------
ubuntu-ui-toolkit (1.3.1960+
[ Andrea Bernabei ]
* Scrollbar: new visual update for pressed/hovered states plus handling of
restricted size corner cases (shrinking etc). Fixes LP: #1573355
[ Christian Dywan ]
* Run pep8 as part of 'make check' unit test runs. The MR includes fixes to
make pep8 pass on Jenkins as well as a regression in the test method
introduced by the previous, larger pep8-related reformattings.
Fixes LP: #1454322, LP: #1572981.
* Use gu in expected position for test_popover_
Fixes LP: #1569794.
* XML test results all may not start with test_tst_. Fixes LP: #1573629
* Handle keyNavigationFocus in InputHandler. Fixes LP: #1522739
[ Zsombor Egri ]
* Fix binding loops in AbstractButton. Fixes LP: #1553090
[ Gerry Boland ]
* Enable dynamic changing of grid units instigated by the shell. Fixes LP: #1573532
[ Tim Peeters ]
* Fix horizontal keyboard navigation in ListView. Fixes LP: #1572991
* Sections keyboard and focus handling. Fixes LP: #1523840
* Fix header screen orientation detection. Fixes LP: #1574663
[ CI Train Bot ]
* No-change rebuild.
-- Zoltan Balogh <email address hidden> Thu, 28 Apr 2016 11:27:10 +0000