Text selection popup is sometimes on top of the selection handles
Bug #1388172 reported by
Florian Boucault
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-ui-toolkit (Ubuntu) |
Fix Committed
|
High
|
Florian Boucault | ||
Bug Description
Steps to reproduce:
1. Type multiple lines of text in a multi line text field (TextArea)
2. Select the text
3. Long press on the second row of the selection just below beginning of the selection
Current result:
The copy/paste selection popup appears just above where the long press was done hiding the beginning of the selection and therefore making it impossible to drag the selection handle.
Expected result:
The copy/paste selection popup should appear just above the entire selection.
Related branches
lp://staging/~fboucault/ubuntu-ui-toolkit/text_input_larger_selection_handle_on_trunk
- Cris Dywan: Approve
- Zoltan Balogh: Approve
- Zsombor Egri: Pending requested
- Tim Peeters: Pending requested
-
Diff: 720 lines (+286/-155)12 files modifiedmodules/Ubuntu/Components/InputHandler.qml (+4/-2)
modules/Ubuntu/Components/Popups/PopupBase.qml (+3/-1)
modules/Ubuntu/Components/TextArea.qml (+2/-0)
modules/Ubuntu/Components/TextCursor.qml (+135/-99)
modules/Ubuntu/Components/TextField.qml (+7/-0)
modules/Ubuntu/Components/TextInputPopover.qml (+20/-5)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+2/-1)
modules/Ubuntu/Components/plugin/ucmousefilters.cpp (+1/-0)
tests/autopilot/ubuntuuitoolkit/base.py (+16/-0)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.py (+94/-12)
tests/unit_x11/tst_components/tst_textinput_common.qml (+1/-33)
tests/unit_x11/tst_components/tst_textinput_touch.qml (+1/-2)
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu SDK team: Pending requested
-
Diff: 720 lines (+286/-155)12 files modifiedmodules/Ubuntu/Components/InputHandler.qml (+4/-2)
modules/Ubuntu/Components/Popups/PopupBase.qml (+3/-1)
modules/Ubuntu/Components/TextArea.qml (+2/-0)
modules/Ubuntu/Components/TextCursor.qml (+135/-99)
modules/Ubuntu/Components/TextField.qml (+7/-0)
modules/Ubuntu/Components/TextInputPopover.qml (+20/-5)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+2/-1)
modules/Ubuntu/Components/plugin/ucmousefilters.cpp (+1/-0)
tests/autopilot/ubuntuuitoolkit/base.py (+16/-0)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.py (+94/-12)
tests/unit_x11/tst_components/tst_textinput_common.qml (+1/-33)
tests/unit_x11/tst_components/tst_textinput_touch.qml (+1/-2)
- Cris Dywan (community): Needs Fixing
- Tim Peeters: Pending requested
- Zsombor Egri: Pending requested
- Zoltan Balogh: Pending requested
-
Diff: 779 lines (+310/-183)12 files modifiedmodules/Ubuntu/Components/InputHandler.qml (+4/-2)
modules/Ubuntu/Components/Popups/PopupBase.qml (+3/-1)
modules/Ubuntu/Components/TextArea.qml (+2/-0)
modules/Ubuntu/Components/TextCursor.qml (+135/-99)
modules/Ubuntu/Components/TextField.qml (+30/-28)
modules/Ubuntu/Components/TextInputPopover.qml (+20/-5)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+2/-1)
modules/Ubuntu/Components/plugin/ucmousefilters.cpp (+1/-0)
tests/autopilot/ubuntuuitoolkit/base.py (+16/-0)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.py (+95/-12)
tests/unit_x11/tst_components/tst_textinput_common.qml (+1/-33)
tests/unit_x11/tst_components/tst_textinput_touch.qml (+1/-2)
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu SDK team: Pending requested
-
Diff: 485 lines (+160/-108) (has conflicts)10 files modifiedmodules/Ubuntu/Components/InputHandler.qml (+6/-2)
modules/Ubuntu/Components/Popups/Popover.qml (+4/-0)
modules/Ubuntu/Components/Popups/PopupBase.qml (+3/-1)
modules/Ubuntu/Components/TextArea.qml (+2/-0)
modules/Ubuntu/Components/TextCursor.qml (+120/-99)
modules/Ubuntu/Components/TextField.qml (+2/-0)
modules/Ubuntu/Components/TextInputPopover.qml (+14/-3)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+0/-3)
modules/Ubuntu/Components/plugin/ucmousefilters.cpp (+1/-0)
push_to_phone.sh (+8/-0)
| Changed in ubuntu-ui-toolkit: | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| tags: | added: copy-paste |
| Changed in ubuntu-ui-toolkit: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Florian Boucault (fboucault) |
| milestone: | none → 11.07 |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| assignee: | nobody → Florian Boucault (fboucault) |
| importance: | Undecided → High |
| status: | New → In Progress |
| no longer affects: | ubuntu-ui-toolkit |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
