Button text color doesn't offer great contrast, and looks disabled when it's not
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UX |
Fix Committed
|
Undecided
|
Unassigned | ||
ubuntu-ui-toolkit (Ubuntu) |
Triaged
|
High
|
Zsombor Egri | ||
unity8 (Ubuntu) |
Invalid
|
Undecided
|
Unassigned |
Bug Description
I'll attach some pictures to show what I mean.
We have a visual design for the welcome wizard when you first turn on the device (see attached design.jpg). It shows a combo box that is hard to achieve with the current toolkit.
(As an aside, there is no joiner between the drop down button and the rest of the widget in design.jpg. I don't know how to do that with the current SDK... But that's not the point of this bug.)
My real problem is text color. By default, I get a kind of grey background color and light text. It's not the easiest to see. And this is the default! See default.png
When I set a white background to get closer to the visual design, I still get a light text. Which is also hard to see. See white.png
I seem to have no control over the color of the text. In ButtonStyle.qml, I see:
textColor: ColorUtils.
Which does not provide much control nor the possibility for a particularly dark text color.
Related branches
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Pierre Bertet (community): Approve
- Zsombor Egri: Approve
- Timo Jyrinki: Approve (trigger ci, not real review)
-
Diff: 542 lines (+242/-86)4 files modifiedcomponents.api (+6/-1)
examples/ubuntu-ui-toolkit-gallery/Buttons.qml (+14/-10)
src/Ubuntu/Components/1.3/ComboButton.qml (+60/-11)
src/Ubuntu/Components/Themes/Ambiance/1.3/ComboButtonStyle.qml (+162/-64)
- ubuntu-sdk-build-bot: Needs Fixing (continuous-integration)
- Zsombor Egri: Pending requested
-
Diff: 1810 lines (+1027/-392)22 files modifiedcomponents.api (+16/-3)
examples/ubuntu-ui-toolkit-gallery/Buttons.qml (+116/-55)
src/Ubuntu/Components/1.3/Button.qml (+0/-125)
src/Ubuntu/Components/ComponentModule.pro (+0/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/ButtonForeground.qml (+29/-52)
src/Ubuntu/Components/Themes/Ambiance/1.3/ButtonStyle.qml (+135/-132)
src/Ubuntu/Components/Themes/Ambiance/1.3/Palette.qml (+24/-12)
src/Ubuntu/Components/Themes/Ambiance/1.3/TextButtonStyle.qml (+76/-0)
src/Ubuntu/Components/Themes/Ambiance/Ambiance.pro (+1/-0)
src/Ubuntu/Components/Themes/Ambiance/qmldir (+1/-0)
src/Ubuntu/Components/plugin/button.cpp (+268/-0)
src/Ubuntu/Components/plugin/button.h (+84/-0)
src/Ubuntu/Components/plugin/button_p.h (+46/-0)
src/Ubuntu/Components/plugin/plugin.cpp (+4/-0)
src/Ubuntu/Components/plugin/plugin.pri (+7/-7)
src/Ubuntu/Components/plugin/textbutton.cpp (+134/-0)
src/Ubuntu/Components/plugin/textbutton.h (+51/-0)
src/Ubuntu/Components/plugin/ucabstractbutton.cpp (+1/-1)
src/Ubuntu/Components/plugin/ucabstractbutton.h (+1/-1)
src/Ubuntu/Components/qmldir (+0/-1)
tests/unit/tst_performance/ButtonGrid13.qml (+30/-0)
tests/unit/tst_performance/tst_performance.cpp (+3/-2)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Zsombor Egri (zsombi) |
importance: | Undecided → High |
status: | New → Triaged |
no longer affects: | ubuntu-ui-toolkit |
summary: |
- Button text color doesn't offer great contrast + Button text color doesn't offer great contrast, and looks disabled when + it's not |
tags: | added: visual-quality |
We must agree on the palette to be used, then we can drive the colors of the buttons properly. There is no reason to fix colours here'n'there because that will lead to inconsistency and pour configurability.