UbuntuColors considered harmful
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
webapps-sprint |
Fix Released
|
Medium
|
Alberto Mardegan | ||
dialer-app (Ubuntu) |
In Progress
|
Undecided
|
Unassigned | ||
reminders-app (Ubuntu) |
Fix Committed
|
Undecided
|
Unassigned | ||
trust-store (Ubuntu) |
In Progress
|
Undecided
|
Unassigned | ||
ubuntu-system-settings (Ubuntu) |
Fix Released
|
Undecided
|
Michael Terry | ||
ubuntu-system-settings-online-accounts (Ubuntu) |
Fix Released
|
Medium
|
Alberto Mardegan | ||
unity8 (Ubuntu) |
Fix Released
|
Undecided
|
Michael Terry | ||
webbrowser-app (Ubuntu) |
Fix Released
|
Undecided
|
Michael Terry |
Bug Description
After the latest theme changes (that introduced blue and green to our palette), there are incorrect colors in ubuntu-
Partly because of hardcoded colors via UbuntuColors. Ideally, semantic color names from the palette would be used instead. "theme.
A simple grep should give lots of locations that could be corrected.
In addition, it seems that UbuntuColors.orange is used in several places that aren't focus related. Like for buttons. Those might want to switch to green via theme.palette.
https:/
And if you're curious what the semantic colors actually resolve to, you can see the current mapping between UbuntuColors and the theme by looking at /usr/lib/
Related branches
- Unity8 CI Bot: Pending (continuous-integration) requested
- Andrea Cimitan: Pending requested
-
Diff: 211 lines (+17/-17)15 files modifiedplugins/Dash/AudioProgressBar.qml (+1/-1)
plugins/Dash/ScopeStyle.qml (+1/-1)
qml/Components/Dialogs.qml (+2/-2)
qml/Components/ModeSwitchWarningDialog.qml (+1/-1)
qml/Components/WindowControlButtons.qml (+1/-1)
qml/Dash/DashPageHeader.qml (+1/-1)
qml/Dash/Previews/PreviewActions.qml (+1/-1)
qml/Dash/Previews/PreviewPayments.qml (+1/-1)
qml/Launcher/LauncherDelegate.qml (+2/-2)
qml/Panel/Panel.qml (+1/-1)
qml/Stages/DecoratedWindow.qml (+1/-1)
qml/Stages/DesktopSpread.qml (+1/-1)
qml/Stages/DesktopSpreadDelegate.qml (+1/-1)
qml/Stages/SpreadDelegate.qml (+1/-1)
tests/plugins/Dash/tst_ScopeStyle.qml (+1/-1)
- Ken VanDine: Approve
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 209 lines (+13/-23)9 files modifiedplugins/background/Components/AddRemove.qml (+0/-2)
plugins/background/Components/HighlightedOverlay.qml (+1/-1)
plugins/cellular/Components/LabelTextField.qml (+1/-1)
plugins/cellular/PageChooseApn.qml (+1/-1)
plugins/phone/CallForwardItem.qml (+2/-6)
plugins/phone/CallForwarding.qml (+1/-1)
plugins/security-privacy/LockSecurity.qml (+1/-2)
plugins/security-privacy/SimPin.qml (+3/-5)
plugins/system-update/PageComponent.qml (+3/-4)
- PS Jenkins bot: Pending (continuous-integration) requested
- Ubuntu Phablet Team: Pending requested
-
Diff: 26 lines (+2/-3)1 file modifiedsrc/core/trust/mir/prompt_main.qml (+2/-3)
- system-apps-ci-bot: Approve (continuous-integration)
- Olivier Tilloy: Approve
-
Diff: 468 lines (+42/-44)22 files modifiedsrc/app/AlertDialog.qml (+2/-1)
src/app/AuthenticationDialog.qml (+2/-3)
src/app/BeforeUnloadDialog.qml (+2/-1)
src/app/CertificateVerificationDialog.qml (+3/-3)
src/app/ConfirmDialog.qml (+2/-1)
src/app/GeolocationPermissionRequest.qml (+2/-3)
src/app/HttpAuthenticationDialog.qml (+2/-3)
src/app/InvalidCertificateErrorSheet.qml (+2/-2)
src/app/MediaAccessDialog.qml (+1/-2)
src/app/PromptDialog.qml (+2/-3)
src/app/webbrowser/BookmarkOptions.qml (+2/-2)
src/app/webbrowser/BookmarksFoldersViewWide.qml (+2/-2)
src/app/webbrowser/DownloadDelegate.qml (+2/-2)
src/app/webbrowser/HistorySectionDelegate.qml (+2/-2)
src/app/webbrowser/HistoryViewWide.qml (+1/-1)
src/app/webbrowser/IndeterminateProgressBar.qml (+2/-2)
src/app/webbrowser/LeavePrivateModeDialog.qml (+2/-2)
src/app/webbrowser/SadTab.qml (+2/-2)
src/app/webbrowser/SettingsPage.qml (+1/-1)
src/app/webbrowser/UrlDelegate.qml (+2/-2)
src/app/webbrowser/UrlDelegateWide.qml (+2/-2)
src/app/webcontainer/SadPage.qml (+2/-2)
- PS Jenkins bot: Pending (continuous-integration) requested
- Online Accounts: Pending requested
-
Diff: 12 lines (+1/-1)1 file modifiedonline-accounts-ui/qml/AuthorizationPage.qml (+1/-1)
- Jenkins Bot: Approve (continuous-integration)
- Alan Pope 🍺🐧🐱 🦄 (community): Approve
-
Diff: 327 lines (+25/-34)16 files modifiedsrc/app/qml/Reminders.qml (+3/-5)
src/app/qml/components/BouncingProgressBar.qml (+1/-1)
src/app/qml/components/EditTagsDialog.qml (+4/-6)
src/app/qml/components/ListItemWithActions.qml (+5/-6)
src/app/qml/components/NoteHeader.qml (+1/-1)
src/app/qml/components/NotebooksDelegate.qml (+0/-1)
src/app/qml/components/NotesDelegate.qml (+0/-1)
src/app/qml/components/PageWithBottomEdge.qml (+2/-2)
src/app/qml/components/RemindersDelegate.qml (+0/-1)
src/app/qml/components/ResolveConflictConfirmationDialog.qml (+2/-2)
src/app/qml/components/RtfButton.qml (+1/-1)
src/app/qml/components/TagsDelegate.qml (+0/-1)
src/app/qml/ui/AccountSelectorPage.qml (+1/-1)
src/app/qml/ui/EditNoteView.qml (+1/-1)
src/app/qml/ui/NoteView.qml (+2/-2)
src/app/qml/ui/SetReminderView.qml (+2/-2)
- PS Jenkins bot: Pending (continuous-integration) requested
- Ubuntu Phablet Team: Pending requested
-
Diff: 378 lines (+31/-38)17 files modifiedsrc/qml/DialerPage/CallButton.qml (+2/-2)
src/qml/DialerPage/CustomButton.qml (+1/-1)
src/qml/DialerPage/DialerPage.qml (+2/-2)
src/qml/DialerPage/KeypadButton.qml (+2/-2)
src/qml/DialerPage/KeypadEntry.qml (+3/-3)
src/qml/Dialogs/DisableFlightModeDialog.qml (+1/-2)
src/qml/Dialogs/NoDefaultSIMCardDialog.qml (+1/-3)
src/qml/Dialogs/NotificationDialog.qml (+0/-1)
src/qml/Dialogs/SetDefaultSIMCardDialog.qml (+1/-2)
src/qml/Dialogs/SimLockedDialog.qml (+3/-3)
src/qml/HistoryPage/HistoryDelegate.qml (+1/-1)
src/qml/HistoryPage/HistoryDetailsPage.qml (+2/-2)
src/qml/HistoryPage/SwipeItemDemo.qml (+2/-2)
src/qml/LiveCallPage/ConferenceCallDisplay.qml (+3/-3)
src/qml/LiveCallPage/HangupButton.qml (+2/-4)
src/qml/LiveCallPage/LiveCall.qml (+4/-4)
src/qml/LiveCallPage/MultiCallDisplay.qml (+1/-1)
description: | updated |
Changed in unity8 (Ubuntu): | |
assignee: | nobody → Michael Terry (mterry) |
Changed in ubuntu-system-settings-online-accounts (Ubuntu): | |
assignee: | nobody → Alberto Mardegan (mardy) |
importance: | Undecided → Medium |
status: | New → Confirmed |
Changed in trust-store (Ubuntu): | |
assignee: | nobody → Michael Terry (mterry) |
status: | New → In Progress |
Changed in unity8 (Ubuntu): | |
status: | New → In Progress |
Changed in ubuntu-system-settings (Ubuntu): | |
assignee: | nobody → Michael Terry (mterry) |
status: | New → In Progress |
Changed in webbrowser-app (Ubuntu): | |
assignee: | nobody → Michael Terry (mterry) |
status: | New → In Progress |
Changed in webapps-sprint: | |
milestone: | none → sprint-23 |
assignee: | nobody → Alberto Mardegan (mardy) |
importance: | Undecided → Medium |
status: | New → In Progress |
Changed in ubuntu-system-settings-online-accounts (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in reminders-app (Ubuntu): | |
assignee: | nobody → Michael Terry (mterry) |
status: | New → In Progress |
Changed in reminders-app (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in dialer-app (Ubuntu): | |
assignee: | nobody → Michael Terry (mterry) |
status: | New → In Progress |
Changed in webapps-sprint: | |
status: | In Progress → Fix Released |
Changed in dialer-app (Ubuntu): | |
assignee: | Michael Terry (mterry) → nobody |
Changed in trust-store (Ubuntu): | |
assignee: | Michael Terry (mterry) → nobody |
Changed in reminders-app (Ubuntu): | |
assignee: | Michael Terry (mterry) → nobody |
This bug was fixed in the package unity8 - 8.12+16. 10.20160527- 0ubuntu1
--------------- 10.20160527- 0ubuntu1) yakkety; urgency=medium
unity8 (8.12+16.
[ Albert Astals Cid ] :widthChanged instead of :contentWidthCh anged (LP: #1565763)
* Activate on click for SimpleMessages (LP: #1421696)
* Add override
* Change the art back to the cardData value if it changes from broken
to valid image (LP: #1533577)
* Concierge mode generated code optimization
* Don't use context properties but properties of the delegates
* Listen to contentItem:
Flickable:
* Make some AP code faster
* Make tests a bit more stable
* Make unity8 and unity8-dash handle termination signals
* Remove workaround not needed anymore (LP: #1475643)
* Resolve cardArtStyle on compile time
* Set the theme earlier (LP: #1574048)
[ Albert Astals Cid, Daniel d'Andrada ]
* Remove DirectionalDragArea and libs/UbuntuGestures and port to SDK
equivalents
[ Andrea Cimitan ]
* Hide the preview review input field when a rating is required (LP:
#1541971)
[ CI Train Bot ]
* Resync trunk.
[ Daniel d'Andrada ]
* Fix DragHandle so it works in all directions
* Support animated cursors
* WindowInputMonitor - also map Qt::Key_HomePage to our home key
* plugins/Cursor: properly register to the screen's QPlatformCursor
when screen changes (LP: #1579742)
[ Josh Arenson ] Panel when a filter option is selected (LP:
* Close the PageHeaderExtra
#1569498)
* Wrap primaryFilter in a flickable to make it behave nicely. (LP:
#1569492)
[ Lukáš Tinkl ] vertically
* First snap decision should always be expanded, unless user decides
otherwise (LP: #1580090, #1575045)
* Fullscreen notification bug fixes (LP: #1583944, #1581498, #1422711)
* Implement maximizing windows horizontally/
* Lock the session when putting the laptop into sleep (LP: #1581063)
[ Lukáš Tinkl, Michael Terry ]
* With a maximized window, "dragging" the panel down should restore it
[ Michael Terry ]
* Change some dash button colors from orange to green. (LP: #1581047)
* Use PageHeader instead Ambiance's PageHeadStyle
* Use new setTimeZone method to set user-friendly timezone name in the
wizard. (LP: #1566295)
[ Michael Zanetti ]
* Remove the background dimming when the launcher is revealed by a
drag (LP: #1575137)
* reenable or drop disabled tests
-- Michael Terry <email address hidden> Fri, 27 May 2016 13:54:44 +0000