Ubuntu
ubuntu-system-settings package

Location settings inconsistent between first-run setup + System Settings

Bug #1467790 reported by Matthew Paul Thomas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UX
In Progress
Undecided
Matthew Paul Thomas
ubuntu-system-settings (Ubuntu)
New
Low
Unassigned
unity8 (Ubuntu)
Fix Released
Low
Lukáš Tinkl

Bug Description

Ubuntu 15.04 r35

1. Go through the first-run setup, paying particular attention to the "Location" step.
2. In System Settings, open "Security & Privacy" > "Location access".

What you see:
1. The options are presented using checkboxes.
2. Exactly the same options are presented using an ItemSelector.

What you should see: The options are presented in exactly the same way, except for their color scheme, on both screens. Any design changes always show up on both screens.

This bug occurs because the screens are implemented separately:
<http://bazaar.launchpad.net/~unity-team/unity8/trunk/view/head:/qml/Wizard/Pages/50-location.qml#L58>
<http://bazaar.launchpad.net/~system-settings-touch/ubuntu-system-settings/trunk/view/head:/plugins/security-privacy/Location.qml#L93>
Even if the implementations were synced, it is almost inevitable that sometime later, designers and/or engineers would forget to update one when updating the other.

It may save time to fix bug 1388178 at the same time as this bug.

The equivalent for Wi-Fi settings is bug 1467438.

Related branches

lp://staging/~unity-team/unity8/oobe
Michael Zanetti (community): Approve
Unity8 CI Bot: Needs Fixing (continuous-integration)
Nick Dedekind (community): Needs Fixing
PS Jenkins bot: Pending (continuous-integration) requested
Michael Terry: Pending requested
Diff: 5685 lines (+3285/-1000)
61 files modified
CMakeLists.txt (+1/-0)
debian/control (+2/-1)
plugins/AccountsService/AccountsService.cpp (+27/-3)
plugins/AccountsService/AccountsService.h (+9/-3)
plugins/Utils/timezoneFormatter.cpp (+10/-0)
plugins/Utils/timezoneFormatter.h (+1/-0)
plugins/Wizard/CMakeLists.txt (+7/-1)
plugins/Wizard/LocalePlugin.cpp (+291/-0)
plugins/Wizard/LocalePlugin.h (+58/-0)
plugins/Wizard/PageList.cpp (+4/-4)
plugins/Wizard/Status.cpp (+143/-0)
plugins/Wizard/Status.h (+60/-0)
plugins/Wizard/System.cpp (+5/-4)
plugins/Wizard/System.h (+3/-2)
plugins/Wizard/plugin.cpp (+7/-8)
plugins/Wizard/plugin.h (+1/-2)
plugins/Wizard/timezonemodel.cpp (+244/-0)
plugins/Wizard/timezonemodel.h (+80/-0)
qml/Shell.qml (+0/-1)
qml/Wizard/CheckableSetting.qml (+11/-3)
qml/Wizard/Page.qml (+275/-58)
qml/Wizard/Pages.qml (+76/-32)
qml/Wizard/Pages/10-welcome.qml (+129/-56)
qml/Wizard/Pages/30-wifi.qml (+119/-128)
qml/Wizard/Pages/40-location.qml (+216/-76)
qml/Wizard/Pages/50-timezone.qml (+275/-0)
qml/Wizard/Pages/60-account.qml (+74/-0)
qml/Wizard/Pages/60-reporting.qml (+0/-64)
qml/Wizard/Pages/70-passwd-type.qml (+105/-79)
qml/Wizard/Pages/75-report-check.qml (+91/-0)
qml/Wizard/Pages/80-finished.qml (+106/-28)
qml/Wizard/Pages/here-terms.qml (+79/-74)
qml/Wizard/Pages/passcode-confirm.qml (+14/-31)
qml/Wizard/Pages/passcode-desktop.qml (+132/-0)
qml/Wizard/Pages/passcode-set.qml (+13/-29)
qml/Wizard/Pages/password-set.qml (+149/-0)
qml/Wizard/Pages/sim.qml (+71/-40)
qml/Wizard/PasswordMeter.qml (+106/-0)
qml/Wizard/StackButton.qml (+7/-12)
qml/Wizard/Wizard.qml (+0/-9)
qml/Wizard/WizardTextField.qml (+25/-0)
tests/mocks/AccountsService/AccountsService.cpp (+23/-3)
tests/mocks/AccountsService/AccountsService.h (+12/-5)
tests/mocks/MeeGo/QOfono/MockOfonoSimManager.qml (+1/-0)
tests/mocks/Ubuntu/Connectivity/plugin.cpp (+1/-0)
tests/mocks/Ubuntu/SystemSettings/CMakeLists.txt (+2/-0)
tests/mocks/Ubuntu/SystemSettings/Diagnostics/CMakeLists.txt (+1/-0)
tests/mocks/Ubuntu/SystemSettings/Diagnostics/MockDiagnostics.qml (+24/-0)
tests/mocks/Ubuntu/SystemSettings/Diagnostics/qmldir (+2/-0)
tests/mocks/Ubuntu/SystemSettings/LanguagePlugin/MockLanguagePlugin.qml (+2/-2)
tests/mocks/Ubuntu/SystemSettings/SecurityPrivacy/MockSecurityPrivacy.cpp (+1/-1)
tests/mocks/Ubuntu/SystemSettings/TimeDate/CMakeLists.txt (+1/-0)
tests/mocks/Ubuntu/SystemSettings/TimeDate/MockTimeDate.qml (+25/-0)
tests/mocks/Ubuntu/SystemSettings/TimeDate/qmldir (+2/-0)
tests/mocks/Utils/CMakeLists.txt (+1/-1)
tests/mocks/Utils/plugin.cpp (+3/-0)
tests/mocks/Wizard/CMakeLists.txt (+6/-1)
tests/mocks/Wizard/MockSystem.cpp (+4/-2)
tests/mocks/Wizard/MockSystem.h (+2/-2)
tests/mocks/Wizard/mockplugin.cpp (+7/-8)
tests/qmltests/Wizard/tst_Wizard.qml (+139/-227)
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, but currently the designs are inconsistent and the screen reflect those, can we get design recommendation on how those screen should look like?

Changed in ubuntu-system-settings (Ubuntu):
status: New → Incomplete
Changed in unity8 (Ubuntu):
status: New → Incomplete
Changed in ubuntu-system-settings (Ubuntu):
importance: Undecided → Low
Changed in unity8 (Ubuntu):
importance: Undecided → Low
Revision history for this message
Sebastien Bacher (seb128) wrote :

changing the settings/unity8 to incomplete, without design guidance there is not much we can implement

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

I have discussed this with the interaction designer for the setup (Andreea), the visual designer for the setup (Grazina), and a visual designer for System Settings (Olivia), and we all agreed that the designs should be the same.

Currently the setup design spec (a) is not public, (b) doesn't have a separate "Location" step at all, and (c) is over a year out of date, because it was written by a designer who stopped working on Ubuntu about March 2014. <https://goo.gl/NPCEit> Its only revision so far this year is a comment, from me before I realized that last point, asking why the location setting was presented differently from System Settings! A new setup design spec is being written, but it will take a while -- it is trying to cover both phone setup and PC installation, and PC installation is highly complex.

Waiting for that is not necessary nor even useful for fixing this bug. The "Location access" step of the setup is already not following any design spec that I'm aware of (b), so you can't even complain that fixing the bug would introduce divergence between the code and the design.

Changed in ubuntu-ux:
status: New → Fix Committed
Changed in ubuntu-system-settings (Ubuntu):
status: Incomplete → New
Changed in unity8 (Ubuntu):
status: Incomplete → New
Revision history for this message
Grazina (boroskograzina) wrote :

--- Design Comment ---
     11/08/2015

Please see designs attached.

description: updated
Revision history for this message
Grazina (boroskograzina) wrote :
Lukáš Tinkl (lukas-kde)
Changed in unity8 (Ubuntu):
assignee: nobody → Lukáš Tinkl (lukas-kde)
status: New → In Progress
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Those attached designs are for Wi-Fi settings. This bug report is about location settings.

description: updated
Changed in ubuntu-ux:
status: Fix Committed → In Progress
assignee: nobody → Matthew Paul Thomas (mpt)
Lukáš Tinkl (lukas-kde)
Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.