battery indicator and brightness settings should have brightness slider; battery settings shouldn't
Bug #1289470 reported by
Matthew Paul Thomas
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
indicator-power (Ubuntu) |
Fix Released
|
High
|
Charles Kerr | ||
ubuntu-system-settings (Ubuntu) |
Fix Released
|
Medium
|
Ken VanDine |
Bug Description
The current phone design has three brightness sliders that do exactly the same thing:
* System Settings > "Brightness"
* System Settings > "Battery"
* the Battery menu.
This is kind of ridiculous. We should get rid of one or two.
<https:/
<https:/
Related branches
lp://staging/~laney/indicator-power/phone-no-slider
- Charles Kerr (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 87 lines (+11/-26)3 files modifieddebian/control (+1/-1)
debian/rules (+9/-0)
src/service.c (+1/-25)
lp://staging/~ken-vandine/ubuntu-system-settings/brightness_slider
- PS Jenkins bot: Approve (continuous-integration)
- Sebastien Bacher (community): Approve
-
Diff: 176 lines (+38/-105)3 files modifiedplugins/brightness/BrightnessSlider.qml (+0/-103)
plugins/brightness/CMakeLists.txt (+0/-1)
plugins/brightness/PageComponent.qml (+38/-1)
lp://staging/~charlesk/indicator-power/lp-1289470-restore-brightness-slider
- Ted Gould (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 1499 lines (+763/-561)9 files modifiedsrc/CMakeLists.txt (+1/-2)
src/brightness.c (+509/-0)
src/brightness.h (+67/-0)
src/ib-brightness-control.c (+0/-156)
src/ib-brightness-control.h (+0/-33)
src/ib-brightness-uscreen-control.c (+0/-202)
src/ib-brightness-uscreen-control.h (+0/-43)
src/service.c (+109/-96)
tests/manual (+77/-29)
Changed in indicator-power (Ubuntu): | |
assignee: | nobody → Matthew Paul Thomas (mpt) |
Changed in ubuntu-system-settings (Ubuntu): | |
assignee: | nobody → Matthew Paul Thomas (mpt) |
Changed in indicator-power (Ubuntu): | |
assignee: | nobody → Iain Lane (laney) |
Changed in ubuntu-system-settings (Ubuntu): | |
assignee: | Jonas G. Drange (jonas-drange) → Ken VanDine (ken-vandine) |
Changed in indicator-power (Ubuntu): | |
status: | Triaged → In Progress |
tags: | added: touch-2014-09-25 |
To post a comment you must log in.
Specification updated. <https:/ /wiki.ubuntu. com/Power# Phone_and_ tablet> As agreed with Shruti Kapur, the battery menu should no longer contain a brightness slider.
It's possible that a brightness slider may return in a future indicator design, and in that case we'd have to tackle the System Settings side.