Ubuntu
ubuntu-release-upgrader package

dist upgrade crash tracebacks include a tmpdir name

Bug #1289580 reported by Brian Murray on 2014-03-07

This bug affects 1 person

	Status	Importance	Assigned to
ubuntu-release-upgrader (Ubuntu)	Fix Released	High	Brian Murray
Precise	Invalid	Undecided	Unassigned
Saucy	Fix Released	High	Brian Murray
update-manager (Ubuntu)	Invalid	Undecided	Unassigned
Precise	Fix Released	High	Brian Murray
Saucy	Invalid	Undecided	Unassigned

Bug Description

N.B. Before testing this bug ensure that python-apport is installed on Saucy. See bug 1289604 for details.

Test Case:
1) run do-release-upgrade -d
2) cancel the upgrade
3) cd to /tmp/ubuntu-release-upgrader-XYZ/
4) edit DistUpgrade/DistUpgradeController.py and put a division by zero error in the function askDistUpgrade (this is to make the release upgrader crash)
5) sudo ./trusty --frontend=DistUpgradeViewGtk3
6) Observe a system crash dialog and choose to report it
7) Choose to view details of the crash report
8) Observe a traceback with /tmp/ubuntu-release-upgrader-XYZ/ in it
9) Do not submit the crash report

With the packae from proprosed you'll see a DuplicateSignature field with XYZ replaced with tmpdir so /tmp/ubuntu-release-upgrader-tmpdir/

Tracebacks from crashes in the release upgrader include a temporary directory name like so:

Traceback (most recent call last):
  File "/tmp/ubuntu-release-upgrader-5gz_r8/trusty", line 10, in <module>
    sys.exit(main())
  File "/tmp/ubuntu-release-upgrader-5gz_r8/DistUpgrade/DistUpgradeMain.py", line 243, in main
    if app.run():

Because the temporary directory name changes between systems and upgrade attempts duplicates are not often consolidated in the error tracker or in Launchpad. Subsequently, it is difficult to judge the number of people affected by any particular crash in the release upgrade process.

This should be fixed in the apport package hook for update-manager in Precise and ubuntu-release-upgrader in Saucy.

See original description

Tags:

Related branches

lp://staging/ubuntu/saucy-proposed/ubuntu-release-upgrader

lp://staging/ubuntu/precise-proposed/update-manager

Brian Murray (brian-murray) on 2014-03-07

Changed in update-manager (Ubuntu Saucy):
status:	New → Won't Fix
Changed in update-manager (Ubuntu Precise):
status:	New → Triaged
importance:	Undecided → High
Changed in ubuntu-release-upgrader (Ubuntu Saucy):
status:	New → Triaged
importance:	Undecided → High
Changed in ubuntu-release-upgrader (Ubuntu):
status:	New → Triaged
importance:	Undecided → High
Changed in ubuntu-release-upgrader (Ubuntu Precise):
status:	New → Won't Fix
status:	Won't Fix → Invalid
Changed in update-manager (Ubuntu Saucy):
status:	Won't Fix → Invalid
Changed in ubuntu-release-upgrader (Ubuntu):
status:	Triaged → In Progress
assignee:	nobody → Brian Murray (brian-murray)

Brian Murray (brian-murray) on 2014-03-07

description:

updated

Brian Murray (brian-murray) on 2014-03-07

description:

updated

Revision history for this message

Brian Murray (brian-murray) wrote on 2014-03-07:

I typo'ed the bug number in the trusty changelog.

ubuntu-release-upgrader (1:0.215) trusty; urgency=medium

  * do-release-upgrade: indicate that -p and -d switches are mutually
    exclusive (LP: #1071025)
  * debian/control.py: depend on python-apport since DistUpgradeApport.py
    imports it and the release upgrader does not use python3 (LP: #1289604)
  * debian/source_ubuntu-release-upgrader.py: create a DuplicateSignature by
    stripping out the tmpdir from the Traceback (LP: #1289850)
-- Brian Murray <email address hidden> Fri, 07 Mar 2014 14:29:14 -0800

Changed in ubuntu-release-upgrader (Ubuntu):
status:	In Progress → Fix Released
Changed in update-manager (Ubuntu):
status:	New → Invalid

Revision history for this message

Steve Langasek (vorlon) wrote on 2014-03-08: Please test proposed package

Hello Brian, or anyone else affected,

Accepted ubuntu-release-upgrader into saucy-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:0.205.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in ubuntu-release-upgrader (Ubuntu Saucy):
status:	Triaged → Fix Committed
tags:	added: verification-needed

Brian Murray (brian-murray) on 2014-03-08

Changed in ubuntu-release-upgrader (Ubuntu Saucy):
status:	Fix Committed → In Progress
assignee:	nobody → Brian Murray (brian-murray)

Revision history for this message

Brian Murray (brian-murray) wrote on 2014-03-10:

I installed ubuntu-release-upgrader version 0.205.5 from saucy-proposed and confirm that a DuplicateSignature was created in the apport crash file and that the temporary directory name that appears in the Traceback does not appear in the DuplicateSignature.

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-03-10:

This bug was fixed in the package ubuntu-release-upgrader - 1:0.205.5

---------------
ubuntu-release-upgrader (1:0.205.5) saucy-proposed; urgency=medium

  * debian/source_ubuntu-release-upgrader.py: create a DuplicateSignature by
    stripping out the tmpdir from the Traceback (LP: #1289580)
  * debian/control.py: depend on python-apport since DistUpgradeApport.py
    imports it and the release upgrader does not use python3 (LP: #1289604)
-- Brian Murray <email address hidden> Fri, 07 Mar 2014 15:26:12 -0800

Changed in ubuntu-release-upgrader (Ubuntu Saucy):
status:	In Progress → Fix Released

Revision history for this message

Adam Conrad (adconrad) wrote on 2014-03-10: Update Released

The verification of the Stable Release Update for ubuntu-release-upgrader has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message

Adam Conrad (adconrad) wrote on 2014-03-10: Please test proposed package

Hello Brian, or anyone else affected,

Accepted update-manager into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/update-manager/1:0.156.14.12 in a few hours, and then in the -proposed repository.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in update-manager (Ubuntu Precise):
status:	Triaged → Fix Committed
tags:	removed: verification-done
tags:	added: verification-needed

Revision history for this message

Brian Murray (brian-murray) wrote on 2014-03-10:

I installed update-manager version 0.156.14.12 and followed the test case and confirm that a DuplicateSignature was created in the .crash file and that it had the temporary directory name replaced with update-manager-tmpdir.

tags:	added: verification-done removed: verification-needed
Changed in update-manager (Ubuntu Precise):
assignee:	nobody → Brian Murray (brian-murray)

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-03-17:

This bug was fixed in the package update-manager - 1:0.156.14.12

---------------
update-manager (1:0.156.14.12) precise-proposed; urgency=medium

* debian/source_update-manager.py: create a DuplicateSignature by
replacing the tmpdir name in the Traceback (LP: #1289580)
-- Brian Murray <email address hidden> Mon, 10 Mar 2014 10:40:57 -0700

Changed in update-manager (Ubuntu Precise):
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.

Ubuntuubuntu-release-upgrader package

dist upgrade crash tracebacks include a tmpdir name

Bug Description

Related branches

Other bug subscribers

Remote bug watches

Ubuntu
ubuntu-release-upgrader package