Ubuntu
ubuntu-release-upgrader package

diff window is too small on upgrade

Bug #1065806 reported by Roger Binns
28
This bug affects 4 people
Affects Status Importance Assigned to Milestone
ubuntu-release-upgrader (Ubuntu)
Fix Released
High
Michael Terry
Ubuntu quantal-updates
Quantal
Fix Released
High
Michael Terry
Ubuntu quantal-updates

Bug Description

= Impact =

When upgrading from precise to quantal if you receive a dialog about a customized configuration file the window that displays the differences only shows 2 lines so you need to scroll in it to see the differences and the window is not resizable which makes it quite hard to review the changes.

= Test Case =

1) Download new-test.py from this bug
2) sudo cp new-test.py /usr/lib/python3/dist-packages/
3) cd /usr/lib/python3/dist-packages
4) python3 new-test.py
5) observe a conf file prompt with a 2 line diff window when expanded which is not resizable
6) Ctrl-C in the terminal you launched python3 new-test.py
7) do not submit the crash report you receive

1) install the updated package from -proposed
2) cd /usr/lib/python3/dist-packages
3) python3 new-test.py
4) observe a conf file prompt with a multi-line diff window when expanded which is resizable

When running update-manager -d to upgrade from precise to quantal on two different machines I would be prompted to view the diffs between two files. However the window that appears is not resizeable and it only shows two lines which is completely unusable. See attached screenshot for an example

ProblemType: BugDistroRelease: Ubuntu 12.10
Package: update-manager 1:0.174.3
ProcVersionSignature: Ubuntu 3.5.0-17.28-generic 3.5.5
Uname: Linux 3.5.0-17-generic x86_64
NonfreeKernelModules: nvidia
ApportVersion: 2.6.1-0ubuntu3
Aptdaemon:

Architecture: amd64
Date: Thu Oct 11 20:33:51 2012
GsettingsChanges:
 b'com.ubuntu.update-manager' b'first-run' b'false'
 b'com.ubuntu.update-manager' b'launch-time' b'1349900623'
 b'com.ubuntu.update-manager' b'show-details' b'true'
 b'com.ubuntu.update-manager' b'window-height' b'922'
 b'com.ubuntu.update-manager' b'window-width' b'964'
PackageArchitecture: allSourcePackage: update-manager
UpgradeStatus: Upgraded to quantal on 2012-10-12 (0 days ago)

See original description
Revision history for this message
Roger Binns (ubuntu-rogerbinns) wrote :
Brian Murray (brian-murray)
Changed in update-manager (Ubuntu):
status: New → Triaged
importance: Undecided → High
Brian Murray (brian-murray)
Changed in update-manager (Ubuntu Quantal):
milestone: none → quantal-updates
Michael Terry (mterry)
Changed in update-manager (Ubuntu Quantal):
assignee: nobody → Michael Terry (mterry)
Revision history for this message
Michael Terry (mterry) wrote :

Here's a little script to test the dialog. Run it from the toplevel checkout directory:
python3 test.py

Changed in update-manager (Ubuntu Quantal):
status: Triaged → In Progress
affects: update-manager (Ubuntu Quantal) → ubuntu-release-upgrader (Ubuntu Quantal)
Revision history for this message
Brian Murray (brian-murray) wrote :

I modified the test so it can be ran without having a bzr branch of ubuntu-release-upgrader.

description: updated
Brian Murray (brian-murray)
description: updated
Revision history for this message
Adam Conrad (adconrad) wrote : Please test proposed package

Hello Roger, or anyone else affected,

Accepted ubuntu-release-upgrader into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:0.190.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Changed in ubuntu-release-upgrader (Ubuntu Quantal):
status: In Progress → Fix Committed
Revision history for this message
Adam Conrad (adconrad) wrote :

Hello Roger, or anyone else affected,

Accepted ubuntu-release-upgrader into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:0.190.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Brian Murray (brian-murray) wrote :

Using ubuntu-release-upgrader-core version 1:0.190.3 from quantal-proposed I was able to verify that the test case now passes.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Adam Conrad (adconrad) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-release-upgrader - 1:0.190.3

---------------
ubuntu-release-upgrader (1:0.190.3) quantal-proposed; urgency=low

  * DistUpgrade.ui: allow the conf file dialog to be resizable and set it to a
    larger initial size. Thanks to Michael Terry for the fix. (LP: #1065806)
  * DistUpgradeApport.py: check to see if --tags is available before trying to
    use it (LP: #1070043)
 -- Brian Murray <email address hidden> Tue, 23 Oct 2012 10:45:58 -0700

Changed in ubuntu-release-upgrader (Ubuntu Quantal):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-release-upgrader - 1:0.191

---------------
ubuntu-release-upgrader (1:0.191) raring; urgency=low

  * support quantal->raring release upgrades
 -- Michael Vogt <email address hidden> Tue, 30 Oct 2012 09:33:50 +0100

Changed in ubuntu-release-upgrader (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.