UpdatePaused signal always returns percentage=0
Bug #1274131 reported by
Diego Sarmentero
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu system image |
Fix Released
|
High
|
Barry Warsaw | ||
ubuntu-download-manager (Ubuntu) |
New
|
Undecided
|
Unassigned |
Bug Description
When you pause the download of the system image in the client the progress bar shows 0%, this was working properly using the mock service: system-image-dbus --testing=..., but it seems not to behave properly when testing it IRL, probably the service is sending the UpdatePaused signal with an incorrect value.
Related branches
lp://staging/~barry/ubuntu-system-image/systemimage2.3
- Registry Administrators: Pending requested
-
Diff: 7348 lines (+4720/-717)50 files modifiedNEWS.rst (+36/-0)
PKG-INFO (+1/-1)
README.rst (+71/-0)
cli-manpage.rst (+33/-2)
dbus-manpage.rst (+255/-2)
debian/changelog (+52/-0)
debian/control (+2/-0)
debian/rules (+11/-25)
debian/tests/control (+6/-1)
debian/tests/dryrun (+11/-0)
debian/tests/smoketest (+4/-2)
debian/upstream/signing-key.asc (+2459/-0)
debian/watch (+1/-1)
ini-manpage.rst (+2/-2)
setup.cfg (+2/-2)
system_image.egg-info/PKG-INFO (+1/-1)
system_image.egg-info/SOURCES.txt (+2/-0)
system_image.egg-info/entry_points.txt (+1/-1)
system_image.egg-info/requires.txt (+1/-1)
systemimage/api.py (+6/-5)
systemimage/bag.py (+13/-0)
systemimage/bindings.py (+15/-10)
systemimage/config.py (+4/-3)
systemimage/dbus.py (+25/-11)
systemimage/download.py (+87/-21)
systemimage/gpg.py (+5/-5)
systemimage/helpers.py (+33/-6)
systemimage/logging.py (+18/-11)
systemimage/main.py (+104/-2)
systemimage/reboot.py (+16/-1)
systemimage/scores.py (+1/-1)
systemimage/settings.py (+11/-0)
systemimage/state.py (+16/-16)
systemimage/testing/controller.py (+10/-8)
systemimage/testing/dbus.py (+31/-62)
systemimage/testing/helpers.py (+30/-6)
systemimage/tests/data/index_25.json (+22/-0)
systemimage/tests/test_api.py (+36/-21)
systemimage/tests/test_bag.py (+19/-0)
systemimage/tests/test_channel.py (+2/-6)
systemimage/tests/test_config.py (+19/-28)
systemimage/tests/test_dbus.py (+373/-324)
systemimage/tests/test_download.py (+234/-29)
systemimage/tests/test_helpers.py (+45/-5)
systemimage/tests/test_main.py (+497/-50)
systemimage/tests/test_settings.py (+29/-2)
systemimage/tests/test_state.py (+61/-40)
systemimage/tests/test_winner.py (+3/-1)
systemimage/version.txt (+1/-1)
tox.ini (+3/-1)
Superseded
for merging
into
lp://staging/~registry/ubuntu-system-image/client
- Registry Administrators: Pending requested
-
Diff: 4058 lines (+3524/-347) (has conflicts)35 files modified.bzrignore (+0/-10)
PKG-INFO (+10/-0)
README.rst (+71/-0)
debian/archive-master.tar.xz.asc (+17/-0)
debian/changelog (+468/-0)
debian/compat (+1/-0)
debian/control (+62/-0)
debian/copyright (+35/-0)
debian/rules (+64/-0)
debian/source/format (+1/-0)
debian/source/include-binaries (+1/-0)
debian/system-image-common.dirs (+2/-0)
debian/system-image-common.manpages (+3/-0)
debian/system-image-common.postinst (+23/-0)
debian/system-image-common.postrm (+18/-0)
debian/tests/client.ini.in (+34/-0)
debian/tests/control (+7/-0)
debian/tests/dryrun (+11/-0)
debian/tests/prep.py (+22/-0)
debian/tests/smoketest (+13/-0)
debian/tests/unittests (+11/-0)
debian/upstream/signing-key.asc (+2459/-0)
debian/watch (+2/-0)
setup.cfg (+9/-3)
system_image.egg-info/PKG-INFO (+10/-0)
system_image.egg-info/SOURCES.txt (+141/-0)
system_image.egg-info/dependency_links.txt (+1/-0)
system_image.egg-info/entry_points.txt (+4/-0)
system_image.egg-info/requires.txt (+1/-0)
system_image.egg-info/top_level.txt (+1/-0)
systemimage/docs/Makefile (+0/-153)
systemimage/tests/data/index_25.json (+22/-0)
tools/heregpg (+0/-7)
tools/mkvenv.py (+0/-121)
tools/sd.py (+0/-53)
tags: | added: client |
Changed in ubuntu-system-image: | |
status: | New → Triaged |
Changed in ubuntu-system-image: | |
importance: | Undecided → Medium |
Changed in ubuntu-system-image: | |
status: | Triaged → In Progress |
assignee: | nobody → Barry Warsaw (barry) |
Changed in ubuntu-system-image: | |
status: | In Progress → Fix Committed |
Changed in ubuntu-system-image: | |
status: | Fix Committed → Fix Released |
no longer affects: | ubuntu-download-manager |
To post a comment you must log in.
I suspect this is really a bug in the u-d-m. Progress numbers are plumbed straight through from u-d-m to the s-i D-Bus API. u-d-m sends s-i `progress` signals with two values, the number of received bytes and the total number of bytes to download. We take those numbers directly from the u-d-m signal and send them on to s-i-dbus clients via the UpdateProgress signal. The numbers are completely unchanged, so that's why I think this is really a bug in u-d-m.