[sponsor-patch] Doesn't warn about missing dependencies

Bug #846385 reported by Stefano Rivera
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-dev-tools (Ubuntu)
Fix Released
Low
Stefano Rivera

Bug Description

Sponsor patch requires a few things, that it calls with subprocess.

I ran across, lintian, quilt (required by edit-patch), and bzr. There are probably others. It should probably detect that these are missing as soon as possible (or not fail without them)

Revision history for this message
Benjamin Drung (bdrung) wrote :

Yes and we should recommend quilt and lintian.

Changed in ubuntu-dev-tools (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Stefano Rivera (stefanor) wrote :

I added a check for these commands very early, that'll print a warning if they are missing. Not everything is needed for every invocation, so it just warns rather than failing straight away.

Changed in ubuntu-dev-tools (Ubuntu):
assignee: nobody → Stefano Rivera (stefanor)
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-dev-tools - 0.139

---------------
ubuntu-dev-tools (0.139) unstable; urgency=low

  [ Stefano Rivera ]
  * syncpackage, backportpackage, sponsor-patch: Use -nc when building source
    packages. Avoids needing build-deps on the build machine.
  * sponsor-patch:
    - Determine the task from the UDD branch.
    - Support syncs of new packages.
    - Support syncs from a non-default series (LP: #931644)
    - Check for dependencies that the package doesn't Depend on. Recommend
      dput, lintian, patch, quilt. (LP: #846385)
  * Re-add dgetlp. Still needed for downloading source packages from +queue.
    (LP: #919805)
  * pbuilder-dist:
    - Export DISTRIBUTION and ARCHITECTURE as well as DIST and ARCH. Thanks
      Alessio Treglia. (Closes: #659060, LP: #423609)
    - Pass DEB_BUILD_OPTIONS through (LP: #685786)
  * reverse-depends: Now that Debian is supported server-side:
    - Convert Debian release aliases to codenames.
    - Default to the devel release of the vendor distribution.
    - Provide transitional reverse-build-depends wrapper to help users
      discover reverse-depends. (LP: #910420)
  * backportpackage: Map Debian release aliases to codenames (LP: #918231)

  [ Evan Broder]
  * sponsor-patch, requestsync, syncpackage: Add a config variable for -k
    arguments.

 -- Stefano Rivera <email address hidden> Wed, 15 Feb 2012 17:21:39 +0200

Changed in ubuntu-dev-tools (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.