Ubuntu
ubuntu-dev-tools package

syncpackage depends on DEBFULLNAME being set

Bug #665202 reported by Emmet Hikory
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-dev-tools (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Binary package hint: ubuntu-dev-tools

I ran `syncpackage -v` to see what would happen, with the following results:

$ syncpackage -v
Traceback (most recent call last):
  File "/usr/bin/syncpackage", line 409, in <module>
    default = os.environ["DEBFULLNAME"])
  File "/usr/lib/python2.6/UserDict.py", line 22, in __getitem__
    raise KeyError(key)
KeyError: 'DEBFULLNAME'

    To me it appears that it fails looking for the DEBFULLNAME environment variable. In the many years I've been working with Debian format packages, I believe I've never set this (I tend to use DEBEMAIL="name name <email@domain>" which works just fine). I suspect that firstly, syncpackage shouldn't rely on this being present (as none of the standard development tools require it), and secondly that if it's absent, it shouldn't crash (programs should never crash: if something doesn't work, tell the user *why* without making them interpret the traceback).

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: ubuntu-dev-tools 0.104
ProcVersionSignature: Ubuntu 2.6.35-22.33-generic 2.6.35.4
Uname: Linux 2.6.35-22-generic x86_64
Architecture: amd64
Date: Sat Oct 23 01:30:48 2010
InstallationMedia: Ubuntu 10.10 "Maverick Meerkat" - Alpha amd64 (20100803.1)
PackageArchitecture: all
ProcEnviron:
 LANG=en_US.utf8
 SHELL=/bin/bash
SourcePackage: ubuntu-dev-tools

Revision history for this message
Emmet Hikory (persia) wrote :
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

To make this worse, it also crashes even when you set UPLOADER_NAME, which is supposed to override DEBFULLNAME anyways.

  -n UPLOADER_NAME, --uploader-name=UPLOADER_NAME
                        Use UPLOADER_NAME as the name of the maintainer for
                        this upload instead of evaluating DEBFULLNAME.

$ syncpackage --uploader-name "Andrew Starr-Bochicchio" deluge
Traceback (most recent call last):
  File "/usr/bin/syncpackage", line 409, in <module>
    default = os.environ["DEBFULLNAME"])
  File "/usr/lib/python2.6/UserDict.py", line 22, in __getitem__
    raise KeyError(key)
KeyError: 'DEBFULLNAME'

Changed in ubuntu-dev-tools (Ubuntu):
status: New → Confirmed
importance: Undecided → Medium
Benjamin Drung (bdrung)
Changed in ubuntu-dev-tools (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-dev-tools - 0.105

---------------
ubuntu-dev-tools (0.105) experimental; urgency=low

  [ Siegfried-Angel Gevatter Pujals ]
  * pbuilder-dist, doc/pbuilder-dist.1:
     - Export the distribution and architecture information to the environment
       so that it is available in pbuilderrc, etc. (LP: #628933).

  [ Naty Bidart ]
  * lp-project-upload: Add support handling multiple project series.

  [ Kees Cook ]
  * mk-sbuild: use --no-install-recommends on Debian too (Closes: #599699).

  [ Marco Rodrigues ]
  * pull-debian-source:
     - Show message when a package isn't in Debian testing (LP: #529041).

  [ Stefano Rivera ]
  * doc/syncpackage.1:
     - Add a warning that the use of syncpackage is discouraged.
     - Correct and neaten options.
  * syncpackage:
     - Add --dont-sign parameter, for test builds.

  [ Christopher James Halse Rogers ]
  * mk-sbuild: Add support for btrfs-snapshot based chroots

  [ Iain Lane ]
  * pbuilder-dist: Explicitly use debian keyring when working with a
    Debian chroot, working around #599695

  [ Benjamin Drung ]
  * syncpackage:
    - Don't crash if environment variables aren't set (LP: #665202).
    - Don't add quotation marks to changelog entries (LP: #668805).
    - Show a error message instead of raising an error if Ubuntu contains a
      newer version.
    - Print an error message if the source-only build fails (LP: #668749).
 -- Benjamin Drung <email address hidden> Sat, 30 Oct 2010 20:58:30 +0200

Changed in ubuntu-dev-tools (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.