Scroll Position Jumps To Marked Item

Steps to reproduce:
1. Open a folder that contains more files than can be displayed (=> scrollbar present)
2. Mark the last file in folder
3. Slowly scroll towards the top (e.g., using mouse wheel)

In my case the scroll position jumps back to the marked file at the bottom.
Similar "jumping" effects occured when marking all files in a scrollable folder.

When rolling back thunar v1.6.6 the problem does not occur at all.

If there is any more information I can provide, just let me know.

That happens to me too, but only when tumblerd is working on the current folder

If all the thumbnails has been building before, everything is ok.

Can confirm with thunar 1.6.7 in arch linux.

Yes, this is annoying. The tumblerd hint is quite valuable, maybe it can help with debugging.

Tracked it down, it is caused by http://git.xfce.org/xfce/thunar/commit/?id=4d19f45feb198b3a580ef2f777e2c50be2e3a0d3:

commit 4d19f45feb198b3a580ef2f777e2c50be2e3a0d3
Author: Harald Judt <email address hidden>
Date: Tue Mar 31 22:05:22 2015 +0200

    Restore selection on row changes too (bug #9886)

Despite the commit message, this does not exactly fix bug #9886 (which has been fixed by a separate commit), but it deals with related issues, e.g. when renaming files and their position in the view changes (for all views).

Fixing both issues is not quite trivial, need much more time looking into this.

On second thought, the model emits a "rows-reordered" signal which from a quick glance is not processed by any views. Calling the selection-restore code from there might be a better idea.

Created attachment 6226
call-selection-restore-only-when-rows-reordered-signal-is-received.patch

For a start, this patch should fix most issues.

Created attachment 6227
keep-the-scroll-position-when-restoring-the-file-selection.patch

Test case:

1) mkdir test
2) cd test
3) while true; do for i in a aa aaa b bb bbb c d e eee ff gg kk lll l x y g h i zz z u uu uuu xxxxx cb; do touch "$i"; sleep 1; done; done
4) open thunar window for this dir, switch ordering to modification date
5) make sure the window is not big enough to show all files
6) select a file and watch

Behaviour without the patch: View always tries to keep the selected file in the visible area.

Behaviour with the patch: View will not try to keep the selected file in the visible area.

I hope this patch has no bad side-effects for operations. In that case, one could still call scroll_to_file manually.

Pushed to git master:
http://git.xfce.org/xfce/thunar/commit/?id=8ed38783d6a831cdc70a34d90a7f82fe4350ff74
http://git.xfce.org/xfce/thunar/commit/?id=bc1351183e50262588d0226d13cc1ace613b524c