There is hibernate option even without an active swap partition

I'm not sure if systemd is the right project to report this bug against, please let me know if I made any mistakes.

We are basically reusing the hibernate option (after getting it back in) remapped to hybrid sleep. But the idea is the same, as hybrid sleep also saves the state to disk, we will need this to not show when swap is not present.

Can you please give me the output of

  $ for op in suspend hibernate suspend-hybrid; do sudo pm-is-supported --$op && echo $op; done

to confirm that it shows hibernate? That would be pm-utils not seeing the lack of a swap partition then.

Nevermind, pm-utils isn't checking available swap at all. In the past, upower did that, but now systemd and systemd-shim would need to pick that up.

Checked deeper, src/login/logind-action.c() calls can_sleep(), which in version 204 does not yet check for swap. So we need to backport the checks in src/shared/sleep-config.c from later versions.

Patches backported from newer systemd, committed: http://anonscm.debian.org/gitweb/?p=pkg-systemd/systemd.git;a=commitdiff;h=2ecac75111a5b

I tested this on a system without swap and with a swap partition. It also supports swap files, but I haven't explicitly tested that.

Uploaded the trusty SRU, thanks Yu Ning!

Hello Yu, or anyone else affected,

Accepted systemd into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/systemd/204-5ubuntu20.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Thank you Martin for your patch.

I verified it as comment #8 suggested, after upgrading systemd to 204-5ubuntu20.1 on trusty:
a) with swap partition enabled, there is the "hibernate" option in the menu, click it can enter S4 successfully.
b) with swap partition disabled, there is no "hibernate" option in the menu.
c) with swap file enabled, there is the "hibernate" option in the menu, click it can enter S4 successfully.

So, everything just works as expect, I'll change the tag from verification-needed to verification-done.

This has been in trusty-updates for a while already, the bug was just forgotten to get closed.

This has been fixed already in trusty-updates

This bug was fixed in the package systemd - 204-10ubuntu4

---------------
systemd (204-10ubuntu4) utopic; urgency=medium

  * Drop Fix-a-race-condition-at-boot-with-serio-devices.patch, superseded by
    cherry-picked more generic upstream fix.
  * logind.conf: Enable net_cls and netprio too, for compatibility with future
    kernels. (LP: #1317179)
  * Pull latest keymaps from upstream.

systemd (204-11) UNRELEASED; urgency=medium

  [ Martin Pitt ]
  * Explain patch management in debian/README.source. (Closes: #739113)
  * Replace "Always probe cpu support drivers" patch with cherry-picked
    upstream fix which is more general.
  * Advertise hibernation only if there's enough free swap. Patches backported
    from current upstream. (LP: #1313522)
  * Fix typo in sg loading rule to make it actually work.

  [ Michael Biebl ]
  * Make no-patch-numbers the default for gbp-pq.

  [ Michael Stapelberg ]
  * Clarify that “systemd” does not influence init whereas “systemd-sysv” does
    (Closes: #747741)
 -- Martin Pitt <email address hidden> Sun, 25 May 2014 12:24:21 +0200