list view doesn't use correct sorting
Bug #969215 reported by
Kiwinote
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
software-center (Ubuntu) |
Fix Released
|
Medium
|
Gary Lasker |
Bug Description
Test case:
- launch s-c
- search for 'ark'
- click on 'all software'
- click on the 'accessories' category
- notice that the combibox states that the list is sorted by top rated - it isn't however, as when sorted by top rated the first result should be 7zip, not minbar
Second test case per mvo's review from a separate bug's merge proposal (https:/
- search for "foo"
- change "by name"
- go back
- go a a category like "accessories" will sort by name, but the combo will show "by top rated"
Related branches
lp://staging/~gary-lasker/software-center/sorting-fix-lp969215
- Michael Vogt (community): Approve
-
Diff: 117 lines (+32/-11)4 files modifiedsoftwarecenter/ui/gtk3/panes/availablepane.py (+4/-0)
softwarecenter/ui/gtk3/panes/softwarepane.py (+3/-0)
softwarecenter/ui/gtk3/views/appview.py (+20/-11)
test/gtk3/test_app_view.py (+5/-0)
description: | updated |
Changed in software-center (Ubuntu): | |
status: | New → Triaged |
milestone: | none → ubuntu-12.04 |
Changed in software-center (Ubuntu): | |
assignee: | nobody → Gary Lasker (gary-lasker) |
status: | Triaged → In Progress |
description: | updated |
description: | updated |
Changed in software-center (Ubuntu): | |
status: | In Progress → Fix Committed |
To post a comment you must log in.
It appears that _refresh_ apps_with_ apt_cache( ) uses return self.app_ view.get_ sort_mode( ) and that returns the wrong
value.
The reason is that display_matches() updates the combobox but get_sort_mode() is called before display_matches so
the combo is still using the old value.