Ubuntu
software-center package

include oem descriptor in internal webkit user agent string

Bug #1042749 reported by Michael Vogt
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Fix Released
Medium
Michael Vogt
Precise
Fix Released
Medium
Michael Vogt

Bug Description

In order to make it easier to know what people are on what release and also to gather data about the oem image in use, we would like to include the user agent in the embedded webkit browser.

TEST CASE:
- regression test with a purchase is enough, nothing should change for the user

See original description

Related branches

lp://staging/~mvo/software-center/oem-descriptor-in-user-agent
James Westby (community): Approve
software-store-developers: Pending requested
Diff: 221 lines (+89/-16)
8 files modified
softwarecenter/enums.py (+1/-1)
softwarecenter/paths.py (+2/-0)
softwarecenter/ui/gtk3/widgets/webkit.py (+21/-4)
softwarecenter/utils.py (+13/-1)
tests/data/ubuntu_dist_channel (+3/-0)
tests/gtk3/test_purchase.py (+0/-10)
tests/gtk3/test_webkit.py (+44/-0)
tests/test_utils.py (+5/-0)
lp://staging/~mvo/software-center/oem-descriptor-in-user-agent-5.2
Gary Lasker (community): Approve
Diff: 225 lines (+89/-16)
8 files modified
softwarecenter/enums.py (+1/-1)
softwarecenter/paths.py (+3/-0)
softwarecenter/ui/gtk3/views/webkit.py (+21/-4)
softwarecenter/utils.py (+13/-1)
test/data/ubuntu_dist_channel (+3/-0)
test/gtk3/test_purchase.py (+0/-10)
test/gtk3/test_webkit.py (+42/-0)
test/test_utils.py (+6/-0)
lp://staging/software-center/5.2
lp://staging/ubuntu/precise-proposed/software-center
Revision history for this message
Michael Vogt (mvo) wrote :

Subscribing the SRU team, the diff is here:
https://code.launchpad.net/~mvo/software-center/oem-descriptor-in-user-agent-5.2/+merge/121615

If that can go in as a SRU I would like to propose if for merging.

Changed in software-center (Ubuntu):
status: New → Fix Released
Changed in software-center (Ubuntu Precise):
status: New → In Progress
tags: added: ca-escalated
Changed in software-center (Ubuntu):
importance: Undecided → Medium
Changed in software-center (Ubuntu Precise):
importance: Undecided → Medium
Michael Vogt (mvo)
description: updated
Michael Vogt (mvo)
Changed in software-center (Ubuntu Precise):
status: In Progress → Triaged
Revision history for this message
David Pitkin (dpitkin) wrote :

This is a small User Agent addition that will give us the ability to split out OEM preinstall banner traffic from downloaders.

Gary Lasker (gary-lasker)
summary: - include oem descriptor in intrnal webkit user agent string
+ include oem descriptor in internal webkit user agent string
Changed in software-center (Ubuntu Precise):
status: Triaged → In Progress
Changed in software-center (Ubuntu):
assignee: nobody → Michael Vogt (mvo)
Changed in software-center (Ubuntu Precise):
assignee: nobody → Michael Vogt (mvo)
Revision history for this message
Chris Halse Rogers (raof) wrote :

I've rejected the software-center SRU from the precise-proposed queue, as bug #1006570 and bug #1042279 have been waiting for test cases and regression potential for over a month now.

Once these bugs have the necessary information for an SRU, please ping me or another an SRU team member in #ubuntu-release and we can fish it out of the rejected queue.

Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Michael, or anyone else affected,

Accepted software-center into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/software-center/5.2.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in software-center (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

"Bought" knightstour (0€) just fine, and logging in via the browser looked normal.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 5.2.7

---------------
software-center (5.2.7) precise-proposed; urgency=low

  * lp:~mvo/software-center/oem-descriptor-in-user-agent-5.2:
    - include the oem-channel descriptor in the custom user agent
      string (LP: #1042749)
  * lp:~mvo/software-center/auto-fill-email-for-login:
    - allow auto-fill of the email in login.ubuntu.com if
      we have it (LP: #1042279)
  * lp:~mvo/software-center/fix-memleak-5.2:
    - fix two memory leaks when the cache is re-opened after
      a package has been installed/removed (LP: #1003466)
  * lp:~mvo/software-center/region-whitelist-5.2:
    - fix missing region whitelist support that is used by
      the software-center-agent (LP: #1006570)
  * lp:~mvo/software-center/downloader-fix-race839462-again-5.2:
    - fix a race condition in the SimpleFileDownloader when the file
      is downloaded but the signal did not get delivered yet by the
      gtk event loop (LP: #1055441)
 -- Michael Vogt <email address hidden> Wed, 26 Sep 2012 09:39:43 +0200

Changed in software-center (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.