crash for missing hardware "hardware::storage:cd"

Bug #1026494 reported by Michael Vogt
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Fix Released
Medium
Unassigned
Precise
Fix Released
Medium
Unassigned

Bug Description

TEST CASE:
- trivial typo fix with almost zero regression potential
- a regression test is enough

If there is a missing hardware: "hardware::storage:cd" for a app it will crash with. This was uncovered when running the testsuite with "debtags" fully installed and updated.
...
  File "/scratch/egon/devel/software-center/5.2/softwarecenter/ui/gtk3/views/appdetailsview.py", line 1741, in show_app
    skip_update_addons=skip_update_addons)
  File "/scratch/egon/devel/software-center/5.2/softwarecenter/ui/gtk3/views/appdetailsview.py", line 1547, in _update_all
    self._update_warning_bar(app_details)
  File "/scratch/egon/devel/software-center/5.2/softwarecenter/ui/gtk3/views/appdetailsview.py", line 1458, in _update_warning_bar
    app_details.hardware_requirements)
  File "/scratch/egon/devel/software-center/5.2/softwarecenter/hw.py", line 104, in get_hw_missing_long_description
    descr = descr % postfix
TypeError: unsupported operand type(s) for %: 'NoneType' and 'str'

This is due to a typo in softwarecente/hw.py

Michael Vogt (mvo)
Changed in software-center (Ubuntu):
importance: Undecided → Medium
Changed in software-center (Ubuntu Precise):
importance: Undecided → Medium
Changed in software-center (Ubuntu):
status: New → In Progress
Changed in software-center (Ubuntu Precise):
status: New → In Progress
Revision history for this message
Clint Byrum (clint-fewbar) wrote : Please test proposed package

Hello Michael, or anyone else affected,

Accepted software-center into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/software-center/5.2.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in software-center (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Gary Lasker (gary-lasker) wrote :

I have verified that software-center version 5.2.5 in precise-proposed does not cause any regressions per the test details given in the description.

Thanks!

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 5.2.5

---------------
software-center (5.2.5) precise-proposed; urgency=low

  [ Michael Vogt ]
  * lp:~mvo/software-center/fix-lp1009039:
    - fix treeview selection background (LP: #1009039)
  * lp:~mvo/software-center/fix-lp1011522:
    - fix bug where clicking on "Reinstall previous purchases" twice
      shows endless spinner (LP: #1011522)
  * lp:~mvo/software-center/click_url:
    - adds support for a "click_url" from the exhibits banner to
      support banners for things like the humble-bundle where we
      don't have packages but URLs (LP: #1020205)
  * lp:~mvo/software-center/hopefully-fix-lp1008229:
    - fix crash that can happen if there is an error while
      opening a deb file (LP: #1008229)
  * lp:~mvo/software-center/lp1026494:
    - typo fix in the hw description code (LP: #1026494)

  [ Gary Lasker ]
  * lp:~gary-lasker/software-center/unity-launcher-integration-fixes:
    - fix bug where for-purchase items are not being added to the Unity
      launcher (LP: #925014)
    - fix bug where the Unity launcher item for an application incorrectly
      points to its app-install-data desktop file rather than its installed
      desktop file (LP: #999427)
    - fix bug where an application's icon remains in the Unity launcher after
      the corresponding application has been uninstalled (LP: #981488)
    - fix bug where the Unity launcher fails to auto-hide after installation
      of a for-purchase item (LP: #1002440)
    - fix bug where items in the "Independent" section are not being added
      to the Unity launcher (LP: #1012877)
  * lp:~gary-lasker/software-center/tech-items-to-launcher-fix-lp1006483:
    - don't add an item to the launcher if its desktop file specifies
      NoDisplay=true (LP: #1006483)
  * lp:~gary-lasker/software-center/launcher-integration-unit-tests:
   - additional unit tests to round out the suite for the Unity
     launcher integration feature
  * lp:~gary-lasker/software-center/fix-lp969907-for-5.2:
    - fix race condition in _app_activated_cb() (LP: #969907)
 -- Michael Vogt <email address hidden> Mon, 23 Jul 2012 16:38:04 +0200

Changed in software-center (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 5.3.7

---------------
software-center (5.3.7) quantal; urgency=low

  [ Michael Vogt ]
  * lp:~mvo/software-center/cleanup-in-config-code:
    - consolidate and simplify config handling for
      all configuration values
  * lp:~mvo/software-center/distro-detection-robustness:
    - tweak the distro detection to make it more robust
      against changes in the case for the plattform string
      and also makes the filenames/classnames more pythonic
  * lp:~mvo/software-center/fix-seperator-crash:
    - remove instance of self.separator_login as we do not
      use this anymore, prevents a crash
  * lp:~mvo/software-center/improve-test-for-config:
    - additional unit tests for the config handling code
  * lp:~mvo/software-center/set-ssl-stuff-in-webkitwidget:
    - move the webkit.py file into 'widgets' and consolidate
      all of the webkit settings there
  * lp:~mvo/software-center/use-lxml:
    - use python-lxml instead of xml.etree as the former is
      quite a bit faster
  * lp:~mvo/software-center/new-pep8 :
    - use pep8 comandline instead of "import pep8" to make it work again
      on quantal where the internal API of pep8 has changed
  * merged 5.2 branch that includes fix for LP: #1026494
  * lp:~mvo/software-center/cache-for-parse-applications-menu:
    - cache the result of parse_applications menu so it is run
      only once for better startup performance
  * lp:~mvo/software-center/lp913966:
    - support the new gnome 3 in the "where is it" feature
      (LP: #913966)
  * lp:~mvo/software-center/add-currency-property:
    - add a "currency" property to the appdetails and use
      it in the UI
  * lp:~mvo/software-center/no-piston-data-means-error:
    - if we don't get data at all from the webservice/cache in
      piston-generic-helper, emit a error signal
  * lp:~mvo/software-center/rec-small-cleanup:
    - small duplication cleanup
  * lp:~mvo/software-center/dep8:
    - enable automatic dep8 based testsuite running
      on the remote server
  * lp:~mvo/software-center/fix-new-pep8:
    - fix all pep8 issues in quantal branch test
  * softwarecenter/db/categories.py, tests/test_categories.py:
    - do not use cached categories in tests
  * lp:~mvo/software-center/lobby-testfixes:
    - fix tests when categories cache is used with multiple DBs
  * lp:~mvo/software-center/fix-lp870847-5.2:
    - fix incorrect validation pattern in modify_review call, this
      should fix the ablity of users to modify their reviews
      (LP: #870847)

  [ Gary Lasker ]
  * lp:~gary-lasker/software-center/fix-purchaseview-test:
   - fix the purchase view unit test to conform to the new config
     code
  * lp:~gary-lasker/software-center/display-cached-recommendations:
   - display cached recommendations in the lobby view in the case of
     no network access
  * lp:~gary-lasker/software-center/rec-tiny-cleanup:
    - additional bit of cleanup in the recommendations UI code
  * lp:~gary-lasker/software-center/fix-new-pep8-precise-fix:
    - small fix to allow trunk to continue to run on Precise
 -- Michael Vogt <email address hidden> Fri, 17 Aug 2012 11:57:20 +0200

Changed in software-center (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.