| 2016-09-20 10:41:43 |
Michael Hudson-Doyle |
bug |
|
|
added bug |
| 2016-09-20 10:45:19 |
Zygmunt Krynicki |
snap-confine (Ubuntu): status |
New |
In Progress |
|
| 2016-09-20 10:45:38 |
Zygmunt Krynicki |
bug task added |
|
snap-confine |
|
| 2016-09-20 10:50:26 |
Zygmunt Krynicki |
description |
Probably because of the old kernel version, a test fails like this:
/ns/sc_init_ns_group: OK
/ns/sc_lock_unlock_ns_mutex: OK
**
ERROR:ns-support-test.c:323:test_nsfs_fs_id: assertion failed (buf.f_type == NSFS_MAGIC): (40864 == 1853056627)
/ns/nsfs_fs_id: FAIL |
Probably because of the old kernel version, a test fails like this:
/ns/sc_init_ns_group: OK
/ns/sc_lock_unlock_ns_mutex: OK
**
ERROR:ns-support-test.c:323:test_nsfs_fs_id: assertion failed (buf.f_type == NSFS_MAGIC): (40864 == 1853056627)
/ns/nsfs_fs_id: FAIL
12:44 < mwhudson> 40864 seems to be PROC_SUPER_MAGIC
12:44 < mwhudson> zyga: https://bugs.launchpad.net/ubuntu/+source/snap-confine/+bug/1625565
12:44 < zyga> mwhudson: thanks
12:45 < mwhudson> and NSFS_MAGIC was only added to the kernel in a commit from Sat Nov 1 10:57:28 2014 -0400
12:45 < mwhudson> so that's not going to be in the 14.04 release kernel
12:46 < mwhudson> 3.19+
12:46 < zyga> mwhudson: so even the kernel headers have that macro, the relevant files in the kernel don't use it?
12:47 < mwhudson> zyga: well the kernel headers you are building against are from yakkety presumably
12:47 < zyga> mwhudson: yes, I just checked that :/
12:47 < zyga> mwhudson: the mount namespace file in the kernel is indeed procfs
12:47 < zyga> mwhudson: I guess this test needs to be skipped
12:47 < zyga> mwhudson: and we might need a separate check for this in snap-confine proper
12:48 < zyga> so that if we open and see PROC_SUPER_MAGIC we can die() |
|
| 2016-09-20 10:50:31 |
Zygmunt Krynicki |
snap-confine: status |
New |
In Progress |
|
| 2016-09-20 10:50:36 |
Zygmunt Krynicki |
snap-confine: assignee |
|
Zygmunt Krynicki (zyga) |
|
| 2016-09-20 10:50:41 |
Zygmunt Krynicki |
snap-confine: milestone |
|
1.0.42 |
|
| 2016-09-20 10:50:46 |
Zygmunt Krynicki |
snap-confine: importance |
Undecided |
High |
|
| 2016-09-20 19:44:29 |
Zygmunt Krynicki |
snap-confine: status |
In Progress |
Fix Committed |
|
| 2016-09-20 19:44:37 |
Zygmunt Krynicki |
snap-confine (Ubuntu): status |
In Progress |
Fix Released |
|
| 2016-09-26 17:02:15 |
Zygmunt Krynicki |
snap-confine: status |
Fix Committed |
Fix Released |
|
| 2016-10-04 10:16:09 |
Andy Whitcroft |
snap-confine (Ubuntu Xenial): status |
New |
Fix Committed |
|
| 2016-10-04 10:16:11 |
Andy Whitcroft |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2016-10-04 10:16:13 |
Andy Whitcroft |
bug |
|
|
added subscriber SRU Verification |
| 2016-10-04 10:16:18 |
Andy Whitcroft |
tags |
|
verification-needed |
|
| 2016-10-04 15:46:55 |
Zygmunt Krynicki |
description |
Probably because of the old kernel version, a test fails like this:
/ns/sc_init_ns_group: OK
/ns/sc_lock_unlock_ns_mutex: OK
**
ERROR:ns-support-test.c:323:test_nsfs_fs_id: assertion failed (buf.f_type == NSFS_MAGIC): (40864 == 1853056627)
/ns/nsfs_fs_id: FAIL
12:44 < mwhudson> 40864 seems to be PROC_SUPER_MAGIC
12:44 < mwhudson> zyga: https://bugs.launchpad.net/ubuntu/+source/snap-confine/+bug/1625565
12:44 < zyga> mwhudson: thanks
12:45 < mwhudson> and NSFS_MAGIC was only added to the kernel in a commit from Sat Nov 1 10:57:28 2014 -0400
12:45 < mwhudson> so that's not going to be in the 14.04 release kernel
12:46 < mwhudson> 3.19+
12:46 < zyga> mwhudson: so even the kernel headers have that macro, the relevant files in the kernel don't use it?
12:47 < mwhudson> zyga: well the kernel headers you are building against are from yakkety presumably
12:47 < zyga> mwhudson: yes, I just checked that :/
12:47 < zyga> mwhudson: the mount namespace file in the kernel is indeed procfs
12:47 < zyga> mwhudson: I guess this test needs to be skipped
12:47 < zyga> mwhudson: and we might need a separate check for this in snap-confine proper
12:48 < zyga> so that if we open and see PROC_SUPER_MAGIC we can die() |
[Impact]
snap-confine contains sanity unit tests that check if the kernel behaves in a certain, particular way that subsequent runtime behaviour depends on. As it happens to be launchpad package building machinery runs on an older kernel with a xenial/yakkety chroot and the sanity test fails.
The relevant unit tests now check and parse kernel version and unless a recent enough version is available, those tests are skipped.
[Test Case]
N/A
Technically if someone wants to verify this change then it is sufficient to rebuild the package on 14.04 release (not the LTS updated) kernel like 3.19.
[Regression Potential]
None, this only affects unit tests in a safe way.
[Other Info]
* This bug is a part of a major SRU that brings snap-confine in Ubuntu 16.04 in line with the current upstream release 1.0.42.
* snap-confine is technically an integral part of snapd which has an SRU exception and is allowed to introduce new features and take advantage of accelerated procedure. For more information see https://wiki.ubuntu.com/SnapdUpdates
== # Pre-SRU bug description follows # ==
Probably because of the old kernel version, a test fails like this:
/ns/sc_init_ns_group: OK
/ns/sc_lock_unlock_ns_mutex: OK
**
ERROR:ns-support-test.c:323:test_nsfs_fs_id: assertion failed (buf.f_type == NSFS_MAGIC): (40864 == 1853056627)
/ns/nsfs_fs_id: FAIL
12:44 < mwhudson> 40864 seems to be PROC_SUPER_MAGIC
12:44 < mwhudson> zyga: https://bugs.launchpad.net/ubuntu/+source/snap-confine/+bug/1625565
12:44 < zyga> mwhudson: thanks
12:45 < mwhudson> and NSFS_MAGIC was only added to the kernel in a commit from Sat Nov 1 10:57:28 2014 -0400
12:45 < mwhudson> so that's not going to be in the 14.04 release kernel
12:46 < mwhudson> 3.19+
12:46 < zyga> mwhudson: so even the kernel headers have that macro, the relevant files in the kernel don't use it?
12:47 < mwhudson> zyga: well the kernel headers you are building against are from yakkety presumably
12:47 < zyga> mwhudson: yes, I just checked that :/
12:47 < zyga> mwhudson: the mount namespace file in the kernel is indeed procfs
12:47 < zyga> mwhudson: I guess this test needs to be skipped
12:47 < zyga> mwhudson: and we might need a separate check for this in snap-confine proper
12:48 < zyga> so that if we open and see PROC_SUPER_MAGIC we can die() |
|
| 2016-10-10 18:21:58 |
Leo Arias |
tags |
verification-needed |
verification-done |
|
| 2016-10-10 20:20:51 |
Launchpad Janitor |
snap-confine (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2016-10-10 20:21:28 |
Steve Langasek |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
