Ubuntu
shotwell package

Crash on edit with external editor, results in corrupt image database entry

Bug #1511914 reported by Janne Moren on 2015-10-31

This bug affects 8 people

	Status	Importance	Assigned to
Shotwell	Unknown	Unknown	gnome-bugs #759403
shotwell (Ubuntu)	Confirmed	High	Unassigned
Xenial	Confirmed	High	Unassigned

Bug Description

Select "edit with external editor". The image opens in Gimp, but Shotwell crashes. Save the image, open shotwell (order doesn't matter).

* The image thumbnail doesn't change proportions to the edited image, resulting in squashed image. And rotated images lose their rotation information on screen. The underlying edited image is unaffected. This happens only with images edited with the crash above; previous images are fine.

* I am unable to permanently change associated data such as the grade/stars. Once I quite Shotwell those changes are gone. Again, this affects only images edited as above.

* This happened with the update to Wily Werewolf (Shotwell 0.22.0-Ubuntu5). Previous Shotwell version in Vivid was fine.

See original description

Tags:

Revision history for this message

Janne Moren (jan-moren-gmail) wrote on 2015-10-31:

Left side: the edited image as shown in the viewer. On the right, the same edited image as seen in Shotwell Edit (441.6 KiB, image/jpeg)

Revision history for this message

Janne Moren (jan-moren-gmail) wrote on 2015-10-31:

Attempt to run Shotwell with gdb. Edit (11.5 KiB, text/plain)

Tried to run Shotwell under gdb. Couldn't get it to produce a trace.

Revision history for this message

Janne Moren (jan-moren-gmail) wrote on 2015-10-31:

Shotwell log file Edit (21.1 KiB, text/plain)

Janne Moren (jan-moren-gmail) on 2015-11-02

description:

updated

Revision history for this message

Janne Moren (jan-moren-gmail) wrote on 2015-11-02:

Added info: If I first do an edit - any edit - using Shotwell itself so that it creates a changed file on disk, I can then edit the image with an external editor without problems.

So the issue seems to be connected to creating an editable copy of the image when triggering the action by using an external editor. Or possibly by using gimp, specifically, as the external editor?

Revision history for this message

Gertjan (gertjan-hofman) wrote on 2015-11-03:

Same problem seen here on Wily. Unable to open external editor without shotwell crashing. But I can even trigger a complete log-out ( x11 crash ?) ) with this operation, if I repeat a few times. Worked fine in Vivid.

Revision history for this message

Sebastien Bacher (seb128) wrote on 2015-11-17:

The stacktrace indicates the issue is due to the code not handling correctly the new glib file monitor events

Changed in shotwell (Ubuntu):
importance:	Undecided → High
tags:	added: rls-x-incoming

Will Cooke (willcooke) on 2015-11-23

tags:

removed: rls-x-incoming

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-11-27:

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in shotwell (Ubuntu):
status:	New → Confirmed

Revision history for this message

Sebastien Bacher (seb128) wrote on 2015-12-15:

That has been reported upstream as well, https://bugzilla.gnome.org/show_bug.cgi?id=759403

Revision history for this message

Janne Moren (jan-moren-gmail) wrote on 2015-12-20:

Any way I can help fix this? Shotwell is completely unusable now.

Revision history for this message

Amr Ibrahim (amribrahim1987) wrote on 2016-05-03:

#10

It is fixed upstream.

Revision history for this message

Amr Ibrahim (amribrahim1987) wrote on 2016-06-11:

#11

Fixing commit:

https://git.gnome.org/browse/shotwell/commit/?id=1886512

tags:

added: xenial

Revision history for this message

Amr Ibrahim (amribrahim1987) wrote on 2016-10-29:

#12

Please update Shotwell to fix this bug.

Revision history for this message

Øyvind Stegard (oyvindstegard) wrote on 2017-08-12:

#13

Any chance the fix will be backported to Shotwell in 16.04 ?

Revision history for this message

John Ladasky (john-ladasky) wrote on 2017-09-21:

#14

This bug has appeared for me in just the past week. I upgraded to Ubuntu GNOME 17.04 several months ago and have used Shotwell a few times. I was able to click "edit with external editor" without Shotwell closing... at first.