redis configuration enable include fragments by default

Bug #1929244 reported by Sam Bortman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
redis (Ubuntu)
New
Undecided
Unassigned

Bug Description

Hello,

lsb_release:
Description: Ubuntu 18.04.5 LTS
Release: 18.04
(but the issue is observed on newer releases too.)

package:
5:4.0.9-1ubuntu0.2 500

Summary:
Expected behaviour: configuration fragments included by default
Current behavior: configuration fragments aren't included by default

Longer form:
Currently the redis.conf configuration file supports the "include" keyword. However, by default, nothing is included. Problems can pop up when local configuration needs to be maintained between upgrades. The upgrade mechanism will prompt for manual intervention with the configuration file, if any changes were made to it. Depending on the amount of customization done therein, this could cause a time-consuming and error-prone situation of having to merge/patch things up.

Other packages, such as Apache and MySQL (for instance, amongst many others), have addressed this by providing a "conf.d"-style directory and having "include conf.d/*" type of statement in the default configuration file that's maintained by the package maintainer. This is effectively the standard approach seen nowadays in Linux.

The benefit is obvious: one can simply drop their local configuration file into the provided conf.d directory and upgrade away with far fewer worries.

In summary, please consider affecting the following two (or three) changes to the redis package:
1) add an empty /etc/redis/conf.d directory to the package

2) add the statement "include /etc/reds/conf.d/*" to the bottom of the official /etc/redis.conf file to serve as an override of all default settings

3) it's not clear to me whether wildcard can actually currently be specified in the include statement. If they currently cannot be specified, please patch the code to glob using the pattern specified in the include, instead of targeting an individual file.

Thank you!

Revision history for this message
Julian Andres Klode (juliank) wrote :

Given that redis is not a supported package, but just automatically synced from Debian into universe, it would be great if you could raise this issue with Debian and get it addressed there and then it will automatically pop up in future Ubuntu releases.

I can do that too, if you prefer, but avoiding a proxy person is best :)

Revision history for this message
Sam Bortman (sambo770) wrote :

Thank you, sir, for your very prompt reply. My bad -- I totally forgot some packages originate in Debian and trickle down to Ubuntu.

I followed your advice and opened a bug there.
For prosperity for anyone reading this in the future, here's the URL:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=988947

Please feel free to close this bug here in Launchpad.

Revision history for this message
Sam Bortman (sambo770) wrote :

For completeness, here's a bug against Redis that requests wildcard include functionality:
https://github.com/redis/redis/issues/6351

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.