Ubuntu
qtubuntu package

Mir client platform plugin depends on ubuntu-platform-api

Bug #1482107 reported by Paul Olav Tvete
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qtubuntu (Ubuntu)
Confirmed
High
Unassigned

Bug Description

This is not currently a problem, but long term we may need a solution for building the upstreamed Qt plugin on non-Ubuntu versions of Mir. It does not make sense to have multiple plugins that are 90% identical. Since there would be no point in compiling several versions in the same Qt tree, the best solution is to have conditional dependencies and #ifdefs

Unofficial-tags: things-we-dont-need-to-worry-about-right-now

Tags: qt-upstream
Revision history for this message
Gerry Boland (gerboland) wrote :

Have you ideas on how we would solve this? Have a platform abstraction system in the QPA itself, which can optionally load ubuntu-platform-api or other-platform-api?

Gerry Boland (gerboland)
Changed in qtubuntu:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Paul Olav Tvete (paul-tvete) wrote :

Wouldn't it be enough to do this at compile time?

Revision history for this message
Gerry Boland (gerboland) wrote :

Probably yeah

Revision history for this message
Gerry Boland (gerboland) wrote :

As Paul suggested on IRC, we can just wrap ubuntu-platform-api code with #ifdef USE_UBUNTU statements, and use pkg-config to determine if that preprocessor directive should be set or not.

If possible, even better would probably be to have *_ubuntu.cpp files and *_otherbrand.cpp files and do the magic in the .pro file

Michał Sawicz (saviq)
affects: qtubuntu → qtubuntu (Ubuntu)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.