Ubuntu QPA plugin does not override QScreen::devicePixelRatio
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
qtubuntu (Ubuntu) |
In Progress
|
Medium
|
Gerry Boland | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Zsombor Egri |
Bug Description
In bug 1257721, I made Oxide DPI aware by passing an appropriate device pixel ratio to Chromium. However, the way this is implemented on Ubuntu is not really ideal. I expected to be able to read the DPR from QScreen:
For now, I implemented a workaround in Oxide to also set the DPR to GRID_UNIT_PX / 8 when running with the Ubuntu platform plugin, and QScreen:
I think that qtubuntu should instead override QScreen:
Related branches
- Zsombor Egri: Approve
- PS Jenkins bot: Approve (continuous-integration)
- Loïc Molinari (community): Approve
- Gerry Boland (community): Needs Information
-
Diff: 1044 lines (+747/-26)22 files modifieddebian/control (+5/-0)
src/Ubuntu/Components/plugin/ucqquickimageextension.cpp (+23/-3)
src/Ubuntu/Components/plugin/ucubuntushape.cpp (+17/-13)
src/Ubuntu/Components/plugin/ucunits.cpp (+46/-5)
src/Ubuntu/Components/plugin/ucunits.h (+1/-0)
tests/unit/add_makecheck.pri (+12/-1)
tests/unit/custom_qpa/README (+15/-0)
tests/unit/custom_qpa/custom.json (+3/-0)
tests/unit/custom_qpa/custom_qpa.pro (+15/-0)
tests/unit/custom_qpa/main.cpp (+54/-0)
tests/unit/custom_qpa/qcustombackingstore.cpp (+64/-0)
tests/unit/custom_qpa/qcustombackingstore.h (+55/-0)
tests/unit/custom_qpa/qcustomintegration.cpp (+112/-0)
tests/unit/custom_qpa/qcustomintegration.h (+74/-0)
tests/unit/runtest.sh (+2/-0)
tests/unit/tst_units/dpr1/dpr1.pro (+3/-0)
tests/unit/tst_units/dpr2/dpr2.pro (+3/-0)
tests/unit/tst_units/dpr2/tst_units_dpr2.cpp (+143/-0)
tests/unit/tst_units/dpr3/dpr3.pro (+3/-0)
tests/unit/tst_units/dpr3/tst_units_dpr3.cpp (+88/-0)
tests/unit/tst_units/tst_units.pro (+6/-3)
tests/unit/unit.pro (+3/-1)
- Ubuntu SDK team: Pending requested
-
Diff: 245 lines (+61/-29)5 files modifiedmodules/Ubuntu/Components/plugin/ucqquickimageextension.cpp (+10/-3)
modules/Ubuntu/Components/plugin/ucubuntushape.cpp (+8/-10)
modules/Ubuntu/Components/plugin/ucunits.cpp (+37/-12)
modules/Ubuntu/Components/plugin/ucunits.h (+5/-3)
ubuntu-sdk.pro (+1/-1)
affects: | ubuntu-ui-toolkit (Ubuntu) → ubuntu-ui-toolkit |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Zsombor Egri (zsombi) |
importance: | Undecided → High |
status: | New → Confirmed |
no longer affects: | ubuntu-ui-toolkit |
Changed in qtubuntu: | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Gerry Boland (gerboland) |
Changed in qtubuntu (Ubuntu): | |
assignee: | nobody → Gerry Boland (gerboland) |
importance: | Undecided → Medium |
status: | Confirmed → In Progress |
no longer affects: | qtubuntu |
Status changed to 'Confirmed' because the bug affects multiple users.