Ubuntu
qtmir package

Not sending relative mouse events to clients

Bug #1597205 reported by Gerry Boland
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Zoltan Balogh
Canonical System Image 13 "OTA13"
qtdeclarative-opensource-src (Ubuntu)
Fix Released
High
Timo Jyrinki
qtdeclarative-opensource-src (Ubuntu RTM)
Fix Released
High
Timo Jyrinki
qtmir (Ubuntu)
Fix Released
High
Daniel d'Andrada
unity8 (Ubuntu)
Invalid
High
Daniel d'Andrada

Bug Description

QtMir is not sending relative mouse movements in mouse events.

Relevant code from mirsurface.cpp:

mir::EventUPtr makeMirEvent(QMouseEvent *qtEvent, MirPointerAction action)
{
    auto timestamp = uncompressTimestamp<qtmir::Timestamp>(qtmir::Timestamp(qtEvent->timestamp()));
    auto modifiers = getMirModifiersFromQt(qtEvent->modifiers());
    auto buttons = getMirButtonsFromQt(qtEvent->buttons());

    return mir::events::make_event(0 /*DeviceID */, timestamp, std::vector<uint8_t>{} /* cookie */, modifiers, action,
                                   buttons, qtEvent->x(), qtEvent->y(), 0, 0, 0, 0);

The last 2 parameters in the make_event call should be the relative x & y motion.

Tags: input

Related branches

lp://staging/~unity-team/qtmir/mouseMovement
Gerry Boland (community): Approve
Unity8 CI Bot (community): Approve (continuous-integration)
Michał Sawicz: Pending requested
Lukáš Tinkl: Pending requested
Diff: 771 lines (+473/-146)
8 files modified
src/modules/Unity/Application/mirsurface.cpp (+11/-146)
src/platforms/mirserver/CMakeLists.txt (+1/-0)
src/platforms/mirserver/eventbuilder.cpp (+249/-0)
src/platforms/mirserver/eventbuilder.h (+103/-0)
src/platforms/mirserver/qteventfeeder.cpp (+5/-0)
tests/mirserver/CMakeLists.txt (+2/-0)
tests/mirserver/EventBuilder/CMakeLists.txt (+25/-0)
tests/mirserver/EventBuilder/eventbuilder_test.cpp (+77/-0)
lp://staging/~ci-train-bot/qtmir/qtmir-ubuntu-yakkety-landing-075
Gerry Boland (gerboland)
Changed in qtmir:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Daniel d'Andrada (dandrader)
Daniel d'Andrada (dandrader)
Changed in unity8 (Ubuntu):
assignee: nobody → Daniel d'Andrada (dandrader)
status: New → Triaged
importance: Undecided → High
Daniel d'Andrada (dandrader)
Changed in qtmir:
status: Triaged → In Progress
Changed in unity8 (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Blocked by https://bugreports.qt.io/browse/QTBUG-54600

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Need to backport https://codereview.qt-project.org/#/c/164552/ into qtdeclarative

Changed in qtdeclarative-opensource-src (Ubuntu):
assignee: nobody → Timo Jyrinki (timo-jyrinki)
Timo Jyrinki (timo-jyrinki)
Changed in qtdeclarative-opensource-src (Ubuntu RTM):
assignee: nobody → Timo Jyrinki (timo-jyrinki)
importance: Undecided → High
Changed in qtdeclarative-opensource-src (Ubuntu):
importance: Undecided → High
Changed in qtdeclarative-opensource-src (Ubuntu RTM):
status: New → In Progress
Daniel van Vugt (vanvugt)
tags: added: input
Timo Jyrinki (timo-jyrinki)
Changed in canonical-devices-system-image:
importance: Undecided → High
milestone: none → 13
assignee: nobody → Zoltan Balogh (bzoltan)
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in qtdeclarative-opensource-src (Ubuntu):
status: New → Confirmed
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

This bug was fixed in the package qtdeclarative-opensource-src 5.4.1-1ubuntu11~overlay9~1 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

qtdeclarative-opensource-src (5.4.1-1ubuntu11~overlay9~1) vivid; urgency=medium

  * debian/patches/Flickable-fix-minXExtent-minYExtent-when-content-is-.patch:
    - Fix flickable's widthRatio and heightRatio (LP: #1588238)
  * debian/patches/QQuickWindow-Fill-out-timestamps-in-QHoverEvents-sen.patch:
    - Fix relative mouse events (LP: #1597205)
    - debian/libqt5quick5.symbols: Update symbols.

 -- Timo Jyrinki <email address hidden> Thu, 02 Jun 2016 10:18:08 +0000

Changed in qtdeclarative-opensource-src (Ubuntu RTM):
status: In Progress → Fix Released
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

This bug is not fixed as we still need the qtmir part. The fix in qtdeclarative-opensource-src (a fix in the timestamps of QHoverEvents) just unblocked the qtmir work.

Daniel d'Andrada (dandrader)
Changed in unity8 (Ubuntu):
status: In Progress → Invalid
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtdeclarative-opensource-src - 5.6.1-4ubuntu2~1

---------------
qtdeclarative-opensource-src (5.6.1-4ubuntu2~1) yakkety; urgency=medium

  * debian/patches/Flickable-fix-minXExtent-minYExtent-when-content-is-.patch:
    - Fix flickable's widthRatio and heightRatio (LP: #1588238)
  * debian/patches/QQuickWindow-Fill-out-timestamps-in-QHoverEvents-sen.patch:
    - Fix relative mouse events (LP: #1597205)
    - debian/libqt5quick5.symbols: Update symbols.

 -- Timo Jyrinki <email address hidden> Wed, 27 Jul 2016 12:11:13 +0000

Changed in qtdeclarative-opensource-src (Ubuntu):
status: Confirmed → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
Gerry Boland (gerboland)
Changed in qtmir:
status: In Progress → Fix Released
Michał Sawicz (saviq)
affects: qtmir → qtmir (Ubuntu)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.