Ubuntu
qtbase-opensource-src package

[Qt-5.6 distropatch] Fix GCC -Wsuggest-override warning on Q_OBJECT

Bug #1619483 reported by Loïc Molinari
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qtbase-opensource-src (Ubuntu)
Fix Released
Medium
Timo Jyrinki

Bug Description

The C++11 override keyword cannot be used in the Q_OBJECT macro. Qt 5.6 disables the equivalent for clang but not for GCC. The required patches are [1] and [2]. I've just proposed the latter one upstream because there was an error in the former patch.

[1] https://github.com/qt/qtbase/commit/3092bd56c394f22e027be59368789546afb5ca98
[2] https://codereview.qt-project.org/#/c/169969/

Loïc Molinari (loic.molinari)
summary: - Fix GCC -Wsuggest-override warning on Q_OBJECT
+ [Qt-5.6 distropatch] Fix GCC -Wsuggest-override warning on Q_OBJECT
Timo Jyrinki (timo-jyrinki)
Changed in qtbase-opensource-src (Ubuntu):
status: New → Confirmed
Revision history for this message
Loïc Molinari (loic.molinari) wrote :

https://codereview.qt-project.org/#/c/169969/ has been approved.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtbase-opensource-src - 5.6.1+dfsg-3ubuntu4~6

---------------
qtbase-opensource-src (5.6.1+dfsg-3ubuntu4~6) yakkety; urgency=medium

  [ Timo Jyrinki ]
  * debian/patches/Make-QDBusConnectionPrivate-relaySignal-be-called-in.patch:
    - Antoher DBus fix needed for telephony-service (LP: #1620945)
  * debian/patches/Fix-gcc-Wsuggest-override-warning-on-Q_OBJECT.patch
    debian/patches/Fix-the-GCC-version-supporting-Wsuggest-override.patch:
    - Fix GCC -Wsuggest-override warning on Q_OBJECT (LP: #1619483)
  * debian/patches/Fix-parsing-of-tzfile-5-POSIX-rule-zone-names-with-b.patch:
    - Fix parsing of rule zone names for certain time zones (LP: #1622089)
  * debian/patches/Avoid-artifacts-when-hiding-or-closing-a-QOpenGLWidg.patch
    debian/patches/QtWidgets-Send-show-hide-event-to-children-on-restor.patch:
    - Fix event sending to children, hurting Oxide-Qt use on desktop
      (LP: #1613670)
  * Disable QStaticText tests for now (QTBUG-55653)

 -- Timo Jyrinki <email address hidden> Mon, 12 Sep 2016 05:42:31 +0000

Changed in qtbase-opensource-src (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.