network disk cache does not take into account the HTTP Vary header
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Medium
|
John McAleely | ||
qtbase-opensource-src (Ubuntu) |
Confirmed
|
Medium
|
Unassigned | ||
unity-scope-click (Ubuntu) |
Fix Released
|
Medium
|
Paweł Stołowski |
Bug Description
Switching from English to Polish works as expected
But then going back to English leaves me with store in Polish
This survives reboots.
Steps to reproduce:
1. Go to Ubuntu Store scope (with your current language).
2. Go to phone settings, change the language, accept & reboot the phone.
3. Go to Ubuntu Store scope. Note how scope title and some strings such as "installed" changed for the new language (since these are provided locally by the scope for current LANG), but strings such as 'Highlight of the week' or departments names (hit the search lens icon to reveal departments) which come from the store still use the old language.
See upstream bug at https:/
Related branches
- dobey (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 86 lines (+39/-1)2 files modifiedlibclickscope/click/network_access_manager.cpp (+38/-1)
libclickscope/click/network_access_manager.h (+1/-0)
Changed in unity-scope-click (Ubuntu): | |
status: | New → Confirmed |
Changed in unity-scope-click (Ubuntu): | |
importance: | Undecided → Medium |
Changed in canonical-devices-system-image: | |
assignee: | nobody → Alejandro J. Cura (alecu) |
importance: | Undecided → Medium |
status: | New → Confirmed |
Changed in canonical-devices-system-image: | |
milestone: | none → 12 |
Changed in unity-scope-click (Ubuntu): | |
assignee: | nobody → Pawel Stolowski (stolowski) |
Changed in unity-scope-click (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in canonical-devices-system-image: | |
status: | Confirmed → In Progress |
summary: |
- Language in the Store scope doesn't always change when user switches - lang of the phone + network disk cache does not take into account the HTTP Vary header |
description: | updated |
Changed in canonical-devices-system-image: | |
assignee: | Alejandro J. Cura (alecu) → John McAleely (john.mcaleely) |
milestone: | 12 → 13 |
Changed in qtbase-opensource-src (Ubuntu): | |
status: | Confirmed → Fix Committed |
status: | Fix Committed → Confirmed |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
Changed in qtbase-opensource-src (Ubuntu): | |
assignee: | Lorn Potter (lorn-potter) → nobody |
It seems this is related to network caching. Removing all cache files from /home/phablet/ .cache/ unity-scope- click/network (wait till scope is restarted) fixes it (correct language is used).
Server side of the store was just recently updated with more relaxed expiration times, so now cache is actually used in more cases than before. The "Vary" header sent by the server seems to be correct (contains Accept-Language, among others), so I'm wondering if Qt handles Vary header correctly.