The "gendelta" command should abort as opposed to generating broken deltas

Bug #424451 reported by Muharem Hrnjadovic
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pristine-tar (Debian)
pristine-tar (Ubuntu)

Bug Description

Binary package hint: pristine-tar

When a file is missing from the unpacked source tree "pristine-tar gendelta" will happily generate a (broken) delta without as much of a warning. It should abort with an error instead.

The error can be reproduced easily:

$ apt-get source apg
Reading package lists... Done
Building dependency tree
Reading state information... Done
Need to get 90.2kB of source archives.
Get: 1 karmic/universe apg 2.2.3.dfsg.1-2 (dsc) [620B]
Get: 2 karmic/universe apg 2.2.3.dfsg.1-2 (tar) [83.6kB]
Get: 3 karmic/universe apg 2.2.3.dfsg.1-2 (diff) [5993B]
Fetched 90.2kB in 0s (208kB/s)
dpkg-source: info: extracting apg in apg-2.2.3.dfsg.1
dpkg-source: info: unpacking apg_2.2.3.dfsg.1.orig.tar.gz
dpkg-source: info: applying apg_2.2.3.dfsg.1-2.diff.gz
$ cd apg-2.2.3.dfsg.1/
$ pristine-tar gendelta ../apg_2.2.3.dfsg.1.orig.tar.gz ../brokendelta
$ echo $?
$ rm ../apg_2.2.3.dfsg.1.orig.tar.gz
$ pristine-tar gentar ../brokendelta ../apg_2.2.3.dfsg.1.orig.tar.gz
tar: apg-2.2.3.dfsg.1/README.CYGWIN: Cannot stat: No such file or directory
tar: Exiting with failure status due to previous errors
pristine-tar: command failed: tar cf /tmp/pristine-tar.lLB0MOTtSg/recreatetarball --owner 0 --group 0 --numeric-owner -C /tmp/pristine-tar.lLB0MOTtSg/workdir --no-recursion --mode 0644 --files-from /tmp/pristine-tar.lLB0MOTtSg/manifest

Related branches

Revision history for this message
Muharem Hrnjadovic (al-maisan) wrote :

Related bug #417153.

Changed in pristine-tar (Debian):
status: Unknown → New
Changed in pristine-tar (Ubuntu):
status: New → In Progress
assignee: nobody → Muharem Hrnjadovic (al-maisan)
Changed in pristine-tar (Ubuntu):
status: In Progress → Confirmed
Rolf Leggewie (r0lf)
Changed in pristine-tar (Ubuntu):
assignee: Muharem Hrnjadovic (al-maisan) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.