Thanks Seth for the audit and thanks Dustin for fixing some of the noted issues. So no blocker from security. As for the other aspects of a MIR, see below.
Blockers:
- Please subscribe a relevant team that will do maintenance for this to Ubuntu bugs. (Ideally not just yourself)
Notes:
- It would be really nice if this had some sort of test suite that was run during build. A dep8 test would be even better, which maybe could take advantage of the check_pollen script.
- Looks like a typo in pollinate.postinst:
chown root:root /var/lib/pollinate/
should be:
chown root:root /var/lib/pollinate/tag
(though why is this chown even necessary?)
Thanks Seth for the audit and thanks Dustin for fixing some of the noted issues. So no blocker from security. As for the other aspects of a MIR, see below.
Blockers:
- Please subscribe a relevant team that will do maintenance for this to Ubuntu bugs. (Ideally not just yourself)
Notes:
- It would be really nice if this had some sort of test suite that was run during build. A dep8 test would be even better, which maybe could take advantage of the check_pollen script.
- Looks like a typo in pollinate.postinst: pollinate/ tag
chown root:root /var/lib/pollinate/
should be:
chown root:root /var/lib/
(though why is this chown even necessary?)