dpkg-buildflags wipes out LFS support in package build

Bug #1280044 reported by Andreas Fischer
This bug affects 1 person
Affects Status Importance Assigned to Milestone
php5 (Debian)
Fix Released
php5 (Ubuntu)
Fix Released
Robie Basak

Bug Description

On Ubuntu 13.10 x86 PHP is not compiled with Large File Support making it impossible to open files larger than 4 GiB.

The root cause of this seems to be that "getconf LFS_CFLAGS" returns an empty string which is used in debian/rules to determine whether LFS supports should be enabled or not. The same command returns "-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64" on Debian x86 systems.

Revision history for this message
Robie Basak (racb) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better.

Confirmed. Though after further investigation, I disagree with your conclusion. I found that "getconf LFS_CFLAGS" is correct, but a future "include /usr/share/dpkg/buildflags.mk" wipes out the changes that the previous call made.

I believe that this issue also affects Debian, so have filed a bug there: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=738984

summary: - Large File Support Regression
+ dpkg-buildflags wipes out LFS support in package build
Changed in php5 (Ubuntu):
status: New → Triaged
importance: Undecided → High
milestone: none → ubuntu-14.04-beta-2
assignee: nobody → Robie Basak (racb)
Revision history for this message
Andreas Fischer (bantu) wrote :

Thanks for taking care of this. I can confirm that this is also a Debian issue (in what is to be become Debian Jessie), but Debian Wheezy does not seem to be affected.

Changed in php5 (Debian):
status: Unknown → New
Robie Basak (racb)
Changed in php5 (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package php5 - 5.5.9+dfsg-1ubuntu1

php5 (5.5.9+dfsg-1ubuntu1) trusty; urgency=medium

  * Merge from Debian testing. Remaining changes:
    - d/control: drop Build-Depends that are in universe: firebird-dev,
      libc-client-dev, libmcrypt-dev, libonig-dev, libqdbm-dev.
    - d/rules: drop configuration of packages that are in universe: qdgm, onig.
    - d/rules: drop CONFIGURE_APACHE_ARGS settings since now we don't build
      interbase or firebird.
    - d/rules: export DEB_HOST_MULTIARCH properly.
    - d/control: drop binary packages php5-imap, php5-interbase and php5-mcrypt
      since we have separate versions in universe.
    - d/modulelist: drop imap, interbase and mcrypt since we have separate
      versions in universe.
    - d/rules: drop configuration of imap and mcrypt since we have separate
      versions in universe.
    - d/source_php5.py, d/rules: add apport hook.
    - d/rules: stop mysql instance on clean just in case we failed in tests.
    - d/control: switch Build-Depends of netcat-traditional to netcat-openbsd
      as only the latter is in main.
    - d/rules, d/control: drop use of dh_systemd as it is in universe.
    - debian/rules: re-enable tests
    - d/tests/{cgi,cli,mod-php}: dep8 tests for common use cases.
  * Drop changes (upstreamed to Debian):
    - d/p/use-system-timezone.patch, d/tests/system-timezone: use system
      timezone by default, instead of requiring it to be configured.
  * d/rules: load dpkg-buildflags earlier, so that CFLAGS changes are not
    overridden (LP: #1280044).

php5 (5.5.9+dfsg-1) unstable; urgency=medium

  * New upstream version 5.5.9+dfsg
  * Install CLI specific ini file with PCNTL enabled (Closes: #720434)
  * Use php_admin_flag in Apache settings (Closes: #690964)

php5 (5.5.8+dfsg-3) unstable; urgency=low

  * Fix regression in system fallback for date_default_timezone_get()
    (Closes: #730771)
 -- Robie Basak <email address hidden> Mon, 17 Feb 2014 16:58:27 +0000

Changed in php5 (Ubuntu):
status: In Progress → Fix Released
Changed in php5 (Debian):
status: New → Fix Released
Changed in php5 (Debian):
status: Fix Released → New
Changed in php5 (Debian):
status: New → Fix Released
Revision history for this message
Andreas Fischer (bantu) wrote :

Confirming fix. Tested version 5.5.9+dfsg-1ubuntu4 on Trusty.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.