2020-05-11 21:33:45 |
Bryce Harrington |
bug |
|
|
added bug |
2020-05-11 21:33:53 |
Bryce Harrington |
php-parser (Ubuntu): status |
New |
In Progress |
|
2020-05-11 21:33:57 |
Bryce Harrington |
php-parser (Ubuntu): assignee |
|
Bryce Harrington (bryce) |
|
2020-05-11 21:34:20 |
Bryce Harrington |
tags |
|
update-excuse |
|
2020-05-11 21:34:26 |
Bryce Harrington |
tags |
update-excuse |
ftbfs update-excuse |
|
2020-05-11 23:27:33 |
Bryce Harrington |
summary |
php-parser autopkgtests fail with php7.4 7.4.3-4ubuntu2 |
php-parser autopkgtests fail with php7.4 7.4.3-4ubuntu2 on armhf |
|
2020-05-11 23:37:12 |
Bryce Harrington |
description |
php-parser: https://launchpad.net/ubuntu/+source/php-parser/4.2.2-2
php7.4: https://launchpad.net/ubuntu/+source/php7.4/7.4.3-4ubuntu2
Originally failing Log: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy/groovy/armhf/p/php-parser/20200502_014803_a1f47@/log.gz
- EmulativeTest::testErrorAfterEmulation with various data sets
- EmulativeTest::testError with various data sets
- LexerTest::testError with various data sets
php7.4 is blocked from migration of three CVEs due to test failures with php-parser. Php-parser has a newer 4.4.0-1 stuck in proposed, but triggering the two together did not resolve the issue:
Newly failing log: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy/groovy/armhf/p/php-parser/20200501_165040_5a5c8@/log.gz
- CodeParsingTest::testParse: Differint integer syntaxes
- Lexer\EmulativeTest::testLexNewFeatures: '0xCAFE_F00D' |
php-parser: https://launchpad.net/ubuntu/+source/php-parser/4.2.2-2
php7.4: https://launchpad.net/ubuntu/+source/php7.4/7.4.3-4ubuntu2
Originally failing Log: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy/groovy/armhf/p/php-parser/20200502_014803_a1f47@/log.gz
- EmulativeTest::testErrorAfterEmulation with various data sets
- EmulativeTest::testError with various data sets
- LexerTest::testError with various data sets
php7.4 is blocked from migration of three CVEs due to test failures with php-parser. Php-parser has a newer 4.4.0-1 stuck in proposed, but triggering the two together did not resolve the issue:
Newly failing log: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy/groovy/armhf/p/php-parser/20200501_165040_5a5c8@/log.gz
- CodeParsingTest::testParse: Different integer syntaxes
- Lexer\EmulativeTest::testLexNewFeatures: '0xCAFE_F00D' |
|
2020-05-12 00:08:16 |
Bryce Harrington |
bug watch added |
|
https://github.com/nikic/PHP-Parser/issues/662 |
|
2020-05-12 00:22:28 |
Bryce Harrington |
bug task added |
|
php |
|
2020-05-12 01:35:53 |
Bug Watch Updater |
php: status |
Unknown |
New |
|
2020-05-12 23:25:30 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~bryce/+git/php-parser/+merge/383830 |
|
2020-05-15 03:26:33 |
Launchpad Janitor |
php-parser (Ubuntu): status |
In Progress |
Fix Released |
|
2020-09-29 23:06:04 |
Bryce Harrington |
nominated for series |
|
Ubuntu Focal |
|
2020-09-29 23:06:04 |
Bryce Harrington |
bug task added |
|
php-parser (Ubuntu Focal) |
|
2020-09-29 23:06:04 |
Bryce Harrington |
nominated for series |
|
Ubuntu Groovy |
|
2020-09-29 23:06:04 |
Bryce Harrington |
bug task added |
|
php-parser (Ubuntu Groovy) |
|
2020-09-29 23:11:24 |
Bryce Harrington |
php-parser (Ubuntu Focal): importance |
Undecided |
High |
|
2020-09-29 23:11:24 |
Bryce Harrington |
php-parser (Ubuntu Focal): status |
New |
Triaged |
|
2020-09-29 23:11:24 |
Bryce Harrington |
php-parser (Ubuntu Focal): assignee |
|
Bryce Harrington (bryce) |
|
2020-09-29 23:16:03 |
Bryce Harrington |
description |
php-parser: https://launchpad.net/ubuntu/+source/php-parser/4.2.2-2
php7.4: https://launchpad.net/ubuntu/+source/php7.4/7.4.3-4ubuntu2
Originally failing Log: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy/groovy/armhf/p/php-parser/20200502_014803_a1f47@/log.gz
- EmulativeTest::testErrorAfterEmulation with various data sets
- EmulativeTest::testError with various data sets
- LexerTest::testError with various data sets
php7.4 is blocked from migration of three CVEs due to test failures with php-parser. Php-parser has a newer 4.4.0-1 stuck in proposed, but triggering the two together did not resolve the issue:
Newly failing log: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy/groovy/armhf/p/php-parser/20200501_165040_5a5c8@/log.gz
- CodeParsingTest::testParse: Different integer syntaxes
- Lexer\EmulativeTest::testLexNewFeatures: '0xCAFE_F00D' |
[Impact]
Other php SRUs end up blocked from migration due to a test case in php-parser that fails due to an integer format mismatch.
[Test Case]
1. Create lxc container for ubuntu-focal
2. Install php-parser
3. Run autopkgtest php-parser -- null
The testsuite should pass but it does not, and fails with EmulativeTest issues starting with (and similar to) this one:
1) PhpParser\Lexer\EmulativeTest::testErrorAfterEmulation with data set #0 ('??=', array(array(281, '??=')))
Failed asserting that actual size 0 matches expected size 1.
/tmp/autopkgtest.eZ6NuZ/build.Ar8/src/test/PhpParser/Lexer/EmulativeTest.php:110
[Regression Potential]
Since this is a testsuite fix for integer parsing on armhf, the two things to watch for would be a) issues relating to the testsuite, or b) issues particular to armhf (especially traceable to integer parsing behavior). However, in the first case, the testsuite's behavior would crop up only during building / migrating in the archive and would not produce user-visible effects. In the second case, integer parsing issues already exist in released code so would not be a true regression, the test case only exposes them - by preventing other php packages from migrating.
[Discussion]
php-parser's autopkgtest has been failing in focal on armhf for some time:
http://autopkgtest.ubuntu.com/packages/p/php-parser/focal/armhf
The test failure is due to an integer format mismatch. We spotted this issue on groovy and flagged it for upstream:
https://github.com/nikic/PHP-Parser/issues/662
There doesn't appear to be a fix identified yet. We addressed it in groovy by disabling the faulty tests (the one listed in this bug, and the one in LP: #1895878), and that may be a low-risk way to address it for focal, too.
https://launchpad.net/ubuntu/+source/php-parser/4.4.0-1ubuntu2
php-parser: https://launchpad.net/ubuntu/+source/php-parser/4.2.2-2
php7.4: https://launchpad.net/ubuntu/+source/php7.4/7.4.3-4ubuntu2
Originally failing Log: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy/groovy/armhf/p/php-parser/20200502_014803_a1f47@/log.gz
- EmulativeTest::testErrorAfterEmulation with various data sets
- EmulativeTest::testError with various data sets
- LexerTest::testError with various data sets
php7.4 is blocked from migration of three CVEs due to test failures with php-parser. Php-parser has a newer 4.4.0-1 stuck in proposed, but triggering the two together did not resolve the issue:
Newly failing log: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy/groovy/armhf/p/php-parser/20200501_165040_5a5c8@/log.gz
- CodeParsingTest::testParse: Different integer syntaxes
- Lexer\EmulativeTest::testLexNewFeatures: '0xCAFE_F00D' |
|
2020-10-14 00:24:14 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~bryce/ubuntu/+source/php-parser/+git/php-parser/+merge/392194 |
|
2020-10-28 15:30:43 |
Robie Basak |
tags |
ftbfs update-excuse |
block-proposed-focal ftbfs update-excuse |
|
2020-10-28 15:31:23 |
Robie Basak |
php-parser (Ubuntu Focal): status |
Triaged |
Fix Committed |
|
2020-10-28 15:31:25 |
Robie Basak |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
2020-10-28 15:31:27 |
Robie Basak |
bug |
|
|
added subscriber SRU Verification |
2020-10-28 15:31:30 |
Robie Basak |
tags |
block-proposed-focal ftbfs update-excuse |
block-proposed-focal ftbfs update-excuse verification-needed verification-needed-focal |
|
2020-11-05 07:55:13 |
Bryce Harrington |
tags |
block-proposed-focal ftbfs update-excuse verification-needed verification-needed-focal |
block-proposed-focal ftbfs update-excuse verification-done verification-done-focal |
|
2020-12-18 19:28:10 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~bryce/ubuntu/+source/php-parser/+git/php-parser/+merge/395546 |
|
2021-01-22 00:56:49 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~bryce/ubuntu/+source/php-parser/+git/php-parser/+merge/396706 |
|
2021-11-09 12:32:44 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~utkarsh/ubuntu/+source/php-parser/+git/php-parser/+merge/411593 |
|
2022-03-04 01:12:17 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~bryce/ubuntu/+source/php-parser/+git/php-parser/+merge/416359 |
|
2023-05-14 19:38:58 |
Bug Watch Updater |
php: status |
New |
Fix Released |
|