php packages: add php-mbstring dependency

With these patches, both packages pass their tests.

After discussing with Steve on IRC:

Merge with php-sabre-dav-2.1 2.1.10-1 from Debian unstable, which includes the same tests fixes as our delta as the only change, keep the patch for d/tests/control (debdiff to be attached).
Merge php-sabre-http 4.2.1-3 from Debian unstable, which includes the same test fixes as our delta as the only change, keep the patch for d/tests/control (debdiff to be attached).
Merge php-sabre-http-3 3.0.5-3 from Debian unstable, which includes the same test fixes as the above packages, add a patch for d/tests/control (debdiff to be attached).

The only remaining diff in php-sabre-dav-2.1 is the addition of the php-mbstring package to the test dependencies. However, the debian/tests/control lists:

Depends: @, php-curl, php-sqlite3, phpab, phpunit

I wanted to confirm the test change was still needed, if php-mbstring is in the build-dependencies. '@' is a wildcard meaning 'all the binary packages from this source package'. If php-sabre-dav-2.1 depends on php-mbstring (I see that it uses mbstring functionality at runtime, not just in tests), then no separate test dependency is required.

And I see that composer.json does declare that ext-mbstring is required. So this should get picked up as a dependency in phpcomposer:Debian-require.

However, it does not get picked up.

This is a bug somewhere between pkg-php-tools and php-mbstring.

In the meantime, since the code does have a runtime dependency on mbstring, I am adding this as a hard-coded ependency in debian/control, and dropping the change to debian/tests/control which is redundant as a result.

All three packages are affected by this issue, php-mbstring should bea runtime dep, not a test dep. Adjusted the packaging and uploaded.

Steve,

You are absolutely correct that there is a bug (missing functionality) in Ubuntu's pkg-php-tools. This is my fault due to syncing Debian's version too early (before release) and not versioning Ubuntu's properly. Please find attached a debdiff that properly merges us with pkg-php-tools 1.32, which includes the necessary bugfixes for us to simply sync the other three packages referred to in this bug. We will still need to carry a delta for php-json's message change, but that is already fixed upstream in (pkg-php-tools 1.33~) so we will be able to drop the delta on the next sync.

This bug was fixed in the package pkg-php-tools - 1.32ubuntu2

---------------
pkg-php-tools (1.32ubuntu2) xenial; urgency=medium

  * Properly merge with 1.32 release from Debian unstable
    (LP: #1557599). Remaining changes:
    - tests/PhpcomposerSourceTest.php: update php-json error message
      (Debian Bug #814858).
  * Drop:
    - Add php-xml as Build-dep and test dep.
      [ Fixed in Debian.]

 -- Nishanth Aravamudan <email address hidden> Tue, 15 Mar 2016 14:19:31 -0700

This bug was fixed in the package php-sabre-dav-2.1 - 2.1.10-1ubuntu1

---------------
php-sabre-dav-2.1 (2.1.10-1ubuntu1) xenial; urgency=medium

  * Merge with Debian unstable (LP: #1557599). Remaining changes:
    - Add php-mbstring as a test dependency.
  * Drop:
    - Add php-mbstring as a build dependency.
    - Update to PHP7.0 build and test dependencies.
      [ Present in Debian ]

  [ Steve Langasek ]
  * mbstring is a runtime dependency, not just a test dependency, but
    phpcomposer isn't outputting this as part of the substvar. Add this as
    a hard-coded dep for now, and drop the changes to debian/tests/control,
    which are now redundant.

php-sabre-dav-2.1 (2.1.10-1) unstable; urgency=medium

  [ Evert Pot ]
  * Clean up synclog correctly after deleting addressbook.
  * Prepping for a release

  [ David Prévot ]
  * Revert workarounds for the PHP 7.0 transition, and build with recent
    pkg-php-tools.
  * Move maintenance within Debian PHP PEAR Maintainers

php-sabre-dav-2.1 (2.1.9-2) unstable; urgency=medium

  * Use php-sabre-http-3 instead of php-sabre-http: that makes
    php-sabre-dav-2.1 co-installable with more recent version of php-sabre-dav
  * Update Standards-Version to 3.9.7
  * Prepare php(5) build-dependencies for the PHP 7.0 transition
  * Workaround the ongoing yet not ready PHP 7.0 transition:
    - pkgtools called with -v triggers a segfault (#814858);
    - add override for php(7.0)-* modules (#815988).

 -- Nishanth Aravamudan <email address hidden> Tue, 15 Mar 2016 11:07:05 -0700

This bug was fixed in the package php-sabre-http - 4.2.1-3ubuntu1

---------------
php-sabre-http (4.2.1-3ubuntu1) xenial; urgency=medium

  * Merge with Debian unstable (LP: #1557599). Remaining changes:
    - Add php-mbstring as a test dependency.
  * Drop:
    - Add php-mbstring as a build dependency.
      [ Fixed in Debian]

  [ Steve Langasek ]
  * mbstring is a runtime dependency, not just a test dependency, but
    phpcomposer isn't outputting this as part of the substvar. Add this as
    a hard-coded dep for now, and drop the changes to debian/tests/control,
    which are now redundant.

php-sabre-http (4.2.1-3) unstable; urgency=medium

  * PHP 7.0 transition:
    - Revert Workaround
    - Use now split php-mbstring for the tests
    - Build with recent pkg-php-tools
  * Drop ownCloud for Debian maintainers from uploaders

 -- Nishanth Aravamudan <email address hidden> Tue, 15 Mar 2016 11:19:35 -0700

This bug was fixed in the package php-sabre-http-3 - 3.0.5-3ubuntu1

---------------
php-sabre-http-3 (3.0.5-3ubuntu1) xenial; urgency=medium

  * Add php-mbstring as a hard-coded binary dependency, to work around this
    not getting picked up via pkg-php-tools / phpcomposer. LP: #1557599.

php-sabre-http-3 (3.0.5-3) unstable; urgency=medium

  * PHP 7.0 transition:
    - Revert Workaround
    - Use now split php-mbstring for the tests
    - Build with recent pkg-php-tools
  * Drop ownCloud for Debian maintainers from uploaders

 -- Steve Langasek <email address hidden> Tue, 15 Mar 2016 13:14:06 -0700

Status changed to 'Confirmed' because the bug affects multiple users.

fixed in php-apigen 4.1.2-2