openvswitch-datapath-dkms 1.4.6-0ubuntu1.12.04.3: openvswitch kernel module failed to build [error: too many arguments to function ‘ip_select_ident’]

Status changed to 'Confirmed' because the bug affects multiple users.

Same error here, seemed to be fine on -69, but doesn't build on -70.

he signature of ip_select_ident changed from -69 to -70.

It went from (struct sk_buff *skb, struct dst_entry *dst, struct sock *sk) to (struct sk_buff *skb, struct sock *sk, int segs).

Unfortunately I don't know enough about openvswitch internals to change the call, but the calls are made in datapath/tunnel.c starting line 1303.

The backported patch that caused this was https://lkml.org/lkml/2014/8/8/861

This is obviously a regression in API compatibility for the kernel itself. Marking a linux task to note that.

Now, it may be an acceptable regression in the API, but we need to grep all dkms modules in the archive to see how many might be affected buy this interface change and make an informed decision about possibly reverting, not just paper over it in openvswitch and declare it a done deal.

This change was made by a bot.

The upstream commit that caused this change is:
73f156a6e8c1074ac6327e0abd1169e95eb66463

The new interface is:
void ip_select_ident(struct sk_buff *skb, struct sock *sk)

Commits in ubuntu kernel trees:
3.2/precise: 519331a6416a517ca93a88d8cffc662562f15320
3.13/trusty/precise: 015c969fca9e99d90cda9b399391ac563b4dbc37

Uploaded fix for precise.

Readding the linux task. Chris, as Adam says there's work to be done here to verify that no other modules are affected before regarding this as resolved.

This change was made by a bot.

Hello Omar, or anyone else affected,

Accepted openvswitch into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/openvswitch/1.4.6-0ubuntu1.12.04.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

@vorlon

I've grepped through most DKMS packages and I also see that openswan-modules-dkms is also affected by these upstream changes (and fails to build for other issues), I'll create separate bug for this issue.

Closing the linux task for now as we can ifdef DKMS modules to handle these changes.

The package http://launchpad.net/ubuntu/+source/openvswitch/1.4.6-0ubuntu1.12.04.4 fixes the issue for us, using the https://wiki.ubuntu.com/Testing/EnableProposed instructions. While compiling it still shows a warning at the point where it failed previously but now continues and comes up with a properly working system and internet connection to openvswitch after a reboot.

The verification of the Stable Release Update for openvswitch has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package openvswitch - 1.4.6-0ubuntu1.12.04.4

---------------
openvswitch (1.4.6-0ubuntu1.12.04.4) precise; urgency=medium

  * Update: d/p/0010-datapath_ip_select_ident_fix.patch:
    Fix stable kernel changes to ip_select_ident. (LP: #1379201)
 -- Chris J Arges <email address hidden> Fri, 10 Oct 2014 14:31:19 -0500

This issue also impacts the 2.0.2 ovs release provided in the icehouse cloud-archive for 12.04.

make -C /lib/modules/3.2.0-70-virtual/build M=/var/lib/dkms/openvswitch/2.0.2/build/datapath/linux modules
make[1]: Entering directory `/usr/src/linux-headers-3.2.0-70-virtual'
  CC [M] /var/lib/dkms/openvswitch/2.0.2/build/datapath/linux/actions.o
  CC [M] /var/lib/dkms/openvswitch/2.0.2/build/datapath/linux/datapath.o
  CC [M] /var/lib/dkms/openvswitch/2.0.2/build/datapath/linux/dp_notify.o
  CC [M] /var/lib/dkms/openvswitch/2.0.2/build/datapath/linux/flow.o
  CC [M] /var/lib/dkms/openvswitch/2.0.2/build/datapath/linux/vport.o
  CC [M] /var/lib/dkms/openvswitch/2.0.2/build/datapath/linux/vport-gre.o
  CC [M] /var/lib/dkms/openvswitch/2.0.2/build/datapath/linux/vport-internal_dev.o
  CC [M] /var/lib/dkms/openvswitch/2.0.2/build/datapath/linux/vport-lisp.o
/var/lib/dkms/openvswitch/2.0.2/build/datapath/linux/vport-lisp.c: In function �~@~Xovs_tnl_send�~@~Y:
/var/lib/dkms/openvswitch/2.0.2/build/datapath/linux/vport-lisp.c:586:3: warning: passing argument 2 of �~@~X__ip_select_ident�~@~Y makes integer from pointer without a cast [enabled by default]
include/net/ip.h:268:6: note: expected �~@~Xint�~@~Y but argument is of type �~@~Xstruct dst_entry *�~@~Y
/var/lib/dkms/openvswitch/2.0.2/build/datapath/linux/vport-lisp.c:586:3: error: too many arguments to function �~@~X__ip_select_ident�~@~Y
include/net/ip.h:268:6: note: declared here
make[2]: *** [/var/lib/dkms/openvswitch/2.0.2/build/datapath/linux/vport-lisp.o] Error 1
make[1]: *** [_module_/var/lib/dkms/openvswitch/2.0.2/build/datapath/linux] Error 2
make[1]: Leaving directory `/usr/src/linux-headers-3.2.0-70-virtual'
make: *** [default] Error 2
make: Leaving directory `/var/lib/dkms/openvswitch/2.0.2/build/datapath/linux'

Proposed fix pushed to:

  https://launchpad.net/~james-page/+archive/ubuntu/icehouse

Pending successful testing with the latest 3.2 kernel on 12.04, will push to proposed for the icehouse CA for 12.04

 openvswitch (2.0.2-0ubuntu0.14.04.1~cloud1) precise-icehouse; urgency=medium

   * Backport ip_select_ident signature detection to fix FTBFS of
     dkms packages due to ABI change in stable kernels (LP: #1379201).