Ubuntu
open-vm-tools package

Backport open-vm-tools 12.1.0 as MRE for jammy

Bug #1975767 reported by Bryce Harrington
24
This bug affects 2 people
Affects Status Importance Assigned to Milestone
open-vm-tools (Ubuntu)
Fix Released
Undecided
Unassigned
Ubuntu ubuntu-22.10
Bionic
Won't Fix
Undecided
Unassigned
Focal
Won't Fix
Undecided
Unassigned
Impish
Won't Fix
Undecided
Unassigned
Jammy
Fix Released
High
Bryce Harrington
Ubuntu jammy-updates

Bug Description

[Impact]

 * Without SRUing the newer version users get issues running on more
   recent hypervisors - this is a case of [1] in the SRU policy.

 * Furthermore Upstream releases this as a collection of fixes which is
   usually worth it to pick up.

 * This is not backporting a single fix, but the version of a latter
   Ubuntu release.

 * Two new plugins are provided via new binary packages,
   open-vm-tools-containerinfo and open-vm-tools-salt-minion

[Test Case]

 * TL;DR is "use open-vm-tools" but that can be quite complex for the
   variety of potential Host versions.

 * VMWare itself took ownership of verifying these backports and will test
   the same bits from a PPA and the SRU for the official "ack"

 * Users are invited to test upgrading their own different setups.

 * In general we recommend giving this some extra time in -proposed to see
   if anybody uncovers issues.

[Regression Potential]

 * It is a new version which might contain new issues. This is being
   shipped in kinetic-devel for some weeks, with no new bug reports filed.

 * The addition of new binaries open-vm-tools-containerinfo and
   open-vm-tools-salt-minion are new features and as such may have
   issues, but mitigating that concern is that they're separately
   packaged and not installed by default.

[Other Info]

 * This time the MRE also fixes one bug. We're also backporting that
   fix to earlier LTS's.
 * As agreed back when processing bug 1741390 the real verification of
   open-vm-tools for having the proper test matrix and project ownership
   is on VMWare.

[1]: https://wiki.ubuntu.com/StableReleaseUpdates#Other_safe_cases

See original description

Related branches

~bryce/ubuntu/+source/open-vm-tools:mre-lp1968354-jammy
git-ubuntu bot: Approve
Christian Ehrhardt  (community): Approve
Canonical Server Reporter: Pending requested
Diff: 25331 lines (+16184/-3226) (has conflicts)
182 files modified
README.md (+75/-0)
ReleaseNotes.md (+40/-56)
debian/changelog (+81/-0)
debian/control (+39/-5)
debian/copyright (+3/-1)
debian/open-vm-tools-containerinfo.postinst (+42/-0)
debian/open-vm-tools-containerinfo.postrm (+43/-0)
debian/open-vm-tools-desktop.lintian-overrides (+1/-1)
debian/open-vm-tools-salt-minion.postinst (+42/-0)
debian/open-vm-tools-salt-minion.postrm (+43/-0)
debian/open-vm-tools.postinst (+1/-1)
debian/patches/series (+3/-0)
debian/patches/use-debian-pam (+1/-1)
debian/rules (+11/-0)
debian/upstream/metadata (+1/-0)
dev/null (+0/-785)
open-vm-tools/AUTHORS (+9/-0)
open-vm-tools/ChangeLog (+2347/-65)
open-vm-tools/configure.ac (+248/-14)
open-vm-tools/lib/appUtil/appUtilX11.c (+5/-2)
open-vm-tools/lib/asyncsocket/asyncSocketInterface.c (+3/-4)
open-vm-tools/lib/asyncsocket/asyncSocketVTable.h (+3/-3)
open-vm-tools/lib/asyncsocket/asyncsocket.c (+38/-37)
open-vm-tools/lib/file/fileIO.c (+107/-0)
open-vm-tools/lib/file/fileIOPosix.c (+16/-2)
open-vm-tools/lib/file/fileInt.h (+2/-2)
open-vm-tools/lib/file/fileLockPrimitive.c (+15/-20)
open-vm-tools/lib/file/filePosix.c (+4/-4)
open-vm-tools/lib/glibUtils/fileLogger.c (+2/-0)
open-vm-tools/lib/globalConfig/globalConfig.c (+5/-2)
open-vm-tools/lib/hgfs/cpName.c (+10/-3)
open-vm-tools/lib/hgfs/hgfsEscape.c (+1/-2)
open-vm-tools/lib/hgfs/hgfsUtil.c (+19/-23)
open-vm-tools/lib/include/asyncsocket.h (+23/-2)
open-vm-tools/lib/include/backdoor_def.h (+5/-4)
open-vm-tools/lib/include/buildNumber.h (+6/-6)
open-vm-tools/lib/include/codeset.h (+1/-9)
open-vm-tools/lib/include/conf.h (+114/-1)
open-vm-tools/lib/include/config.h (+6/-2)
open-vm-tools/lib/include/dbllnklst.h (+2/-1)
open-vm-tools/lib/include/dynbuf.h (+18/-1)
open-vm-tools/lib/include/fileIO.h (+9/-0)
open-vm-tools/lib/include/ghIntegrationCommon.h (+32/-2)
open-vm-tools/lib/include/glibUtils.h (+2/-1)
open-vm-tools/lib/include/guest_msg_def.h (+6/-2)
open-vm-tools/lib/include/guest_os.h (+157/-101)
open-vm-tools/lib/include/guest_os_tables.h (+49/-22)
open-vm-tools/lib/include/hostinfo.h (+12/-2)
open-vm-tools/lib/include/includeCheck.h (+7/-6)
open-vm-tools/lib/include/log.h (+127/-131)
open-vm-tools/lib/include/loglevel_userVars.h (+5/-2)
open-vm-tools/lib/include/poll.h (+2/-1)
open-vm-tools/lib/include/sha1.h (+9/-20)
open-vm-tools/lib/include/sigPosixRegs.h (+3/-1)
open-vm-tools/lib/include/sigc++2to3.h (+143/-0)
open-vm-tools/lib/include/strutil.h (+2/-1)
open-vm-tools/lib/include/vm_assert.h (+21/-16)
open-vm-tools/lib/include/vm_atomic.h (+87/-39)
open-vm-tools/lib/include/vm_atomic_arm64_begin.h (+162/-50)
open-vm-tools/lib/include/vm_atomic_arm64_end.h (+7/-1)
open-vm-tools/lib/include/vm_basic_asm.h (+119/-32)
open-vm-tools/lib/include/vm_basic_asm_arm64.h (+69/-18)
open-vm-tools/lib/include/vm_basic_asm_x86_64.h (+32/-1)
open-vm-tools/lib/include/vm_basic_asm_x86_common.h (+64/-27)
open-vm-tools/lib/include/vm_basic_defs.h (+72/-22)
open-vm-tools/lib/include/vm_basic_types.h (+7/-17)
open-vm-tools/lib/include/vm_device_version.h (+14/-25)
open-vm-tools/lib/include/vm_legal.h (+2/-2)
open-vm-tools/lib/include/vm_product.h (+4/-1)
open-vm-tools/lib/include/vm_product_versions.h (+148/-44)
open-vm-tools/lib/include/vm_tools_version.h (+31/-4)
open-vm-tools/lib/include/vm_valgrind.h (+18/-6)
open-vm-tools/lib/include/vm_version.h (+38/-3)
open-vm-tools/lib/include/vmci_defs.h (+65/-12)
open-vm-tools/lib/include/vmware/guestrpc/containerInfo.h (+58/-0)
open-vm-tools/lib/include/vmware/guestrpc/serviceDiscovery.h (+3/-1)
open-vm-tools/lib/include/vmware/guestrpc/timesync.h (+4/-2)
open-vm-tools/lib/include/vmware/tools/log.h (+7/-0)
open-vm-tools/lib/include/vthreadBase.h (+1/-5)
open-vm-tools/lib/include/x86_basic_defs.h (+3/-0)
open-vm-tools/lib/include/x86cpuid.h (+159/-123)
open-vm-tools/lib/lock/ulInt.h (+3/-3)
open-vm-tools/lib/lock/ulStats.c (+6/-6)
open-vm-tools/lib/misc/Makefile.am (+2/-1)
open-vm-tools/lib/misc/codesetOld.c (+5/-5)
open-vm-tools/lib/misc/dynbuf.c (+70/-7)
open-vm-tools/lib/misc/hostinfo.c (+39/-1)
open-vm-tools/lib/misc/hostinfoHV.c (+1/-32)
open-vm-tools/lib/misc/hostinfoInt.h (+2/-2)
open-vm-tools/lib/misc/hostinfoPosix.c (+158/-107)
open-vm-tools/lib/misc/jsonUTF8.c (+483/-0)
open-vm-tools/lib/misc/strutil.c (+43/-1)
open-vm-tools/lib/misc/timeutil.c (+15/-19)
open-vm-tools/lib/misc/util_misc.c (+32/-32)
open-vm-tools/lib/poll/poll.c (+29/-4)
open-vm-tools/lib/procMgr/procMgrPosix.c (+2/-2)
open-vm-tools/lib/rpcVmx/rpcvmx.c (+3/-2)
open-vm-tools/libDeployPkg/linuxDeployment.c (+24/-6)
open-vm-tools/libvmtools/vmtoolsConfig.c (+3/-1)
open-vm-tools/libvmtools/vmtoolsLog.c (+132/-7)
open-vm-tools/modules/shared/vmmemctl/dbllnklst.h (+2/-1)
open-vm-tools/modules/shared/vmmemctl/kernelStubs.h (+16/-5)
open-vm-tools/modules/shared/vmxnet/eth_public.h (+1/-0)
open-vm-tools/modules/shared/vmxnet/vmnet_def.h (+3/-1)
open-vm-tools/modules/shared/vmxnet/vmxnet3_defs.h (+28/-19)
open-vm-tools/modules/solaris/vmhgfs/kernelStubs.h (+16/-5)
open-vm-tools/namespacetool/namespacetool.c (+2/-2)
open-vm-tools/scripts/common/vm-support (+6/-28)
open-vm-tools/services/plugins/Makefile.am (+5/-1)
open-vm-tools/services/plugins/appInfo/appInfo.c (+43/-52)
open-vm-tools/services/plugins/componentMgr/COPYING (+502/-0)
open-vm-tools/services/plugins/componentMgr/Makefile.am (+46/-0)
open-vm-tools/services/plugins/componentMgr/componentMgr.c (+414/-0)
open-vm-tools/services/plugins/componentMgr/componentMgrInstallAction.c (+1216/-0)
open-vm-tools/services/plugins/componentMgr/componentMgrInstallManager.c (+497/-0)
open-vm-tools/services/plugins/componentMgr/componentMgrPlugin.h (+370/-0)
open-vm-tools/services/plugins/componentMgr/componentMgrUtil.c (+216/-0)
open-vm-tools/services/plugins/componentMgr/svtminion.sh (+2134/-0)
open-vm-tools/services/plugins/containerInfo/COPYING (+502/-0)
open-vm-tools/services/plugins/containerInfo/Makefile.am (+98/-0)
open-vm-tools/services/plugins/containerInfo/containerInfo.c (+1016/-0)
open-vm-tools/services/plugins/containerInfo/containerInfoInt.h (+56/-0)
open-vm-tools/services/plugins/containerInfo/containerInfo_docker.c (+503/-0)
open-vm-tools/services/plugins/containerInfo/containerInfo_grpc.cc (+156/-0)
open-vm-tools/services/plugins/deployPkg/deployPkg.c (+26/-17)
open-vm-tools/services/plugins/deployPkg/deployPkgPlugin.c (+52/-11)
open-vm-tools/services/plugins/dndcp/dnd/copyPasteRpc.hh (+3/-2)
open-vm-tools/services/plugins/dndcp/dnd/dndRpc.hh (+3/-2)
open-vm-tools/services/plugins/dndcp/dnd/fileTransferRpc.hh (+3/-2)
open-vm-tools/services/plugins/dndcp/dndGuest/rpcV3Util.cpp (+8/-2)
open-vm-tools/services/plugins/dndcp/dndGuestBase/guestDnD.hh (+2/-2)
open-vm-tools/services/plugins/dndcp/stringxx/string.hh (+15/-1)
open-vm-tools/services/plugins/dndcp/stringxx/ubstr_t.hh (+11/-1)
open-vm-tools/services/plugins/guestInfo/guestInfoServer.c (+19/-20)
open-vm-tools/services/plugins/guestStore/guestStorePlugin.c (+3/-2)
open-vm-tools/services/plugins/resolutionSet/resolutionCommon.c (+5/-3)
open-vm-tools/services/plugins/serviceDiscovery/get-versions.sh (+32/-2)
open-vm-tools/services/plugins/serviceDiscovery/serviceDiscovery.c (+436/-49)
open-vm-tools/services/plugins/serviceDiscovery/serviceDiscoveryInt.h (+22/-4)
open-vm-tools/services/plugins/serviceDiscovery/serviceDiscoveryPosix.c (+45/-82)
open-vm-tools/services/plugins/timeSync/timeSync.c (+10/-14)
open-vm-tools/services/plugins/vix/vixTools.c (+2/-2)
open-vm-tools/services/plugins/vmbackup/stateMachine.c (+28/-4)
open-vm-tools/services/vmtoolsd/mainLoop.c (+0/-5)
open-vm-tools/tests/testVmblock/Makefile.am (+7/-9)
open-vm-tools/toolbox/l10n/de.vmsg (+1/-1)
open-vm-tools/toolbox/l10n/es.vmsg (+1/-1)
open-vm-tools/toolbox/l10n/fr.vmsg (+2/-2)
open-vm-tools/toolbox/l10n/it.vmsg (+1/-1)
open-vm-tools/toolbox/l10n/ja.vmsg (+1/-1)
open-vm-tools/toolbox/l10n/ko.vmsg (+1/-1)
open-vm-tools/toolbox/l10n/zh_CN.vmsg (+1/-1)
open-vm-tools/toolbox/l10n/zh_TW.vmsg (+3/-3)
open-vm-tools/tools.conf (+77/-7)
open-vm-tools/vgauth/cli/l10n/de.vmsg (+1/-1)
open-vm-tools/vgauth/cli/l10n/es.vmsg (+1/-1)
open-vm-tools/vgauth/cli/l10n/fr.vmsg (+1/-1)
open-vm-tools/vgauth/cli/l10n/it.vmsg (+3/-3)
open-vm-tools/vgauth/cli/l10n/ja.vmsg (+1/-1)
open-vm-tools/vgauth/cli/l10n/ko.vmsg (+1/-1)
open-vm-tools/vgauth/cli/l10n/zh_CN.vmsg (+1/-1)
open-vm-tools/vgauth/cli/l10n/zh_TW.vmsg (+1/-1)
open-vm-tools/vgauth/common/certverify.c (+24/-3)
open-vm-tools/vgauth/common/vmxlog.c (+28/-475)
open-vm-tools/vgauth/common/vmxrpc.c (+639/-0)
open-vm-tools/vgauth/common/vmxrpc.h (+33/-0)
open-vm-tools/vgauth/lib/netPosix.c (+3/-1)
open-vm-tools/vgauth/service/Makefile.am (+2/-1)
open-vm-tools/vgauth/serviceImpl/netPosix.c (+9/-2)
open-vm-tools/vgauth/serviceImpl/proto.c (+5/-1)
open-vm-tools/vgauth/serviceImpl/saml-xmlsec1.c (+65/-3)
open-vm-tools/vgauth/serviceImpl/schemas/saml-schema-assertion-2.0.xsd (+283/-283)
open-vm-tools/vmblock-fuse/Makefile.am (+3/-1)
open-vm-tools/vmblock-fuse/fsops.c (+44/-6)
open-vm-tools/vmblock-fuse/fsops.h (+17/-2)
open-vm-tools/vmblock-fuse/main.c (+5/-1)
open-vm-tools/vmhgfs-fuse/Makefile.am (+3/-1)
open-vm-tools/vmhgfs-fuse/config.c (+21/-3)
open-vm-tools/vmhgfs-fuse/dir.c (+5/-1)
open-vm-tools/vmhgfs-fuse/main.c (+58/-20)
open-vm-tools/vmhgfs-fuse/module.h (+8/-2)
open-vm-tools/vmwgfxctrl/main.c (+4/-2)
Bryce Harrington (bryce)
Changed in open-vm-tools (Ubuntu):
milestone: none → ubuntu-22.10
Bryce Harrington (bryce)
summary: - Backport open-vm-tools as MRE for bionic, focal, impish, jammy
+ Backport open-vm-tools as MRE for bionic, focal, impish, jammy (October)
Revision history for this message
Christian Ehrhardt  (paelzer) wrote : Re: Backport open-vm-tools as MRE for bionic, focal, impish, jammy (October)

Now that this is in Kinetic we can update that.

 open-vm-tools | 2:12.1.0-1 | kinetic | source, amd64, arm64

Changed in open-vm-tools (Ubuntu):
status: New → Fix Released
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

We usually only backport the latest version to the latest LTS (as per the agreement with VMware on testing those) trying to balance the SRU regression vs the (virtual) HW compatibility tradeoff.

So I expect this current 12.1.0 only to land in Jammy, but not in B/F also impish is now no more an active release.

Changed in open-vm-tools (Ubuntu Bionic):
status: New → Won't Fix
Changed in open-vm-tools (Ubuntu Focal):
status: New → Won't Fix
Changed in open-vm-tools (Ubuntu Impish):
status: New → Won't Fix
Changed in open-vm-tools (Ubuntu Jammy):
importance: Undecided → High
status: New → Triaged
assignee: nobody → Bryce Harrington (bryce)
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

For awareness - assigning Bryce who looked after open-vm-tools recently.
This isn't a hard assignment, if someone else wants to grab that, let us know.

Bryce Harrington (bryce)
description: updated
Bryce Harrington (bryce)
description: updated
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Bryce, or anyone else affected,

Accepted open-vm-tools into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/open-vm-tools/2:12.1.0-1~ubuntu0.22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in open-vm-tools (Ubuntu Jammy):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-jammy
Bryce Harrington (bryce)
Changed in open-vm-tools (Ubuntu Jammy):
milestone: none → jammy-updates
Bryce Harrington (bryce)
summary: - Backport open-vm-tools as MRE for bionic, focal, impish, jammy (October)
+ Backport open-vm-tools 12.1.0 as MRE for jammy
Revision history for this message
John Wolfe (johnwvmw) wrote :

I have requested the QA team to help with the validation of these open-vm-tools packages from the jammy-proposed repo.

Revision history for this message
vmware-gos-Yuhua (yhzou) wrote :

Sanity check with ubuntu 22.04 live server and desktop images

   1) install / upgrade / remove open-vm-tools from -proposed
   2) Install / upgrade / remove open-vm-tools-desktop (only for ubuntu 22.04 desktop image)
   3) tools service and VGAuth service are running when install / upgrade open-vm-tools
   4) tools service and VGAuth service are running after reboot VM
   5) check guestInfo from vmtools
   6) install/remove optional packages:
         open-vm-tools-sdmp
         open-vm-tools-salt-minion
         open-vm-tools-containerinfo

Output suspicious message as above in terminal when I install/remove optional package open-vm-tools-sdmp/ open-vm-tools-salt-minion/open-vm-tools-containerinfo with command "apt-get install/remove xxxx":
    Unknown option: q
    active

Take "apt-get remove open-vm-tools-containerinfo" as example:
 Reading package lists...
 Building dependency tree...
 Reading state information...
 The following packages were automatically installed and are no longer required:
   libc-ares2 libgrpc++1 libgrpc10
 Use 'apt autoremove' to remove them.
 The following packages will be REMOVED:
   open-vm-tools-containerinfo
 0 upgraded, 0 newly installed, 1 to remove and 249 not upgraded.
 After this operation, 997 kB disk space will be freed.
 (Reading database ...
 (Reading database ... 5%
 (Reading database ... 10%
 (Reading database ... 15%
 (Reading database ... 20%
 (Reading database ... 25%
 (Reading database ... 30%
 (Reading database ... 35%
 (Reading database ... 40%
 (Reading database ... 45%
 (Reading database ... 50%
 (Reading database ... 55%
 (Reading database ... 60%
 (Reading database ... 65%
 (Reading database ... 70%
 (Reading database ... 75%
 (Reading database ... 80%
 (Reading database ... 85%
 (Reading database ... 90%
 (Reading database ... 95%
 (Reading database ... 100%
 (Reading database ... 198508 files and directories currently installed.)
 Removing open-vm-tools-containerinfo (2:12.1.0-1~ubuntu0.22.04.1) ...
 Unknown option: q
 active

Ignore the suspicious output message "Unknown option: q" or not ? Thanks very much.

Best regards
Yuhua Zou

Revision history for this message
Paride Legovini (paride) wrote :

Thanks for doing the verification. Looks like deb-systemd-invoke is being called with the -q flag in the maintainer scripts, but the tool doesn't actually support it. The tools behaves well even with that extra flag (the return codes are the expected ones), but it's not quiet (that's where that "active" string comes from in your log excerpt).

The extra flag has been introduces in Debian in [1], and apparently his issue also affects Debian, but I see no bug report about it. As far as I can tell it's a cosmetic thing, but I won't modify the SRU verification tags for now: I prefer to leave the final word to Bryce.

[1] https://salsa.debian.org/vmware-packaging-team/pkg-open-vm-tools/-/commit/3ece93a147fb6e52517c469e0da27d7f498d1176

Bryce Harrington (bryce)
tags: added: verification-done verification-done-jammy
removed: verification-needed verification-needed-jammy
Revision history for this message
Bryce Harrington (bryce) wrote :

I've filed LP: #1999945 and assigned myself for the -q flag fix. Since the commit that added it was from 2 years ago, this issue's already in the wild. I think we can ignore it for the sake of this SRU. I will be doing another open-vm-tools MRE next month (LP: #1998558) and will include the fix there.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package open-vm-tools - 2:12.1.0-1~ubuntu0.22.04.1

---------------
open-vm-tools (2:12.1.0-1~ubuntu0.22.04.1) jammy; urgency=medium

  * Backport recent open-vm-tools (LP: #1975767)
    - Fixes issue with "udevadm trigger" affecting all devices
      that can cause unwanted side-effects.
      (LP: #1968354)
    - Adds new binary open-vm-tools-containerinfo that installs the
      vRealize Container Info plugin, which captures and publishes
      information about running containers inside the guest.
    - Adds new binary open-vm-tools-salt-minion that installs the Salt
      Minion plugin for event driven IT automation, remote task execution,
      and configuration management.

 -- Bryce Harrington <email address hidden> Mon, 19 Sep 2022 17:52:55 +0000

Changed in open-vm-tools (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for open-vm-tools has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.