[mako] after transitioning to Attached = 0; ofono never transitions back to Attached = 1

root@ubuntu-phablet:/# /usr/share/ofono/scripts/list-modems
[ /ril_0 ]
    Features = sms net gprs sim
    Emergency = 0
    Powered = 1
    Lockdown = 0
    Interfaces = org.ofono.CallVolume org.ofono.MessageManager org.ofono.NetworkRegistration org.ofono.ConnectionManager org.ofono.NetworkTime org.ofono.SimManager org.ofono.VoiceCallManager
    Online = 1
    Model = Fake Modem Model
    Revision = I9250XXLJ1
    Type = hardware
    Serial = 351554052322998
    Manufacturer = Fake Manufacturer
    [ org.ofono.CallVolume ]
        Muted = 1
        SpeakerVolume = 0
        MicrophoneVolume = 0
    [ org.ofono.MessageManager ]
    [ org.ofono.NetworkRegistration ]
        Status = registered
        Strength = 16
        Name = T-Mobile Orange
        LocationAreaCode = 3218
        Mode = auto
        MobileCountryCode = 234
        Technology = umts
        CellId = 210926480
        MobileNetworkCode = 33
    [ org.ofono.ConnectionManager ]
        Attached = 0
        RoamingAllowed = 0
        Powered = 1
    [ org.ofono.NetworkTime ]
    [ org.ofono.SimManager ]
        Retries =
        MobileCountryCode = 234
        FixedDialing = 0
        SubscriberNumbers = 07572378845
        PreferredLanguages = en
        BarredDialing = 0
        CardIdentifier = 8944302031557237537
        LockedPins =
        MobileNetworkCode = 30
        SubscriberIdentity = 234308342877614
        Present = 1
        PinRequired = none
    [ org.ofono.VoiceCallManager ]
        EmergencyNumbers = 112 999 911

root@ubuntu-phablet:/# /usr/share/ofono/scripts/list-contexts
[ /ril_0 ]
    [ /ril_0/context1 ]
        Username = User
        Protocol = ip
        Name = Internet
        Settings = { DomainNameServers=149.254.230.7,149.254.192.126, Method=static Netmask=255.255.255.0 Address=10.151.149.138 Interface=rmnet0 Gateway=10.151.149.1 }
        IPv6.Settings = { }
        Active = 1
        AccessPointName = general.t-mobile.uk
        Password = mms
        Type = internet

Status changed to 'Confirmed' because the bug affects multiple users.

Damn janitor beat me too.

"Confirmed" on build #78 running on mako and using Mathieu's tin-foil technique:

    [ org.ofono.ConnectionManager ]
        Attached = 0
        RoamingAllowed = 0
        Powered = 1
    [ org.ofono.NetworkTime ]
    [ org.ofono.SimManager ]
        Retries =
        MobileCountryCode = 310
        FixedDialing = 0
        SubscriberNumbers =
        PreferredLanguages = en
        BarredDialing = 0
        CardIdentifier = 89014104243154141218
        LockedPins =
        MobileNetworkCode = 410
        SubscriberIdentity = 310410315414121
        Present = 1
        PinRequired = none

# ./list-contexts
[ /ril_0 ]
    [ /ril_0/context1 ]
        Username =
        Protocol = ip
        Name = MEdia Net (phones)
        Settings = { DomainNameServers=172.16.145.103,172.16.145.103, Method=static Netmask=255.255.255.248 Address=10.177.179.187 Interface=rmnet_usb0 Gateway=10.177.179.185 }
        IPv6.Settings = { }
        Active = 1
        AccessPointName = wap.cingular
        Password =
        Type = internet

# netstat -rn
Kernel IP routing table
Destination Gateway Genmask Flags MSS Window irtt Iface
# nmcli c
NAME UUID TYPE TIMESTAMP-REAL
/310410315414121/context1 395588c4-584f-4d8c-e6fa-41c75a326c7d gsm Thu Oct 3 21:17:49 2013
#

Just side note, my first two attempts I wrapped the phone and put it in the oven, and each time I removed it, the phone was off. I'm guessing this was due to critical temp being reached ( note, the oven was off... )? I'll check the logs.

I tested the same scenario with my maguro this morning, and cannot reproduce the same behavior. GPRS seems to re-attach just fine.

I will re-test with tracing enabled to see if I can spot the differences between the two devices.

Seems to me like toggling Mobile data Enable/Disable triggers this bug -- when it gets disabled for more than a few seconds, here my mako does not get back to Attached.

Just confirmed with build #87 that this bug is confined to mako. I'm able to enable/disable mobile data and pass the tinfoil test using maguro.

Tony disabling via setting and re-enabling fails to reconnect for me on maguro :) Maybe you got the one with working 3g ;)

root@ubuntu-phablet:/# /usr/share/ofono/scripts/list-contexts
[ /ril_0 ]
    [ /ril_0/context1 ]
        Username = User
        Protocol = ip
        Name = Internet
        Settings = { }
        IPv6.Settings = { }
        Active = 0
        AccessPointName = general.t-mobile.uk
        Password = mms
        Type = internet

root@ubuntu-phablet:/# /usr/share/ofono/scripts/list-modems
[ /ril_0 ]
    Features = sms net gprs sim
    Emergency = 0
    Powered = 1
    Lockdown = 0
    Interfaces = org.ofono.CallVolume org.ofono.MessageManager org.ofono.NetworkRegistration org.ofono.ConnectionManager org.ofono.NetworkTime org.ofono.VoiceCallManager org.ofono.SimManager
    Online = 1
    Model = Fake Modem Model
    Revision = I9250XXLJ1
    Type = hardware
    Serial = 351554052322998
    Manufacturer = Fake Manufacturer
    [ org.ofono.CallVolume ]
        Muted = 1
        SpeakerVolume = 0
        MicrophoneVolume = 0
    [ org.ofono.MessageManager ]
    [ org.ofono.NetworkRegistration ]
        Status = registered
        Strength = 22
        Name = T-Mobile Orange
        LocationAreaCode = 3218
        Mode = auto
        MobileCountryCode = 234
        Technology = umts
        CellId = 210959600
        MobileNetworkCode = 33
    [ org.ofono.ConnectionManager ]
        Attached = 1
        RoamingAllowed = 0
        Suspended = 0
        Powered = 1
    [ org.ofono.NetworkTime ]
    [ org.ofono.VoiceCallManager ]
        EmergencyNumbers = 112 999 911
    [ org.ofono.SimManager ]
        Retries =
        MobileCountryCode = 234
        FixedDialing = 0
        SubscriberNumbers = 07572378845
        PreferredLanguages = en
        BarredDialing = 0
        CardIdentifier = 8944302031557237537
        LockedPins =
        MobileNetworkCode = 30
        SubscriberIdentity = 234308342877614
        Present = 1
        PinRequired = none

Confirmed the bug again using both scenarios on mako with build #87.

I've been working on a possible fix which so far looks promising on mako ( both scenarios now work ). Tested in conjunction with the new minor version of NetworkManager which is in the queue for upload.

I still need to test on maguro, and also in conjunction with the telepathy-ofono netreg fix ( ie. remove the code in telepathy-ofono which calls the Register method; see bug #1226145 for more details ).

So, while my potential fix makes things better, it still occasionally fails to restore the attach state. Still more work to do...

OK, some good progress to report. I can disable/enable mobile data multiple times in a row on mako and everything works as expected. Likewise with the tin-foil/oven scenario; in fact, the data connection is usually up & running before I can unwrap the phone fully and turn on the screen.

Turns out the problem was that when 'Attach' was toggled either via DBus or via connection loss, the primary data context wasn't being properly cleaned up, so when the re-attach happened, an active context was found, so no action was taken. This was due to
ril_deactivate_data_call_cb() calling set_context_disaconnected(gcd), before it called ofono_gprs_context_deactivated(), which takes gcd->active_ctx_cid as a parameter. As set_context_disconnected() sets active_ctx_cid to -1, the correct context is never cleared in the core gprs code.

I'll work on cleaning up the patch and create a pull request for the fix.

Here's test package with the fix.

...and the -dbg package.

Here's the corresponding branch on github:

https://github.com/tonyespy/ofono/tree/gprs-lp1234434

I'll create a pull request tomorrow, as I have more testing to do on maguro.

Any feedback on the test package would be most appreciated as well!

Tony.

Maguro still isn't recovering from switching off 3g in setting and switching it back on again.

Other than that it's run all morning with no obvious issues for me

@Dave

What build are you running? Also can you double-check that you installed the right package? I'll also double-check that I uploaded the right package as well.

I just installed on a fresh instance of build #87 ( non-MIR ) and I'm able to disable / re-enable Cellular Data with no issues after more then 10 attempts.

Also, as mentioned above, maguro seemed to work OK prior to my fix. Did it work for you before you installed the package?

Once you've verified everything, would you mind attaching your syslog if it's still not working for you?

Just re-installed the package attached to the bug, and also installed Mathieu's NM test packages ( new minor version of NM ).

No issues at all disabling and re-enabling cellular data on maguro... works like a charm for me. I will try the tin-foil test next.

I'm running a fresh build of 91 (mir enabled by default)

root@ubuntu-phablet:/# dpkg -l | grep ofono
ii libofono-qt1 1.5+git20120419+bcf0c04-0ubuntu1 armhf Qt oFono library
ii ofono 1.12+bzr-0ubuntu1~awe2 armhf Mobile telephony stack (daemon)
ii ofono-dbg 1.12+bzr-0ubuntu1~awe2 armhf Mobile telephony stack (debugging files)
ii ofono-scripts 1.12+bzr6836-0ubuntu1 all Mobile telephony stack (test and maintenance script files)
ii telepathy-ofono 0.2+13.10.20131008.2-0ubuntu1 armhf telepathy oFono connection manager

That's the right packages yes?

In the meantime I'll reflash is cyphermox's nm update in the usual place? I'll install everything fresh, just do the cellular up down test and then add my syslog, if it fails to reconnect, so it is fairly compact for you currently it is huge lots of different tests this morning.

davmor2@boromir:~$ adb shell /usr/share/ofono/scripts/list-modems
[ /ril_0 ]
    Features = sms net gprs sim
    Emergency = 0
    Powered = 1
    Lockdown = 0
    Interfaces = org.ofono.CallVolume org.ofono.MessageManager org.ofono.NetworkRegistration org.ofono.ConnectionManager org.ofono.NetworkTime org.ofono.VoiceCallManager org.ofono.SimManager
    Online = 1
    Model = Fake Modem Model
    Revision = I9250XXLJ1
    Type = hardware
    Serial = 351554052322998
    Manufacturer = Fake Manufacturer
    [ org.ofono.CallVolume ]
        Muted = 1
        SpeakerVolume = 0
        MicrophoneVolume = 0
    [ org.ofono.MessageManager ]
    [ org.ofono.NetworkRegistration ]
        Status = registered
        Strength = 16
        Name = T-Mobile Orange
        LocationAreaCode = 3218
        Mode = auto
        MobileCountryCode = 234
        Technology = umts
        CellId = 210924067
        MobileNetworkCode = 33
    [ org.ofono.ConnectionManager ]
        Attached = 1
        RoamingAllowed = 0
        Suspended = 0
        Powered = 1
    [ org.ofono.NetworkTime ]
    [ org.ofono.VoiceCallManager ]
        EmergencyNumbers = 112 999 911
    [ org.ofono.SimManager ]
        Retries =
        MobileCountryCode = 234
        FixedDialing = 0
        SubscriberNumbers = 07572378845
        PreferredLanguages = en
        BarredDialing = 0
        CardIdentifier = 8944302031557237537
        LockedPins =
        MobileNetworkCode = 30
        SubscriberIdentity = 234308342877614
        Present = 1
        PinRequired = none

davmor2@boromir:~$ adb shell /usr/share/ofono/scripts/list-contexts
[ /ril_0 ]
    [ /ril_0/context1 ]
        Username = User
        Protocol = ip
        Name = Internet
        Settings = { }
        IPv6.Settings = { }
        Active = 0
        AccessPointName = general.t-mobile.uk
        Password = mms
        Type = internet

This bug was fixed in the package ofono - 1.12+bzr6839-0ubuntu1

---------------
ofono (1.12+bzr6839-0ubuntu1) saucy; urgency=low

  [ Tony Espy ]
  * rilmodem: Fix GPRS attach/detach logic (LP: #1234434)
 -- Ricardo Salveti de Araujo <email address hidden> Wed, 16 Oct 2013 11:30:48 -0300

This bug was fixed in the package network-manager - 0.9.8.4-0ubuntu3

---------------
network-manager (0.9.8.4-0ubuntu3) trusty; urgency=low

  * Set "allow-stderr" for debian/tests/apparmor_workaround to avoid failure
    on AppArmor warnings.
 -- Martin Pitt <email address hidden> Tue, 05 Nov 2013 09:48:28 +0100