Context is opened twice when receiving an MMS
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
nuntium (Ubuntu) |
Fix Released
|
Undecided
|
Alfonso Sanchez-Beato |
Bug Description
IP context is opened twice when receiving an MMS. This slows down reception of MMS when there are a few pending, and can potentially cause issues (for instance the second opening might fail).
The sequence is:
1. nuntium opens a context after receiving the SMS push notification
2. it sends an HTTP GET and receives the MMS (m-retrieve.conf)
3. it closes the context
4. it almost immediately tries to open the context again. This takes more time than usual because the network is still closing it and it might be the cause for some failures when opening a context that have been seen when trying to receive an MMS.
5. it sends a m-notifiresp.ind to notify the network that we have received an MMS
6. it closes the second context
As we are using immediate mode, we must send m-notifiresp.ind right after having received the MMS, so it makes no sense to close and re-open the context.
Related branches
- Manuel de la Peña (community): Approve
-
Diff: 430 lines (+156/-63)6 files modifiedcmd/nuntium/mediator.go (+31/-23)
debian/changelog (+9/-0)
mms/decoder.go (+72/-37)
mms/mms.go (+1/-0)
ofono/modem.go (+19/-3)
ofono/push_decode_test.go (+24/-0)
Fixed in
https:/ /github. com/ubuntu- phonedations/ nuntium/ pull/22