Wrong image size using rbd backend for libvirt

Fix proposed to branch: master
Review: https://review.openstack.org/44640

Reviewed: https://review.openstack.org/44640
Committed: http://github.com/openstack/nova/commit/1b66a47b5f4cbcdf1a9a1ec38532474588a3fee2
Submitter: Jenkins
Branch: master

commit 1b66a47b5f4cbcdf1a9a1ec38532474588a3fee2
Author: Haomai Wang <email address hidden>
Date: Mon Sep 2 15:25:51 2013 +0800

    Fix incorrect root partition size and compatible volume name

    When using rbd backend, it needs to resize volume size if size presents. Else
    we will get wrong image size.

    Rbd volume always uses uuid as the main pattern of volume name, now change to
    it is necessary.

    Fix bug 1219658

    Change-Id: I3dc8d639b066eac35d190b8d4687c41c9f4d5824

Images seem to be 1024 larger than expected.

For example:

# rbd -p images info ae9d23f0-b5a0-4d92-a15d-b3f23d276c72_disk rbd image 'ae9d23f0-b5a0-4d92-a15d-b3f23d276c72_disk':
        size 20480 GB in 5242880 objects
        order 22 (4096 kB objects)
        block_name_prefix: rbd_data.1cac92ae8944a
        format: 2
        features: layering

when the expect size should be 20 GB.

Versions: ceph v0.72.2, nova 2014.1-git201312190904-trusty

Fix for the out by a factor of 1024 issue is at https://review.openstack.org/#/c/81974/

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/87455

I also affact by this bug. What's the status of this bug now?

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/98753

Fix proposed to branch: master
Review: https://review.openstack.org/92512/

FYI, we'll include this fix in the impending "2014.1.1" RDO packages

Here goes my SRU proposal:

nova (1:2014.1.1-0ubuntu2) trusty; urgency=high

  * Cherry picked two fixes from upstream.
    - [2cebfd2] libvirt: convert cpu features attribute from list to a set (LP: #1267191)
    - [b86a0e5] Fixes rdb backend image size (LP: #1219658)

I've created a hotfix from 1:2014.1.1-0ubuntu1 (already in -proposed) for some other uses.

Since I'm creating 1 fix for 2 bugs, please take a look at url bellow for the other bug as well.

https://bugs.launchpad.net/nova/+bug/1267191

Attaching debdiff.

Rafael, this needs to have an SRU testcase as in:

https://wiki.ubuntu.com/StableReleaseUpdates

chuck

Hello Haomai, or anyone else affected,

Accepted nova into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/nova/1:2014.1.1-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed this to verification-done because since this SRU proposal this has been running in a big server farm without any issues or regressions.

The verification of the Stable Release Update for nova has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package nova - 1:2014.1.1-0ubuntu2

---------------
nova (1:2014.1.1-0ubuntu2) trusty; urgency=high

  * Cherry picked two fixes from upstream.
    - [2cebfd2] libvirt: convert cpu features attribute from list to a set (LP: #1267191)
    - [b86a0e5] Fixes rdb backend image size (LP: #1219658)
 -- Rafael David Tinoco <email address hidden> Wed, 25 Jun 2014 12:56:15 -0300