| 2012-04-27 18:35:53 |
Mathieu Trudel-Lapierre |
bug |
|
|
added bug |
| 2012-04-27 19:40:55 |
Mathieu Trudel-Lapierre |
description |
The use_tempaddr sysctl defaults to 0 in NetworkManager if it's not set elsewhere, such as it is the case for the default NM-created, automatic wired connection. That connection is never "completed" (because it's internal magic), and nm_backend_ipv6_use_tempaddr() doesn't have a chance of returning a valid system-wide default value since the function it calls, nm_generic_ipv6_use_tempaddr() only checks in /etc/sysctl.conf and /lib/sysctl.d/sysctl.conf for a system default value.
(Regardless, this wouldn't work since we generate a setting based on a number of files in /etc/sysctl.d)
Change the behavior slightly to default to a string of -1 as a default value in nm-system.c; then make sure that if that value is never changed by the result of nm_backend_ipv6_use_tempaddr(), we just don't touch that sysctl at all. |
[Impact]
Only affects IPv6 connections, but we established that the default should be to maintain our users' privacy on IPv6 connections; we want all IPv6 external connections to be established using temporary, dynamic addresses.
[Development Fix]
Very minor patch to threat an unknown value (-1) as (2), aka, enabling and preferring privacy extensions. Patch is attached.
[Stable Fix]
See "Development fix".
[Test case]
Connect a wire to your system. With NetworkManager running, the value returned by 'sysctl net.ipv6.conf.eth0.use_tempaddr' should be 2 at all times unless configured otherwise (though the default is set to 2 by default). Without the patch, the value is reset to 0 when NetworkManager is running, and correctly set to 2 when NetworkManager is stopped (since it reverts the value to the value when NM started).
[Regression Potential]
Low, impact may be failing connections in case of issues with the privacy extensions system in the Linux kernel.
----
The use_tempaddr sysctl defaults to 0 in NetworkManager if it's not set elsewhere, such as it is the case for the default NM-created, automatic wired connection. That connection is never "completed" (because it's internal magic), and nm_backend_ipv6_use_tempaddr() doesn't have a chance of returning a valid system-wide default value since the function it calls, nm_generic_ipv6_use_tempaddr() only checks in /etc/sysctl.conf and /lib/sysctl.d/sysctl.conf for a system default value.
(Regardless, this wouldn't work since we generate a setting based on a number of files in /etc/sysctl.d)
Change the behavior slightly to default to a string of -1 as a default value in nm-system.c; then make sure that if that value is never changed by the result of nm_backend_ipv6_use_tempaddr(), we just don't touch that sysctl at all. |
|
| 2012-04-27 19:40:58 |
Mathieu Trudel-Lapierre |
network-manager (Ubuntu): status |
New |
In Progress |
|
| 2012-04-27 19:41:00 |
Mathieu Trudel-Lapierre |
network-manager (Ubuntu): importance |
Undecided |
Medium |
|
| 2012-04-27 19:41:02 |
Mathieu Trudel-Lapierre |
network-manager (Ubuntu): assignee |
|
Mathieu Trudel-Lapierre (mathieu-tl) |
|
| 2012-04-27 19:42:13 |
Mathieu Trudel-Lapierre |
attachment added |
|
lp990011_use_tempaddr_sysctl_default.patch https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/990011/+attachment/3110078/+files/lp990011_use_tempaddr_sysctl_default.patch |
|
| 2012-04-27 20:23:08 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2012-04-27 22:00:25 |
Mathieu Trudel-Lapierre |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2012-05-02 08:39:03 |
Martin Pitt |
nominated for series |
|
Ubuntu Precise |
|
| 2012-05-02 08:39:03 |
Martin Pitt |
bug task added |
|
network-manager (Ubuntu Precise) |
|
| 2012-05-02 08:39:44 |
Martin Pitt |
network-manager (Ubuntu Precise): status |
New |
Fix Committed |
|
| 2012-05-02 08:39:46 |
Martin Pitt |
bug |
|
|
added subscriber SRU Verification |
| 2012-05-02 08:39:48 |
Martin Pitt |
tags |
patch |
patch verification-needed |
|
| 2012-05-04 22:03:35 |
Mathieu Trudel-Lapierre |
tags |
patch verification-needed |
patch verification-done |
|
| 2012-05-10 23:59:09 |
Launchpad Janitor |
network-manager (Ubuntu): status |
In Progress |
Fix Released |
|
| 2012-05-11 00:01:09 |
Launchpad Janitor |
network-manager (Ubuntu Precise): status |
Fix Committed |
Fix Released |
|
| 2012-05-11 19:08:37 |
Jeroen Dekkers |
bug |
|
|
added subscriber Jeroen Dekkers |
| 2012-05-14 18:51:56 |
Andy |
bug |
|
|
added subscriber Andy |
| 2012-05-17 13:56:29 |
Launchpad Janitor |
branch linked |
|
lp:~network-manager/network-manager/ubuntu |
|
