optimize ofono context property-changed logic

Bug #1441623 reported by Tony Espy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
network-manager (Ubuntu)
New
High
Tony Espy

Bug Description

This bug is bring reported as of network-manager version 0.9.10.0-4ubuntu13 ( latest in vivid at bug filing time ).

The code in src/devices/wwan/nm-modem-ofono.c which handles context property_change signals should be optimized.

The function context_properties_changed() watches for key == 'Settings', and then calls ofono_context_get_ip_properties(). This function then calls dbus_g_proxy_call_with_timeout() to invoke the 'GetProperties' method of the context interface. This is a synchronous DBus call which really isn't necessary as the payload for the 'PropertyChanged' signal already contained the required data ( ie. the IP settings ).

Tony Espy (awe)
Changed in network-manager (Ubuntu):
assignee: nobody → Tony Espy (awe)
importance: Undecided → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.