Include upstream patch for the ifupdown plugin to honor the source stanza

Bug #1271567 reported by Michael Schaller
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
network-manager (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Hi everyone,

Since Debian 7 (Wheezy) / Ubuntu 11.04 (Natty Narwhal) ifupdown supports the source stanza to source in other configuration files from /etc/network/interfaces.

Upstream the Network Manager ifupdown plugin has been patched to honor the source stanza:
https://bugzilla.gnome.org/show_bug.cgi?id=707276

Can we please integrate this upstream patch into Trusty?
I've backported the two upstream patches, merged them, tested them against 0.9.8.4-0ubuntu3 and attached the patch to this bug.

Best,

Michael Schaller

Tags: trusty
Revision history for this message
Michael Schaller (misch-9) wrote :

Subscribed sponsors. Please let me know if there are any questions.

Revision history for this message
Michael Schaller (misch-9) wrote :
Revision history for this message
Michael Schaller (misch-9) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package network-manager - 0.9.8.8-0ubuntu1

---------------
network-manager (0.9.8.8-0ubuntu1) trusty; urgency=medium

  [ Mathieu Trudel-Lapierre ]
  * New upstream release (LP: #1269179).
  * debian/control: add a Build-Depends on libmm-glib-dev.
  * debian/rules: configure with --with-modem-manager-1=yes. This enables
    support for the new ModemManager API.
  * Dropped patches (included upstream):
    - git_core_do_not_call_functions_with_null_connection_5e129f1.patch
    - bluetooth.patch
  * debian/patches/lp912702_fix_multiple_dialogs.patch: handle the case where
    multiple authentication dialogs would be shown if the user doesn't respond
    in time for network auth. (LP: #912702)

  [ Michael Schaller ]
  * ifupdown plugin: Support ifupdown's source stanza. (LP: #1271567)
 -- Mathieu Trudel-Lapierre <email address hidden> Fri, 24 Jan 2014 12:35:34 -0500

Changed in network-manager (Ubuntu):
status: New → Fix Released
Revision history for this message
Michael Schaller (misch-9) wrote :

Works like a charm. Thanks for integrating the patch.

Manual test:
$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=14.04
DISTRIB_CODENAME=trusty
DISTRIB_DESCRIPTION="Ubuntu Trusty Tahr (development branch)"

$ cat /etc/network/interfaces
source /etc/network/interfaces.d/*

$ cat /etc/network/interfaces.d/loopback.conf
auto lo
iface lo inet loopback

$ cat /etc/network/interfaces.d/primary.conf
auto eth0
iface eth0 inet dhcp
iface eth0 inet6 auto

$ nmcli dev
DEVICE TYPE STATE
eth0 802-3-ethernet unmanaged
eth1 802-3-ethernet connected

$ grep NetworkManager /var/log/syslog
...
Jan 27 09:15:48 test NetworkManager[1091]: interface-parser: parsing file /etc/network/interfaces
Jan 27 09:15:48 test NetworkManager[1091]: interface-parser: source line includes interfaces file(s) /etc/network/interfaces.d/*
Jan 27 09:15:48 test NetworkManager[1091]: interface-parser: parsing file /etc/network/interfaces.d/loopback.conf
Jan 27 09:15:48 test NetworkManager[1091]: interface-parser: finished parsing file /etc/network/interfaces.d/loopback.conf
Jan 27 09:15:48 test NetworkManager[1091]: interface-parser: parsing file /etc/network/interfaces.d/primary.conf
Jan 27 09:15:48 test NetworkManager[1091]: interface-parser: finished parsing file /etc/network/interfaces.d/primary.conf
Jan 27 09:15:48 test NetworkManager[1091]: interface-parser: finished parsing file /etc/network/interfaces
...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.