Public key's random art is not displayed correctly

Bug #1664934 reported by Lilian Besson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
network-manager-openconnect
Unknown
Unknown
network-manager-openconnect (Ubuntu)
New
Undecided
Unassigned

Bug Description

Hi,

That's not a serious bug, but still...

When connecting for the first time to a new VPN network, the "Public key's random art" is displayed at the end of the window asking to confirm the identity of the network.
This ASCII random art of the public key should be rendered with a monospace font, to be well aligned, but it's not the case.

Here is an example: http://www.zimagez.com/zimage/publickeyrandomartasciibug.php

I think it would be very easy to fix, and quite nice to have the ASCII art public key rendered correctly.
Thanks in advance!

ProblemType: Bug
DistroRelease: Ubuntu 15.10
Package: network-manager-openconnect 1.0.2-1build1
ProcVersionSignature: Ubuntu 3.8.0-19.30-generic 3.8.8
Uname: Linux 3.8.0-19-generic x86_64
ApportVersion: 2.19.1-0ubuntu5
Architecture: amd64
CurrentDesktop: XFCE
Date: Wed Feb 15 11:38:58 2017
EcryptfsInUse: Yes
InstallationDate: Installed on 2014-04-18 (1034 days ago)
InstallationMedia: Ubuntu 13.04 "Raring Ringtail" - Release amd64 (20130424)
SourcePackage: network-manager-openconnect
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Lilian Besson (lbesson) wrote :
Revision history for this message
Mike Miller (mtmiller) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better. Since this change would best be made upstream by the NetworkManager developers, it would be helpful if you could report this wishlist bug on the upstream bug tracker. Can you file a bug at https://bugzilla.gnome.org/enter_bug.cgi?product=NetworkManager&component=VPN:%20openconnect and paste a link to the report back here?

Revision history for this message
dwmw2 (dwmw2) wrote :

I think this is already fixed as part of https://bugzilla.gnome.org/show_bug.cgi?id=770880 isn't it?

Revision history for this message
Lilian Besson (lbesson) wrote :

Hi, thanks for your quick feedback.

Before reporting the same bug elsewhere, maybe it's better to be sure what software is responsible.
I found the same "Public key's random art" piece for instance in gnuTLS code: https://github.com/gnutls/gnutls/blob/master/src/certtool-common.c#L1220

For this NetworkManager plugin, I don't know if the error comes from a GcrCertificateWidget (https://developer.gnome.org/gcr/stable/GcrCertificateWidget.html) or a GcrKeyWidget (https://developer.gnome.org/gcr/stable/GcrKeyWidget.html), as it concerns a certificate but prints its public key (ascii art).

I got lost trying to find the responsible file / line from https://github.com/GNOME/gcr/blob/master/ui/ gcr-certificate-* or grc-key-*...

Revision history for this message
Mike Miller (mtmiller) wrote :

Yes, thanks, it looks like the GcrCertificateWidget displays the certificate details in a fixed width font so it's taken care of there. So this will be fixed with a future release.

Revision history for this message
Lilian Besson (lbesson) wrote :

OK. But should we report the bug somewhere else?

Revision history for this message
Mike Miller (mtmiller) wrote :

lbesson - no need to report this elsewhere. As dwmw2 pointed out, this has been fixed upstream, this bug will be marked resolved when the next release containing the fix is packaged.

Revision history for this message
Lilian Besson (lbesson) wrote :

OK.
We will have to trust @dwmw2, as I wasn't able to check that the bugfixes (s)he linked to were correcting this bug (wrongly displayed "Public key's random art").

In both https://bugzilla.gnome.org/attachment.cgi?id=337825 and https://bugzilla.gnome.org/attachment.cgi?id=337826, I don't see anything related to the random art.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.