Text of the buttons change, resizes buttons

Bug #721303 reported by Olivier Tilloy
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Network Manager Applet
Fix Released
Medium
network-manager-applet (Ubuntu)
Triaged
Medium
Unassigned

Bug Description

This issue can be observed in Lucid, Maverick, and is also present in the trunk of network-manager-applet.

The text of some buttons in the UI of nm-connection-editor changes based on whether the action requires authentication via policyKit. This includes the "Edit" and "Delete" buttons, and the "Apply" button in the connection editor dialog. Whenever authentication is required, their text is appended an ellipsis ("..."). This results in an ugly visual effect: the button is resized to fit the text, and this affects the layout of the window.

I’m not sure why this was designed like this in the first place, but to me the additional ellipsis doesn’t convey any useful information that authentication is required. The stock icon, if displayed, plays this role well already.

Tags: patch
Revision history for this message
Olivier Tilloy (osomon) wrote :

Note: in the version in Maverick, the text of the button to save changes to a connection in the connection editor dialog is "Apply", whereas in the trunk (git://git.gnome.org/network-manager-applet) it has been changed to "Save". Still, the same issue is there.

Revision history for this message
Olivier Tilloy (osomon) wrote :

I’m attaching a patch against the development version for natty (lp:ubuntu/network-manager-applet). The same patch should also apply to the trunk of network-manager-applet.

Revision history for this message
Olivier Tilloy (osomon) wrote :
Changed in network-manager-applet:
importance: Undecided → Unknown
status: New → Unknown
Changed in network-manager-applet:
importance: Unknown → Medium
status: Unknown → New
tags: added: patch
Changed in network-manager-applet:
status: New → Incomplete
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Setting to Triaged, since once the patch is accepted upstream (or updated, see my comment on the upstream tracker; or if we decide to distro-patch nm-applet), the course would be clear and involve applying the patch to the package in Natty.

Changed in network-manager-applet (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Changed in network-manager-applet:
status: Incomplete → New
Changed in network-manager-applet:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.