Shrinks desktop background

Bug #283374 reported by James Westby
2
Affects Status Importance Assigned to Milestone
Ubuntu Netbook Remix Launcher
Won't Fix
Medium
Neil J. Patel
netbook-launcher (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: netbook-launcher

Hi,

I've a small bug I've seen on a couple of machines now.

When I start netbook-launcher it shrinks the desktop background.
I can reproduce this also after killing and restarting the launcher.
The background returns to normal when the launcher is killed.

What appears to happen is that the desktop is squashed, so it still
has it's full height, but less width, leaving black bars at either side of
the screen. The launcher it's is ok, and e.g. the panel is not
affected.

I didn't use to see this with ume-launcher.

Thanks,

James

Revision history for this message
James Westby (james-w) wrote :

Oh, and I'm running Intrepid of course.

Thanks,

James

Revision history for this message
James Westby (james-w) wrote :

Hi,

I've looked in to this a bit, and I can say that this is a difference in
the interpretation of the "picture_options" for the background. I have
"zoom" set, and this covers the screen with the normal GNOME
components, but not with netbook-launcher.

<dobey> james_w: zoom is scale up and crop such that the smaller of w/h is the ratio used
<james_w> so it scales keeping the aspect ratio, and then crops the left over bit off?
<james_w> whereas "stretched" would not respect the aspect ratio?
<james_w> so what does that make "scaled"?
<dobey> yes
<dobey> scaled scales but doesn't exceed the size of the screen
<dobey> the extra area is filled with the color settings

so netbook-launcher appears to be doing "scaled" for "zoom". The
code is

  else if (strcmp (priv->option, "scaled") == 0)
  {
    load_scaled (priv->filename, priv->texture);
  }
  else if (strcmp (priv->option, "zoom") == 0)
  {
    load_scaled (priv->filename, priv->texture);
  }

which seems to confirm that.

libgnome-desktop/gnome-bg.c is where it is implemented. It has
get_scaled_pixbuf which may be useful.

Thanks,

James

Thanks,

James

Changed in netbook-launcher:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
James Westby (james-w) wrote :

Hi,

My branch at

  lp:~james-w/netbook-remix-launcher/fix-background-scaling

which is attached to this report solves this issue, along with a few
other small thing (run without being installed so it can't find its
images and you'll see why I fixed them).

Thanks,

James

Revision history for this message
Neil J. Patel (njpatel) wrote :

Thanks James, branch merged and netbook-launcher_1.4.0 contains the fixes. ume-launcher_0.6.7 also contains the background fixes.

Changed in netbook-remix-launcher:
assignee: nobody → njpatel
status: New → Fix Committed
Bill Filler (bfiller)
Changed in netbook-remix-launcher:
importance: Undecided → Medium
milestone: none → 1.2.0
Neil J. Patel (njpatel)
Changed in netbook-launcher:
status: Triaged → Fix Released
Revision history for this message
Paul Larson (pwlars) wrote :

This bug has been moved to Ubuntu distribution

Changed in netbook-remix-launcher:
status: Fix Committed → Won't Fix
tags: added: ubuntu-unr
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.