fix up usage of XDG_CURRENT_DESKTOP
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
GLib |
Expired
|
Medium
|
|||
Python XDG App |
Confirmed
|
Undecided
|
Unassigned | ||
empathy (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
eog (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
gnome-control-center (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
indicator-bluetooth (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
nautilus (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
totem (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
unity-control-center (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
unity-settings-daemon (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
yelp (Ubuntu) |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Since being standardised XDG_CURRENT_DESKTOP supports specifying multiple Desktop Names seperated by a colon, however many of the patches in Ubuntu pre-date this change so don't correctly support the current format in some cases.
These days XDG_CURRENT_DESKTOP will look something like
Unity
GNOME (gnome-shell)
GNOME-Classic:GNOME (gnome-shell classic mode)
GNOME-Flashback
Many of the patches only check for == "Unity" or == "GNOME", so misbehave for the latter cases in the list above.
I suspect this will be more widespread than just nautilus, but fixing that would be a good start. Since most of this code is still Ubuntu specific (upstream mainly use XDG_CURRENT_DESKTOP for onlyShowIn etc), probably taking the last value in the string would get the desired result of Unity vs GNOME3 behaviour
ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: nautilus 1:3.18.
ProcVersionSign
Uname: Linux 4.4.0-8-generic x86_64
ApportVersion: 2.20-0ubuntu3
Architecture: amd64
CurrentDesktop: GNOME
Date: Wed Mar 9 15:04:36 2016
SourcePackage: nautilus
UpgradeStatus: Upgraded to xenial on 2015-11-28 (102 days ago)
Related branches
- Iain Lane (community): Approve
- unity-api-1-bot: Approve (continuous-integration)
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 29 lines (+14/-1)1 file modifiedsrc/desktop.vala (+14/-1)
- Iain Lane (community): Approve
-
Diff: 297 lines (+21/-152)5 files modifiedpanels/display/cc-display-panel.c (+15/-95)
panels/region/cc-region-panel.c (+2/-21)
panels/region/gnome-region-panel-input.c (+0/-9)
panels/universal-access/cc-ua-panel.c (+4/-26)
shell/control-center.c (+0/-1)
- Iain Lane (community): Approve
-
Diff: 42 lines (+24/-1)1 file modifiedplugins/keyboard/gsd-keyboard-manager.c (+24/-1)
Changed in unity-control-center (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in nautilus (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in gtk+ (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in glib: | |
importance: | Unknown → Medium |
status: | Unknown → Confirmed |
Changed in gtk+ (Ubuntu): | |
status: | Triaged → Fix Committed |
Changed in totem (Ubuntu): | |
importance: | Undecided → Medium |
Changed in yelp (Ubuntu): | |
importance: | Undecided → Medium |
Changed in totem (Ubuntu): | |
status: | New → In Progress |
Changed in empathy (Ubuntu): | |
status: | New → Triaged |
Changed in gnome-control-center (Ubuntu): | |
importance: | Undecided → Medium |
Changed in eog (Ubuntu): | |
importance: | Undecided → Medium |
Changed in empathy (Ubuntu): | |
importance: | Undecided → Medium |
Changed in totem (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in empathy (Ubuntu): | |
status: | Triaged → In Progress |
Changed in empathy (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in dropbox (Ubuntu): | |
status: | New → Confirmed |
Changed in pyxdg (Ubuntu): | |
status: | New → Confirmed |
Changed in syncthing-gtk (Ubuntu): | |
status: | New → Confirmed |
Changed in unity-settings-daemon (Ubuntu): | |
importance: | Undecided → Medium |
Changed in dropbox (Ubuntu): | |
importance: | Undecided → Medium |
Changed in pyxdg (Ubuntu): | |
importance: | Undecided → Medium |
no longer affects: | syncthing-gtk (Ubuntu) |
affects: | gtk+ (Ubuntu) → ubuntu |
Changed in python-xdgapp: | |
status: | New → Confirmed |
no longer affects: | dropbox (Ubuntu) |
no longer affects: | ubuntu |
Changed in indicator-bluetooth (Ubuntu): | |
importance: | Undecided → Medium |
status: | New → Fix Committed |
Changed in nautilus (Ubuntu): | |
status: | Triaged → Fix Released |
Changed in unity-settings-daemon (Ubuntu): | |
status: | Confirmed → Fix Committed |
Changed in glib: | |
status: | Confirmed → Expired |
GTK+: message- dialog- restore- traditional- look-on- unity.patch, unity_rbga_ tooltips. patch.