[enhancement] Internationalization (i18n) and localization (l10n) of error messages
Bug #1431190 reported by
Daniel van Vugt
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Triaged
|
Medium
|
Unassigned | ||
| mir (Ubuntu) |
Triaged
|
Medium
|
Unassigned | ||
Bug Description
Mir's error messages from protocol responses are hard-coded by the server. This has two problems:
1. Languages other than English are not supported.
2. The locale of the client process is ignored.
Mir's protocol should be modified to return generic error codes which can then be converted to strings in the client process's current language. Like errno and strerror() do.
Related branches
lp://staging/~raof/mir/error-callback-for-display-config
- Mir CI Bot: Approve (continuous-integration)
- Daniel van Vugt: Abstain
- Alan Griffiths: Approve
- Brandon Schaefer (community): Approve
- Cemil Azizoglu (community): Approve
- Kevin DuBois (community): Approve
-
Diff: 920 lines (+482/-11)23 files modifiedinclude/client/mir_toolkit/client_types.h (+32/-0)
include/client/mir_toolkit/mir_client_library.h (+1/-0)
include/client/mir_toolkit/mir_connection.h (+11/-0)
include/client/mir_toolkit/mir_error.h (+55/-0)
src/client/CMakeLists.txt (+4/-0)
src/client/mir_connection.cpp (+36/-2)
src/client/mir_connection.h (+4/-0)
src/client/mir_connection_api.cpp (+18/-0)
src/client/mir_error.cpp (+35/-0)
src/client/mir_error.h (+37/-0)
src/client/mir_error_api.cpp (+30/-0)
src/client/symbols.map (+3/-0)
src/include/common/mir/client_visible_error.h (+55/-0)
src/include/server/mir/frontend/template_protobuf_message_processor.h (+11/-0)
src/protobuf/mir_protobuf.proto (+21/-0)
src/protobuf/symbols.map (+1/-0)
src/server/frontend/authorizing_display_changer.cpp (+23/-1)
src/server/frontend/protobuf_message_processor.cpp (+7/-0)
tests/acceptance-tests/test_new_display_configuration.cpp (+41/-0)
tests/integration-tests/test_protobuf.cpp (+7/-7)
tests/integration-tests/test_protobuf.proto (+7/-1)
tests/unit-tests/client/CMakeLists.txt (+1/-0)
tests/unit-tests/client/test_client_mir_error.cpp (+42/-0)
Revision history for this message
| Mir CI Bot (mir-ci-bot) wrote | #1 |
| Changed in mir: | |
| status: | Triaged → Fix Committed |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #2 |
| Changed in mir: | |
| status: | Fix Committed → Triaged |
Revision history for this message
| Michał Sawicz (saviq) wrote | #3 |
| Changed in mir (Ubuntu): | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
To post a comment you must log in.
Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.22.0