When switching to 2-column landscape mode, current conversations are closed

Bug #1599184 reported by Tim Peeters
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Bill Filler
messaging-app (Ubuntu)
Fix Released
High
Gustavo Pichorim Boiko
ubuntu-ui-toolkit (Ubuntu)
Invalid
High
Unassigned

Bug Description

messaging-app.qml has the following code:

        onColumnsChanged: {
            // we only have things to do here in case no thread is selected
            if (layout.columns == 2 && !application.findMessagingChild("emptyStatePage") && !application.findMessagingChild("fakeItem")) {
                layout.removePage(mainPage)
                emptyStack()
            }
        }

This causes the current conversation to be closed when the user rotates the phone (on a large-enough screen to go to two-column mode), and that can be very annoying. The APL can already take care of moving pages to the correct column and correct place in the stack when needed, so this code should be removed. Also note that emptyStack() will again call layout.removePage(mainPage).

Related branches

Tim Peeters (tpeeters)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in messaging-app (Ubuntu):
status: New → Confirmed
Bill Filler (bfiller)
Changed in messaging-app (Ubuntu):
importance: Undecided → High
Changed in ubuntu-ui-toolkit (Ubuntu):
importance: Undecided → High
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

After some discussion we decided not to use the bottom edge animation when in two columns mode, so this problem is not going to happen anymore.

At some point the SDK might need to have animated transitions in APL and PageStack, but that's out of scope for this bug, so I'll mark as Invalid for SDK.

Changed in messaging-app (Ubuntu):
assignee: nobody → Gustavo Pichorim Boiko (boiko)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Invalid
Changed in canonical-devices-system-image:
importance: Undecided → High
status: New → Fix Committed
assignee: nobody → Bill Filler (bfiller)
milestone: none → 13
Changed in messaging-app (Ubuntu):
status: Confirmed → Fix Committed
status: Fix Committed → Fix Released
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.