When switching to 2-column landscape mode, current conversations are closed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Bill Filler | ||
messaging-app (Ubuntu) |
Fix Released
|
High
|
Gustavo Pichorim Boiko | ||
ubuntu-ui-toolkit (Ubuntu) |
Invalid
|
High
|
Unassigned |
Bug Description
messaging-app.qml has the following code:
// we only have things to do here in case no thread is selected
if (layout.columns == 2 && !application.
}
}
This causes the current conversation to be closed when the user rotates the phone (on a large-enough screen to go to two-column mode), and that can be very annoying. The APL can already take care of moving pages to the correct column and correct place in the stack when needed, so this code should be removed. Also note that emptyStack() will again call layout.
Related branches
- Tiago Salem Herrmann (community): Approve
- system-apps-ci-bot: Approve (continuous-integration)
-
Diff: 815 lines (+106/-341)15 files modifieddebian/rules (+1/-1)
src/messagingapplication.cpp (+36/-1)
src/messagingapplication.h (+1/-0)
src/qml/InputInfo.qml (+0/-42)
src/qml/MMSDelegate.qml (+2/-3)
src/qml/MainPage.qml (+7/-13)
src/qml/Messages.qml (+15/-73)
src/qml/MessagesListView.qml (+1/-2)
src/qml/MessagingBottomEdge.qml (+7/-42)
src/qml/SMSDelegate.qml (+1/-2)
src/qml/SettingsPage.qml (+1/-15)
src/qml/messaging-app.qml (+25/-139)
tests/qml/tst_DualSim.qml (+4/-4)
tests/qml/tst_MMSDelegate.qml (+3/-2)
tests/qml/tst_SingleSim.qml (+2/-2)
description: | updated |
Changed in messaging-app (Ubuntu): | |
importance: | Undecided → High |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
importance: | Undecided → High |
Changed in canonical-devices-system-image: | |
importance: | Undecided → High |
status: | New → Fix Committed |
assignee: | nobody → Bill Filler (bfiller) |
milestone: | none → 13 |
Changed in messaging-app (Ubuntu): | |
status: | Confirmed → Fix Committed |
status: | Fix Committed → Fix Released |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
Status changed to 'Confirmed' because the bug affects multiple users.