[regression] Some EGL clients don't get bypassed any more in fullscreen
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Medium
|
Daniel van Vugt | ||
mesa (Ubuntu) |
Confirmed
|
Medium
|
Unassigned | ||
unity8 (Ubuntu) |
Invalid
|
Undecided
|
Unassigned |
Bug Description
[regression] Fullscreen GL apps don't get bypassed any more.
As you can see in compositor report from any of our demo servers:
[1438572052.621854] compositor: Display 0x7faea4306fa0 averaged 60.537 FPS, 0.506 ms/frame, latency 15.669 ms, 61 frames over 1.007 sec, 0% bypassed
[1438572053.622668] compositor: Display 0x7faea4306fa0 averaged 59.950 FPS, 0.551 ms/frame, latency 15.814 ms, 60 frames over 1.000 sec, 0% bypassed
[1438572054.623370] compositor: Display 0x7faea4306fa0 averaged 59.958 FPS, 0.613 ms/frame, latency 15.721 ms, 60 frames over 1.000 sec, 0% bypassed
I think this is only "medium" though, because it's a transparent optimization so its absence is very hard to notice in most cases.
Related branches
- Daniel van Vugt: Needs Information
- Kevin DuBois (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Alan Griffiths: Abstain
-
Diff: 509 lines (+168/-38)26 files modifieddebian/control (+4/-4)
debian/mir-client-platform-android4.install (+1/-1)
debian/mir-client-platform-mesa4.install (+1/-1)
examples/eglapp.c (+2/-1)
examples/scroll.cpp (+2/-1)
include/client/mir_toolkit/mir_connection.h (+6/-1)
src/client/mir_connection.cpp (+3/-2)
src/client/mir_connection.h (+2/-1)
src/client/mir_connection_api.cpp (+14/-2)
src/client/symbols.map (+7/-1)
src/include/client/mir/client_platform.h (+2/-1)
src/platforms/CMakeLists.txt (+1/-1)
src/platforms/android/client/android_client_platform.cpp (+1/-1)
src/platforms/android/client/android_client_platform.h (+2/-1)
src/platforms/android/client/symbols.map (+1/-1)
src/platforms/mesa/client/client_platform.cpp (+18/-2)
src/platforms/mesa/client/client_platform.h (+2/-1)
src/platforms/mesa/client/symbols.map (+1/-1)
tests/acceptance-tests/test_client_library_errors.cpp (+2/-1)
tests/mir_test_framework/stub_client_platform_factory.cpp (+2/-1)
tests/mir_test_framework/symbols-client.map (+1/-1)
tests/unit-tests/client/android/test_android_client_platform.cpp (+8/-4)
tests/unit-tests/client/mesa/test_client_platform.cpp (+79/-3)
tests/unit-tests/client/test_client_buffer_stream.cpp (+2/-1)
tests/unit-tests/client/test_client_mir_surface.cpp (+2/-1)
tests/unit-tests/client/test_mir_connection.cpp (+2/-2)
- PS Jenkins bot (community): Approve (continuous-integration)
- Alan Griffiths: Approve
- Chris Halse Rogers: Approve
- Kevin DuBois (community): Approve
-
Diff: 44 lines (+18/-2)1 file modifiedexamples/eglapp.c (+18/-2)
Changed in mir: | |
status: | Triaged → In Progress |
tags: | added: mir-mesa |
tags: |
added: egl-platform-mir removed: mir-mesa |
Changed in mir: | |
milestone: | 0.16.0 → 0.15.0 |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Changed in mesa (Ubuntu): | |
importance: | Undecided → Medium |
Dropped severity again. Although elgtriangle and eglplasma don't bypass any more, eglsquare does get bypassed.