menulibre save changes confirmation dialog is handled wrong

Bug #1307481 reported by flux242
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
MenuLibre
Fix Released
High
Sean Davis
menulibre (Ubuntu)
Confirmed
Undecided
Unassigned
Trusty
Confirmed
Undecided
Unassigned

Bug Description

[SRU - Test Case]
1. Modify a launcher, do not save.
2. Click on another launcher.
3. Save dialog appears. Click "Save changes".

[SRU - Expected Results]
[[MenuLibre 2.0.3]]
The launcher is saved, but the next item cannot be activated.

[[Menulibre 2.0.4]]
The launcher is saved, and the intended launcher is activated.

[Original Report]
If I change some properties of a menu item, say visibility flag, and then click on the next menu item a 'save changes' confirmation dialog appears. If I click Save then the previous menu item stays selected. I click on the next menu item again and this 'save changes' confirmation dialog appears again! It won't let me continue with the next menu item until I click Cancel even if I previously clicked Save a thousand times!

ubuntu 14.04 lts beta 2
menulibre 2.0.3-1

Revision history for this message
flux242 (flux242) wrote :

Here is the error message I get:

DEBUG:menulibre: save_launcher() 'Executing Command: ['xdg-desktop-menu', 'install', '--novendor', '/home/alex/.local/share/applications/exo-mail-reader.desktop']'
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/menulibre/MenulibreApplication.py", line 1472, in on_treeview_selection
    self.save_launcher()
  File "/usr/lib/python3/dist-packages/menulibre/MenulibreApplication.py", line 2237, in save_launcher
    subprocess.call(cmd_list)
  File "/usr/lib/python3.4/subprocess.py", line 533, in call
    with Popen(*popenargs, **kwargs) as p:
  File "/usr/lib/python3.4/subprocess.py", line 848, in __init__
    restore_signals, start_new_session)
  File "/usr/lib/python3.4/subprocess.py", line 1446, in _execute_child
    raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'xdg-desktop-menu'

Yes, the xdg-desktop-menu is not installed on my system. If menulibre needs it to function properly then it should have a direct dependency to a package that has this executable. Current dependency is probably in the recommends section and that's why it is not installed. Would be better not to have this dependency at all

Revision history for this message
Sean Davis (bluesabre) wrote :

I'll make sure the required package (xdg-utils) is added to the dependency list in Debian and Ubuntu. In a later release, we may be able to break the dependency on this package, but it is currently essential to create the necessary menu structure.

Sean Davis (bluesabre)
Changed in menulibre:
status: New → Confirmed
assignee: nobody → Sean Davis (smd-seandavis)
status: Confirmed → Triaged
importance: Undecided → High
Sean Davis (bluesabre)
Changed in menulibre:
status: Triaged → Fix Committed
Sean Davis (bluesabre)
Changed in menulibre:
milestone: none → 2.0.4
Sean Davis (bluesabre)
Changed in menulibre:
status: Fix Committed → Fix Released
Sean Davis (bluesabre)
description: updated
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello flux242, or anyone else affected,

Accepted menulibre into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/menulibre/2.0.4-1~ubuntu14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Revision history for this message
Sean Davis (bluesabre) wrote :
tags: added: verification-done
removed: verification-needed
Revision history for this message
Adam Conrad (adconrad) wrote : Update Released

The verification of the Stable Release Update for menulibre has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in menulibre (Ubuntu Trusty):
status: New → Confirmed
Changed in menulibre (Ubuntu):
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.