org.mpris.MediaPlayer2.MediaHub player is exposed at startup, making the indicator show a player that it's not fully functional

Bug #1544543 reported by Xavi Garcia
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Confirmed
High
John McAleely
Ubuntu UX
New
Undecided
Unassigned
media-hub (Ubuntu)
In Progress
High
Jim Hodapp
media-hub (Ubuntu RTM)
In Progress
High
Jim Hodapp

Bug Description

At boot the indicator-sound is showing a player that we cannot launch and with all playback controls disabled.
It shows the "Media Player", not the music app.

After some investigation I saw that the following player is appearing on the dbus:

(process:7236): indicator-sound-WARNING **: media-player-list-mpris.vala:115: Player appeared: org.mpris.MediaPlayer2.MediaHub

(process:7236): indicator-sound-WARNING **: media-player-list-mpris.vala:118: Player desktop entry: mediaplayer-app

I'm not sure the desktop entry is valid and, in fact, the user cannot do anything with this player.

I also noticed that, when starting the music-app, it does not make any new player to appear on the dbus. (we only have the media-hub).

I'm not sure how to proceed with this, because some people has asked why we are showing that player at the beginning.

I understand the media-hub is a bridge for sound on the phone, but I'm not sure what we do now is correct.

I was thinking on ignoring the media-hub player at startup, but if then we don't get any other player when we start a music app the indicator won't have any player at all.

Maybe the media-hub should publish the information of the actual player when it starts playing music.

Changed in media-hub (Ubuntu):
importance: Undecided → Medium
importance: Medium → High
Jim Hodapp (jhodapp)
Changed in media-hub (Ubuntu RTM):
importance: Undecided → High
Changed in canonical-devices-system-image:
assignee: nobody → John McAleely (john.mcaleely)
Changed in media-hub (Ubuntu):
assignee: nobody → Jim Hodapp (jhodapp)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

After having a discussion with the indicator team, the proposal is to make sure that media-hub exports a generic default string for the case when there is no current player. This happens directly after a fresh bootup. In this case, indicator-sound can simply hide itself until a player is loaded.

Also, once the functionality that sets the current player is changed from a UI focus-based approach to a last-played approach, media-hub will more accurately export the correct current player over MPRIS to indicator-sound. This is a separate bug: https://bugs.launchpad.net/ubuntu/+source/indicator-sound/+bug/1538703

Jim Hodapp (jhodapp)
Changed in media-hub (Ubuntu RTM):
assignee: nobody → Jim Hodapp (jhodapp)
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

Seems if there is no previously active player we shouldn't show anything or is thatthe intent

Changed in canonical-devices-system-image:
importance: Undecided → High
milestone: none → ww08-2016
status: New → Confirmed
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

To clarify, “indicator-sound can simply hide itself” should be “indicator-sound can simply omit the playback section of the menu”. The rest of the menu should still be present.

I doubt that’s a good solution, though, for two reasons. First, if a system component pretends to be an app, that pseudo-app will keep appearing confusingly in places we don’t expect: trust prompts, storage consumption UI, network activity UI, etc. Needing to hide it in every place it might appear is just asking for bugs.

Second, it would mean there are no playback controls in many cases where people would expect them.

The player should be whichever app the user sees as being responsible for the playback. So in the case of Media Hub, the player is whichever app sent the stream to Media Hub.

Here’s a perfectly reasonable but probably-difficult-to-implement test case:
1. Send a message to a Gmail address, containing a link to a YouTube music video.
2. In the Gmail app, open the message.
3. Start playing the video.
4. Switch to another app.
5. Open the sound menu.

What you should see: “Gmail” with playback controls.

What you currently see: “Media Player” with no playback controls.

Revision history for this message
Jim Hodapp (jhodapp) wrote :

Yes thanks for that clarification as I did mean to say the control portion of indicator-sound, not the entire indicator itself.

Can you cite an example where a system component might act as an app? I want to make sure that this isn't only a hypothetical situation. Also, I'm not sure how the second part of your 2nd paragraph is relevant for this bug. That seems like one or more separate bugs to solve if a system component is showing up undesirably in those other situations.

The example scenario that you give isn't a good one to demonstrate the current bug only because Oxide and media-hub integration aren't fully implemented and usually requires special handling when compared to the average application. The main case that's not currently clear in my mind is what do we want to display in indicator-sound on a fresh boot of the phone. If the controls are not hidden, then what should it look like and how should it behave?

A second thing to solve will be the case when all media applications have been closed by the user essentially getting back to the first boot state. All media-hub sessions have been closed so any track metadata and the playlist associated with that session have been lost. So we can't simply keep allowing the MPRIS controls to control the last media-hub session because it's no longer valid. So do we hide the controls? If not, what else can we do?

Changed in canonical-devices-system-image:
status: Confirmed → In Progress
Changed in media-hub (Ubuntu):
status: New → In Progress
Changed in media-hub (Ubuntu RTM):
status: New → In Progress
Changed in canonical-devices-system-image:
milestone: ww08-2016 → 11
Changed in canonical-devices-system-image:
milestone: 11 → 12
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

No progress move to backlog

Changed in canonical-devices-system-image:
milestone: 12 → backlog
status: In Progress → Confirmed
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

oops stomped on johns change

Changed in canonical-devices-system-image:
milestone: backlog → 12
Changed in canonical-devices-system-image:
milestone: 12 → 13
Changed in canonical-devices-system-image:
milestone: 13 → backlog
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.