removeSource and insertSource needs to maintain currentIndex correctly
Bug #1511073 reported by
Andrew Hayzen
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Critical
|
John McAleely | ||
| media-hub (Ubuntu) |
Triaged
|
Critical
|
Alfonso Sanchez-Beato | ||
| media-hub (Ubuntu RTM) |
Fix Released
|
Critical
|
Alfonso Sanchez-Beato | ||
| qtubuntu-media (Ubuntu) |
Fix Released
|
Critical
|
Alfonso Sanchez-Beato | ||
| qtubuntu-media (Ubuntu RTM) |
Fix Released
|
Critical
|
Alfonso Sanchez-Beato | ||
Bug Description
The currentIndex needs to be maintained correctly when performing {remove,
- If removeSource is for an index less than the currentIndex then the currentIndex needs to be decremented.
- If removeSource is for the same index as currentIndex then next() should be called
- If insertSource is for an index less than or equal to the currentIndex then the currentIndex needs to be incremented
Related branches
lp://staging/~phablet-team/media-hub/bg-playlist-fixes
- Jim Hodapp (community): Approve (code)
-
Diff: 703 lines (+237/-42)11 files modifiedinclude/core/media/track_list.h (+8/-0)
src/core/media/mpris/service.h (+12/-0)
src/core/media/mpris/track_list.h (+17/-0)
src/core/media/player_implementation.cpp (+12/-0)
src/core/media/service_skeleton.cpp (+22/-6)
src/core/media/track_list.cpp (+5/-0)
src/core/media/track_list_implementation.cpp (+25/-18)
src/core/media/track_list_skeleton.cpp (+102/-16)
src/core/media/track_list_skeleton.h (+4/-0)
src/core/media/track_list_stub.cpp (+29/-2)
src/core/media/track_list_stub.h (+1/-0)
lp://staging/~phablet-team/qtubuntu-media/bg-playlist-fixes
- Jim Hodapp (community): Approve (code)
-
Diff: 615 lines (+293/-33)8 files modifiedsrc/aal/aalmediaplayercontrol.cpp (+20/-11)
src/aal/aalmediaplayerservice.cpp (+5/-6)
src/aal/aalmediaplaylistcontrol.cpp (+19/-1)
src/aal/aalmediaplaylistcontrol.h (+2/-0)
src/aal/aalmediaplaylistprovider.cpp (+107/-13)
src/aal/aalmediaplaylistprovider.h (+9/-0)
tests/integration/tst_mediaplaylist.cpp (+126/-2)
tests/integration/tst_mediaplaylist.h (+5/-0)
| summary: |
- removeSource and insertSource need to maintain currentIndex correctly + removeSource and insertSource needs to maintain currentIndex correctly |
| tags: | added: bgplaylist |
| Changed in qtubuntu-media (Ubuntu): | |
| status: | New → Triaged |
| Changed in qtubuntu-media (Ubuntu RTM): | |
| status: | New → Triaged |
| Changed in canonical-devices-system-image: | |
| status: | New → Confirmed |
| Changed in qtubuntu-media (Ubuntu): | |
| importance: | Undecided → Critical |
| Changed in qtubuntu-media (Ubuntu RTM): | |
| importance: | Undecided → Critical |
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → John McAleely (john.mcaleely) |
| importance: | Undecided → Critical |
| milestone: | none → ww46-2015 |
| Changed in qtubuntu-media (Ubuntu): | |
| status: | Triaged → In Progress |
| Changed in qtubuntu-media (Ubuntu RTM): | |
| status: | Triaged → In Progress |
| Changed in qtubuntu-media (Ubuntu): | |
| status: | In Progress → Triaged |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → In Progress |
| Changed in qtubuntu-media (Ubuntu RTM): | |
| assignee: | nobody → Alfonso Sanchez-Beato (alfonsosanchezbeato) |
| Changed in media-hub (Ubuntu): | |
| status: | New → Confirmed |
| assignee: | nobody → Alfonso Sanchez-Beato (alfonsosanchezbeato) |
| Changed in canonical-devices-system-image: | |
| milestone: | ww46-2015 → ww02-2016 |
| Changed in canonical-devices-system-image: | |
| milestone: | ww02-2016 → ww46-2015 |
| Changed in canonical-devices-system-image: | |
| milestone: | ww46-2015 → ww02-2016 |
| Changed in media-hub (Ubuntu RTM): | |
| status: | New → Triaged |
| Changed in media-hub (Ubuntu): | |
| status: | Confirmed → Triaged |
| Changed in media-hub (Ubuntu RTM): | |
| status: | Triaged → In Progress |
| importance: | Undecided → Critical |
| Changed in media-hub (Ubuntu): | |
| importance: | Undecided → Critical |
| Changed in media-hub (Ubuntu RTM): | |
| assignee: | nobody → Alfonso Sanchez-Beato (alfonsosanchezbeato) |
| Changed in qtubuntu-media (Ubuntu): | |
| assignee: | nobody → Alfonso Sanchez-Beato (alfonsosanchezbeato) |
| Changed in qtubuntu-media (Ubuntu RTM): | |
| status: | In Progress → Fix Committed |
| Changed in media-hub (Ubuntu RTM): | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Łukasz Zemczak (sil2100) wrote | #1 |
| Changed in qtubuntu-media (Ubuntu RTM): | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Łukasz Zemczak (sil2100) wrote | #2 |
| Changed in media-hub (Ubuntu RTM): | |
| status: | Fix Committed → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in qtubuntu-media (Ubuntu): | |
| status: | Triaged → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package qtubuntu-media 0.8.0+15.
---------------
qtubuntu-media (0.8.0+
[ phablet ]
* Bump version for new TrackList related API changes.
[ Alfonso Sanchez-Beato ]
* Emit onPlaybackModeC
so that a client can move a track into a new position by first
calling removeTrack(). Do proper clean-up when switching between
playlist and playing a single URI (LP: #1511029). (LP: #1511073,
#1511034, #1510219, #1511029)
[ CI Train Bot ]
* New rebuild forced.
[ Jim Hodapp ]
* Emit onPlaybackModeC
so that a client can move a track into a new position by first
calling removeTrack(). Do proper clean-up when switching between
playlist and playing a single URI (LP: #1511029). (LP: #1511073,
#1511034, #1510219, #1511029)
-- Jim Hodapp <email address hidden> Wed, 18 Nov 2015 16:32:22 +0000