log_progress_msg overridden with empty function in /etc/lsb-base-logging.sh
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
lsb (Ubuntu) |
Triaged
|
Wishlist
|
Unassigned |
Bug Description
Binary package hint: lsb-base
The functions in /etc/lsb-
In particular it override log_progress_msg with the following code:
===========
...
log_progress_msg () {
:
}
...
===========
There is really little surprise in the fact no output is given.
Is this behavior intended?
If so: why?
fixing this is rather trivial, bu I would like to understand the "why" before touching anything
If that's relevant:
===========
mauro@heimdall:~$ lsb_release -rd
Description: Ubuntu 8.04.1
Release: 8.04
mauro@heimdall:~$ apt-cache policy lsb-base
lsb-base:
Installato: 3.2-4ubuntu1
Candidato: 3.2-4ubuntu1
Tabella versione:
*** 3.2-4ubuntu1 0
500 http://
100 /var/lib/
===========
UPDATE:
I changed my /etc/lsb-
If someone is interested these are the diffs:
===========
mauro@heimdall:
--- lsb-base-
+++ lsb-base-logging.sh 2008-10-14 10:55:05.000000000 +0200
@@ -87,6 +87,7 @@
COLS=80
COL=73
fi
+ if [ -n "$2" ]; then #normal case
# We leave the cursor `hanging' about-to-wrap (see terminfo(5)
# xenl, which is approximately right). That way if the script
# prints anything then we will be on the next line and not
@@ -99,6 +100,13 @@
# asterisk ought to go.
printf " * $* "
+ unset DO_PROGRESS
+ else #prepare for log_progress_msg
+ printf " * $1"
+ $TPUT sc
+ printf " "
+ DO_PROGRESS='t'
+ fi
# Enough trailing spaces for ` [fail]' to fit in; if the message
# is too long it wraps here rather than later, which is what we
# want.
@@ -111,7 +119,24 @@
}
log_progress_msg () {
- :
+ if [ -n $DO_PROGRESS ]; then
+ $TPUT rc
+ printf " $*"
+ $TPUT sc
+ printf " "
+ $TPUT hpa `$EXPR $COLS - 1`
+ printf ' '
+ fi
+}
+
+log_progress_msg1 () {
+ if [ -n $DO_PROGRESS ]; then
+ $TPUT rc
+ printf " $*"
+ $TPUT el
+ $TPUT hpa `$EXPR $COLS - 1`
+ printf ' '
+ fi
}
log_end_msg () {
===========
They appear to work correctly at least within gnome-terminal and at the linux console.
TiA
ZioNemo
description: | updated |
Changed in lsb (Ubuntu): | |
status: | Confirmed → Triaged |
Progress reporting is handled via usplash, so this function has been stubbed out. It might make sense to rearrange things to call progress via the lsb scripts and detect usplash like the others do.