Location service state should distinguish between enabled/disabled and active/inactive
Bug #1536774 reported by
Thomas Voß
This bug affects 7 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Critical
|
Alejandro J. Cura | ||
| location-service (Ubuntu) |
Fix Released
|
Critical
|
Thomas Voß | ||
Bug Description
Service state should distinguish between enabled/disabled and active/inactive
To make usage of that solution I would like to propose new icons which are added in bug report:
https:/
GPS Disabled: No icon displayed
GPS Enabled, GPS active: Display https:/
GPS Enabled, GPS inactive: Display https:/
Related branches
lp://staging/~thomas-voss/location-service/expose-engine-state-information
- Marcus Tomlinson (community): Approve
- Scott Sweeny (community): Approve
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 1022 lines (+597/-61)19 files modifiedinclude/location_service/com/ubuntu/location/codec.h (+45/-0)
include/location_service/com/ubuntu/location/service/interface.h (+24/-0)
include/location_service/com/ubuntu/location/service/skeleton.h (+8/-0)
include/location_service/com/ubuntu/location/service/state.h (+43/-0)
include/location_service/com/ubuntu/location/service/stub.h (+2/-0)
src/location_service/com/ubuntu/location/CMakeLists.txt (+2/-0)
src/location_service/com/ubuntu/location/engine.cpp (+19/-21)
src/location_service/com/ubuntu/location/engine.h (+4/-14)
src/location_service/com/ubuntu/location/service/daemon.cpp (+13/-0)
src/location_service/com/ubuntu/location/service/daemon.h (+3/-0)
src/location_service/com/ubuntu/location/service/implementation.cpp (+31/-6)
src/location_service/com/ubuntu/location/service/skeleton.cpp (+33/-0)
src/location_service/com/ubuntu/location/service/state.cpp (+71/-0)
src/location_service/com/ubuntu/location/service/stub.cpp (+7/-0)
src/location_service/com/ubuntu/location/state_tracking_provider.h (+162/-0)
tests/CMakeLists.txt (+1/-0)
tests/daemon_and_cli_tests.cpp (+10/-0)
tests/engine_test.cpp (+0/-20)
tests/state_tracking_provider_test.cpp (+119/-0)
| Changed in location-service (Ubuntu): | |
| assignee: | nobody → Thomas Voß (thomas-voss) |
| description: | updated |
| description: | updated |
Revision history for this message
| Alberto Mardegan (mardy) wrote | #1 |
| Changed in canonical-devices-system-image: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| summary: |
- Service state should distinguish between enabled/disabled and + Location service state should distinguish between enabled/disabled and active/inactive |
Revision history for this message
| Pat McGowan (pat-mcgowan) wrote | #2 |
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Alejandro J. Cura (alecu) |
| importance: | Medium → Critical |
| milestone: | none → 12 |
| Changed in location-service (Ubuntu): | |
| importance: | High → Critical |
| Changed in location-service (Ubuntu): | |
| status: | Confirmed → In Progress |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → In Progress |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in location-service (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
See also bug 1509260. I think what is most useful to know is not whether the GPS is active, but whether a position has been obtained (regardless of whether it was obtained via GPS or cellular triangulation).
Well, ideally I'd like the indicator to report the precision as well: it would be cool for example if the dot in the center of the icon were green if the position has a high accuracy, and yellow if it's in the range of hundreds of metres.